From a2faeda272c08fb45c96006cd52a90d73d3b18bb Mon Sep 17 00:00:00 2001
From: Samuel Jackson <samueljackson@outlook.com>
Date: Thu, 19 Jul 2018 15:38:36 +0100
Subject: [PATCH] Update all clang & gcc warnings to macros
---
.../API/test/FunctionParameterDecoratorTest.h | 4 +-
Framework/API/test/ILatticeFunctionTest.h | 4 +-
.../API/test/ImplicitFunctionFactoryTest.h | 4 +-
...plicitFunctionParameterParserFactoryTest.h | 4 +-
Framework/API/test/LiveListenerTest.h | 4 +-
Framework/API/test/ModeratorModelTest.h | 4 +-
Framework/API/test/WorkspaceFactoryTest.h | 15 ++--
Framework/API/test/WorkspaceGroupTest.h | 4 +-
.../test/MCAbsorptionStrategyTest.h | 4 +-
.../test/MaxEnt/MaxentCalculatorTest.h | 4 +-
Framework/Algorithms/test/MonteCarloTesting.h | 4 +-
.../Algorithms/test/RebinByTimeBaseTest.h | 4 +-
.../Crystal/test/FindSXPeaksHelperTest.h | 4 +-
Framework/Crystal/test/MockObjects.h | 4 +-
Framework/Crystal/test/PeakBackgroundTest.h | 4 +-
.../src/Functions/CrystalElectricField.cpp | 14 ++--
.../inc/MantidDataObjects/MDGridBox.tcc | 4 +-
.../DataObjects/src/MDHistoWorkspace.cpp | 2 +-
.../DataObjects/test/MDBoxIteratorTest.h | 8 +-
Framework/DataObjects/test/MDGridBoxTest.h | 4 +-
Framework/DataObjects/test/MockObjects.h | 4 +-
Framework/Geometry/src/Objects/RuleItems.cpp | 8 +-
.../src/Rendering/GeometryTriangulator.cpp | 8 +-
.../src/Rendering/RenderingHelpers.cpp | 8 +-
Framework/Geometry/src/Surfaces/Cone.cpp | 8 +-
Framework/Geometry/src/Surfaces/Cylinder.cpp | 8 +-
Framework/Geometry/src/Surfaces/Plane.cpp | 8 +-
Framework/Geometry/src/Surfaces/Sphere.cpp | 8 +-
Framework/Geometry/src/Surfaces/Surface.cpp | 8 +-
Framework/Geometry/src/Surfaces/Torus.cpp | 8 +-
Framework/Geometry/test/BasicHKLFiltersTest.h | 4 +-
.../Geometry/test/BraggScattererFactoryTest.h | 4 +-
.../BraggScattererInCrystalStructureTest.h | 4 +-
Framework/Geometry/test/BraggScattererTest.h | 4 +-
Framework/Geometry/test/CSGObjectTest.h | 4 +-
.../test/CompositeImplicitFunctionTest.h | 4 +-
Framework/Geometry/test/GroupTest.h | 18 ++---
Framework/Geometry/test/HKLFilterTest.h | 4 +-
.../test/InstrumentDefinitionParserTest.h | 4 +-
.../Geometry/test/MDGeometryXMLBuilderTest.h | 4 +-
Framework/Geometry/test/MeshObjectTest.h | 4 +-
Framework/Geometry/test/MockObjects.h | 4 +-
.../Geometry/test/PeakTransformSelectorTest.h | 4 +-
.../Geometry/test/SampleEnvironmentTest.h | 4 +-
.../Geometry/test/SpaceGroupFactoryTest.h | 4 +-
.../test/StructureFactorCalculatorTest.h | 4 +-
.../test/SymmetryElementFactoryTest.h | 4 +-
Framework/Geometry/test/SymmetryElementTest.h | 4 +-
Framework/ICat/src/CatalogSearch.cpp | 4 +-
Framework/ICat/src/GSoap.cpp | 14 ++--
Framework/ICat/src/GSoap/stdsoap2.cpp | 30 +++----
.../ICat/src/ICat3/ICat3GSoapGenerated.cpp | 14 ++--
Framework/ICat/src/ICat3/ICat3Helper.cpp | 2 +-
.../ICat/src/ICat4/ICat4GSoapGenerated.cpp | 14 ++--
.../Kernel/inc/MantidKernel/PropertyHelper.h | 13 +--
.../inc/MantidKernel/WarningSuppressions.h | 35 ++++----
.../inc/MantidKernel/normal_distribution.h | 8 +-
Framework/Kernel/test/MDUnitFactoryTest.h | 4 +-
.../Kernel/test/NDRandomNumberGeneratorTest.h | 4 +-
Framework/Kernel/test/UserCatalogInfoTest.h | 4 +-
.../MantidLiveData/ISIS/TCPEventStreamDefs.h | 28 ++++---
.../src/ISIS/ISISHistoDataListener.cpp | 2 +-
.../src/ISIS/ISISLiveEventDataListener.cpp | 2 +-
.../src/Kafka/KafkaEventStreamDecoder.cpp | 8 +-
Framework/LiveData/test/KafkaTesting.h | 12 ++-
Framework/MDAlgorithms/src/LoadSQW2.cpp | 17 ++--
Framework/MDAlgorithms/test/BinMDTest.h | 4 +-
.../MDAlgorithms/test/BinaryOperationMDTest.h | 4 +-
.../test/BooleanBinaryOperationMDTest.h | 4 +-
Framework/MDAlgorithms/test/LoadSQW2Test.h | 18 ++---
.../test/PreprocessDetectorsToMDTest.h | 1 -
.../MDAlgorithms/test/UnaryOperationMDTest.h | 4 +-
.../mantid/api/src/Exports/Algorithm.cpp | 20 ++---
.../api/src/Exports/AlgorithmFactory.cpp | 25 +++---
.../api/src/Exports/AlgorithmManager.cpp | 20 ++---
.../mantid/api/src/Exports/Axis.cpp | 21 +++--
.../api/src/Exports/CompositeFunction.cpp | 20 ++---
.../mantid/api/src/Exports/ExperimentInfo.cpp | 20 ++---
.../mantid/api/src/Exports/FileFinder.cpp | 20 ++---
.../mantid/api/src/Exports/IFunction.cpp | 20 ++---
.../mantid/api/src/Exports/IMaskWorkspace.cpp | 2 +-
.../api/src/Exports/MatrixWorkspace.cpp | 20 ++---
.../mantid/api/src/Exports/Projection.cpp | 2 +-
.../mantid/api/src/Exports/Run.cpp | 20 ++---
.../mantid/api/src/Exports/Workspace.cpp | 21 ++---
.../api/src/Exports/WorkspaceFactory.cpp | 20 ++---
.../src/PythonAlgorithm/AlgorithmAdapter.cpp | 29 +++----
.../mantid/geometry/src/Exports/Component.cpp | 21 +++--
.../geometry/src/Exports/Goniometer.cpp | 20 ++---
.../geometry/src/Exports/IMDDimension.cpp | 2 +-
.../kernel/src/Converters/DateAndTime.cpp | 14 ++--
.../kernel/src/Converters/PyObjectToVMD.cpp | 2 +-
.../kernel/src/Exports/ConfigService.cpp | 20 ++---
.../mantid/kernel/src/Exports/Property.cpp | 19 ++---
.../mantid/kernel/src/Exports/Statistics.cpp | 80 +++++++++----------
.../src/Registry/PropertyWithValueFactory.cpp | 18 ++---
.../WorkspaceCreationHelperModule.cpp | 20 ++---
.../PoldiMockInstrumentHelpers.h | 8 +-
.../test/PoldiSpectrumPawleyFunctionTest.h | 4 +-
MantidPlot/src/PythonScript.cpp | 14 ++--
.../Sources/MDEWSource/vtkMDEWSource.cxx | 2 +-
.../src/vtkDataSetToPeaksFilteredDataSet.cpp | 3 +-
qt/paraview_ext/VatesAPI/test/BoxInfoTest.h | 2 +-
.../test/ConcretePeaksPresenterVsiTest.h | 6 +-
.../test/MDEWInMemoryLoadingPresenterTest.h | 4 +-
.../test/MDHWInMemoryLoadingPresenterTest.h | 4 +-
qt/paraview_ext/VatesAPI/test/MockObjects.h | 16 ++--
.../test/VatesKnowledgeSerializerTest.h | 4 +-
.../VatesAPI/test/vtkDataSetFactoryTest.h | 4 +-
.../vtkDataSetToPeaksFilteredDataSetTest.h | 4 +-
.../VatesAPI/test/vtkPeakMarkerFactoryTest.h | 4 +-
.../ViewWidgets/src/ViewBase.cpp | 2 +-
.../test/ALCBaselineModellingPresenterTest.h | 4 +-
.../test/ALCDataLoadingPresenterTest.h | 4 +-
.../test/ALCPeakFittingPresenterTest.h | 4 +-
.../test/EnggDiffFittingModelMock.h | 4 +-
.../test/EnggDiffFittingViewMock.h | 4 +-
.../test/EnggDiffGSASFittingModelMock.h | 4 +-
.../test/EnggDiffGSASFittingViewMock.h | 4 +-
.../EnggDiffMultiRunFittingWidgetModelMock.h | 4 +-
...ggDiffMultiRunFittingWidgetPresenterMock.h | 4 +-
.../EnggDiffMultiRunFittingWidgetViewMock.h | 4 +-
.../test/EnggDiffractionParamMock.h | 4 +-
.../test/EnggDiffractionViewMock.h | 4 +-
.../test/MuonAnalysisFitDataPresenterTest.h | 8 +-
.../MuonAnalysisFitFunctionPresenterTest.h | 8 +-
.../test/ReflMeasureTransferStrategyTest.h | 4 +-
.../test/ReflMockObjects.h | 4 +-
.../Common/DataProcessorUI/MockObjects.h | 4 +-
.../ProgressableViewMockObject.h | 4 +-
.../WorkspaceDockMockObjects.h | 6 +-
.../common/test/ProjectSaveMockObjects.h | 2 +-
qt/widgets/legacyqwt/test/SignalRangeTest.h | 4 +-
qt/widgets/sliceviewer/test/MockObjects.h | 4 +-
134 files changed, 591 insertions(+), 597 deletions(-)
diff --git a/Framework/API/test/FunctionParameterDecoratorTest.h b/Framework/API/test/FunctionParameterDecoratorTest.h
index aaaa04dea73..c5a2c508da3 100644
--- a/Framework/API/test/FunctionParameterDecoratorTest.h
+++ b/Framework/API/test/FunctionParameterDecoratorTest.h
@@ -443,9 +443,9 @@ private:
class MockTestableFunctionParameterDecorator
: public TestableFunctionParameterDecorator {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD1(beforeDecoratedFunctionSet, void(const IFunction_sptr &));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
};
diff --git a/Framework/API/test/ILatticeFunctionTest.h b/Framework/API/test/ILatticeFunctionTest.h
index ba66cf38f8a..a64dc65bd21 100644
--- a/Framework/API/test/ILatticeFunctionTest.h
+++ b/Framework/API/test/ILatticeFunctionTest.h
@@ -73,7 +73,7 @@ public:
private:
std::vector<V3D> getTestHKLs() { return {{1, 1, 0}}; }
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
// Mock function to check whether the correct methods are called
class MockLatticeFunction : public ILatticeFunction {
public:
@@ -104,6 +104,6 @@ private:
};
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif /* MANTID_API_ILATTICEFUNCTIONTEST_H_ */
diff --git a/Framework/API/test/ImplicitFunctionFactoryTest.h b/Framework/API/test/ImplicitFunctionFactoryTest.h
index 36efc10b6d3..30b1acfa60e 100644
--- a/Framework/API/test/ImplicitFunctionFactoryTest.h
+++ b/Framework/API/test/ImplicitFunctionFactoryTest.h
@@ -16,7 +16,7 @@
#include <memory>
#include <vector>
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class ImplicitFunctionFactoryTest : public CxxTest::TestSuite {
private:
@@ -107,7 +107,7 @@ private:
MOCK_METHOD1(setSuccessorParser,
void(Mantid::API::ImplicitFunctionParameterParser *successor));
};
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
class MockImplicitFunctionBuilderA
: public Mantid::API::ImplicitFunctionBuilder {
diff --git a/Framework/API/test/ImplicitFunctionParameterParserFactoryTest.h b/Framework/API/test/ImplicitFunctionParameterParserFactoryTest.h
index 2498543082a..86b2f1f05b5 100644
--- a/Framework/API/test/ImplicitFunctionParameterParserFactoryTest.h
+++ b/Framework/API/test/ImplicitFunctionParameterParserFactoryTest.h
@@ -17,11 +17,11 @@ private:
class MockImplicitFunctionParameter
: public Mantid::API::ImplicitFunctionParameter {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(getName, std::string());
MOCK_CONST_METHOD0(isValid, bool());
MOCK_CONST_METHOD0(toXMLString, std::string());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
protected:
ImplicitFunctionParameter *clone() const override {
return new MockImplicitFunctionParameter;
diff --git a/Framework/API/test/LiveListenerTest.h b/Framework/API/test/LiveListenerTest.h
index e666b76a062..f26d77e8c48 100644
--- a/Framework/API/test/LiveListenerTest.h
+++ b/Framework/API/test/LiveListenerTest.h
@@ -14,7 +14,7 @@ public:
// Set this flag to true for testing
m_dataReset = true;
}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(name, std::string());
MOCK_CONST_METHOD0(supportsHistory, bool());
MOCK_CONST_METHOD0(buffersEvents, bool());
@@ -25,7 +25,7 @@ public:
MOCK_METHOD0(runStatus, RunStatus());
MOCK_CONST_METHOD0(runNumber, int());
MOCK_METHOD1(setAlgorithm, void(const Mantid::API::IAlgorithm &));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
class LiveListenerTest : public CxxTest::TestSuite {
diff --git a/Framework/API/test/ModeratorModelTest.h b/Framework/API/test/ModeratorModelTest.h
index 3796f487eaf..1ae863636e8 100644
--- a/Framework/API/test/ModeratorModelTest.h
+++ b/Framework/API/test/ModeratorModelTest.h
@@ -13,13 +13,13 @@ public:
boost::shared_ptr<ModeratorModel> clone() const override {
return boost::shared_ptr<MockModerator>();
}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(emissionTimeMean, double());
MOCK_CONST_METHOD0(emissionTimeVariance, double());
MOCK_CONST_METHOD1(sampleTimeDistribution, double(const double));
MOCK_METHOD2(setParameterValue,
void(const std::string &, const std::string &));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
class ModeratorModelTest : public CxxTest::TestSuite {
diff --git a/Framework/API/test/WorkspaceFactoryTest.h b/Framework/API/test/WorkspaceFactoryTest.h
index b10fd94b474..5874d0870cb 100644
--- a/Framework/API/test/WorkspaceFactoryTest.h
+++ b/Framework/API/test/WorkspaceFactoryTest.h
@@ -9,6 +9,7 @@
#include "MantidAPI/Sample.h"
#include "MantidAPI/WorkspaceFactory.h"
#include "MantidKernel/ConfigService.h"
+#include "MantidKernel/WarningSuppressions.h"
#include "MantidTestHelpers/FakeObjects.h"
using Mantid::MantidVec;
@@ -55,15 +56,13 @@ public:
MatrixWorkspace_sptr space;
TS_ASSERT_THROWS_NOTHING(
space = WorkspaceFactory::Instance().create("work", 1, 1, 1));
-// AppleClang gives warning if the result is unused.
-#if __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-value"
-#endif
+ // clang-format off
+ DIAG_OFF(unused-value)
+ // clang-format on
TS_ASSERT_THROWS_NOTHING(dynamic_cast<WorkspaceTester *>(space.get()));
-#if __clang__
-#pragma clang diagnostic pop
-#endif
+ // clang-format off
+ DIAG_ON(unused-value)
+ // clang-format on
}
/** Make a parent, have the child be created with the same sizes */
diff --git a/Framework/API/test/WorkspaceGroupTest.h b/Framework/API/test/WorkspaceGroupTest.h
index 9cffbe83d9c..2e42b865bbb 100644
--- a/Framework/API/test/WorkspaceGroupTest.h
+++ b/Framework/API/test/WorkspaceGroupTest.h
@@ -58,13 +58,13 @@ private:
// Helper type, representing some concrete workspace type.
class MockWorkspace : public Mantid::API::Workspace {
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(id, const std::string());
MOCK_CONST_METHOD0(name, const std::string());
MOCK_CONST_METHOD0(threadSafe, bool());
MOCK_CONST_METHOD0(toString, const std::string());
MOCK_CONST_METHOD0(getMemorySize, size_t());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
private:
MockWorkspace *doClone() const override {
throw std::runtime_error("Cloning of MockWorkspace is not implemented.");
diff --git a/Framework/Algorithms/test/MCAbsorptionStrategyTest.h b/Framework/Algorithms/test/MCAbsorptionStrategyTest.h
index 2c87197dfa9..eda2cd82a2f 100644
--- a/Framework/Algorithms/test/MCAbsorptionStrategyTest.h
+++ b/Framework/Algorithms/test/MCAbsorptionStrategyTest.h
@@ -87,7 +87,7 @@ private:
class MockBeamProfile final : public Mantid::Algorithms::IBeamProfile {
public:
using Mantid::Algorithms::IBeamProfile::Ray;
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD1(generatePoint,
Ray(Mantid::Kernel::PseudoRandomNumberGenerator &));
MOCK_CONST_METHOD2(generatePoint,
@@ -95,7 +95,7 @@ private:
const Mantid::Geometry::BoundingBox &));
MOCK_CONST_METHOD1(defineActiveRegion, Mantid::Geometry::BoundingBox(
const Mantid::API::Sample &));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
};
diff --git a/Framework/Algorithms/test/MaxEnt/MaxentCalculatorTest.h b/Framework/Algorithms/test/MaxEnt/MaxentCalculatorTest.h
index 395a84ceea3..49de83f36a3 100644
--- a/Framework/Algorithms/test/MaxEnt/MaxentCalculatorTest.h
+++ b/Framework/Algorithms/test/MaxEnt/MaxentCalculatorTest.h
@@ -13,7 +13,7 @@ using namespace Mantid::Algorithms;
using namespace testing;
class MockEntropy : public MaxentEntropy {
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
public:
MOCK_METHOD2(derivative,
std::vector<double>(const std::vector<double> &, double));
@@ -29,7 +29,7 @@ public:
MOCK_METHOD1(imageToData, std::vector<double>(const std::vector<double> &));
MOCK_METHOD1(dataToImage, std::vector<double>(const std::vector<double> &));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
using MockEntropy_sptr = std::shared_ptr<MockEntropy>;
class MaxentCalculatorTest : public CxxTest::TestSuite {
diff --git a/Framework/Algorithms/test/MonteCarloTesting.h b/Framework/Algorithms/test/MonteCarloTesting.h
index 004e39f3b2c..5fa56bf294e 100644
--- a/Framework/Algorithms/test/MonteCarloTesting.h
+++ b/Framework/Algorithms/test/MonteCarloTesting.h
@@ -25,7 +25,7 @@ namespace MonteCarloTesting {
// -----------------------------------------------------------------------------
class MockRNG final : public Mantid::Kernel::PseudoRandomNumberGenerator {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD0(nextValue, double());
MOCK_METHOD2(nextValue, double(double, double));
MOCK_METHOD2(nextInt, int(int, int));
@@ -36,7 +36,7 @@ public:
MOCK_METHOD2(setRange, void(const double, const double));
MOCK_CONST_METHOD0(min, double());
MOCK_CONST_METHOD0(max, double());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
// -----------------------------------------------------------------------------
diff --git a/Framework/Algorithms/test/RebinByTimeBaseTest.h b/Framework/Algorithms/test/RebinByTimeBaseTest.h
index 1f3f4ab0f1f..f78858b0ca8 100644
--- a/Framework/Algorithms/test/RebinByTimeBaseTest.h
+++ b/Framework/Algorithms/test/RebinByTimeBaseTest.h
@@ -72,7 +72,7 @@ createEventWorkspace(const int numberspectra, const int nDistrubutedEvents,
return retVal;
}
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
/*
This type is an IEventWorkspace, but not an EventWorkspace.
@@ -115,7 +115,7 @@ private:
};
}
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
//=====================================================================================
// Functional Tests
diff --git a/Framework/Crystal/test/FindSXPeaksHelperTest.h b/Framework/Crystal/test/FindSXPeaksHelperTest.h
index 2838b2a231f..41d5291204f 100644
--- a/Framework/Crystal/test/FindSXPeaksHelperTest.h
+++ b/Framework/Crystal/test/FindSXPeaksHelperTest.h
@@ -16,14 +16,14 @@ using namespace testing;
namespace {
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockProgressBase : public Mantid::Kernel::ProgressBase {
public:
MOCK_METHOD1(doReport, void(const std::string &));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
}
class FindSXPeaksHelperTest : public CxxTest::TestSuite {
diff --git a/Framework/Crystal/test/MockObjects.h b/Framework/Crystal/test/MockObjects.h
index 2ab37abf457..d47b97a1b69 100644
--- a/Framework/Crystal/test/MockObjects.h
+++ b/Framework/Crystal/test/MockObjects.h
@@ -17,7 +17,7 @@
namespace Mantid {
namespace Crystal {
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
// Mock Background strategy
class MockBackgroundStrategy : public BackgroundStrategy {
@@ -49,7 +49,7 @@ public:
}
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
}
}
diff --git a/Framework/Crystal/test/PeakBackgroundTest.h b/Framework/Crystal/test/PeakBackgroundTest.h
index 4605bc16067..2f74c525522 100644
--- a/Framework/Crystal/test/PeakBackgroundTest.h
+++ b/Framework/Crystal/test/PeakBackgroundTest.h
@@ -33,7 +33,7 @@ IPeaksWorkspace_sptr make_peaks_workspace(const V3D &hklPeak) {
return peakWS;
}
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
// Mock Background strategy
class MockIMDIterator : public IMDIterator {
@@ -68,7 +68,7 @@ public:
MOCK_CONST_METHOD1(isWithinBounds, bool(size_t));
};
}
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
class PeakBackgroundTest : public CxxTest::TestSuite {
public:
diff --git a/Framework/CurveFitting/src/Functions/CrystalElectricField.cpp b/Framework/CurveFitting/src/Functions/CrystalElectricField.cpp
index 783d4f2f5d1..d0dddaa4bae 100644
--- a/Framework/CurveFitting/src/Functions/CrystalElectricField.cpp
+++ b/Framework/CurveFitting/src/Functions/CrystalElectricField.cpp
@@ -2,6 +2,7 @@
// Includes
//----------------------------------------------------------------------
#include "MantidCurveFitting/Functions/CrystalElectricField.h"
+#include "MantidKernel/WarningSuppressions.h"
#include <algorithm>
#include <array>
@@ -14,12 +15,11 @@ namespace Functions {
namespace {
-#ifdef __clang__
// The missing braces warning is a false positive -
// https://llvm.org/bugs/show_bug.cgi?id=21629
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wmissing-braces"
-#endif
+// clang-format off
+DIAG_OFF(missing-braces)
+// clang-format on
// Get a complex conjugate of the value returned by
// ComplexMatrix::operator(i,j)
@@ -636,9 +636,9 @@ void diagonalise(const ComplexFortranMatrix &hamiltonian,
eigenvalues += -eshift;
}
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_OFF(missing-braces)
+// clang-format on
} // anonymous namespace
diff --git a/Framework/DataObjects/inc/MantidDataObjects/MDGridBox.tcc b/Framework/DataObjects/inc/MantidDataObjects/MDGridBox.tcc
index d5ab8608c21..9e77d006f89 100644
--- a/Framework/DataObjects/inc/MantidDataObjects/MDGridBox.tcc
+++ b/Framework/DataObjects/inc/MantidDataObjects/MDGridBox.tcc
@@ -1287,7 +1287,7 @@ TMDE(void MDGridBox)::centroidSphere(API::CoordTransform &radiusTransform,
}
//-----------------------------------------------------------------------------------------------
// clang-format off
-GCC_DIAG_OFF(array-bounds)
+DIAG_OFF(array-bounds)
// clang-format on
/** Integrate the signal within a sphere; for example, to perform single-crystal
* peak integration.
@@ -1493,7 +1493,7 @@ TMDE(void MDGridBox)::integrateCylinder(
delete[] boxMightTouch;
}
// clang-format off
-GCC_DIAG_ON(array-bounds)
+DIAG_ON(array-bounds)
// clang-format on
/**
diff --git a/Framework/DataObjects/src/MDHistoWorkspace.cpp b/Framework/DataObjects/src/MDHistoWorkspace.cpp
index d93a75a3553..e760c6f1c1f 100644
--- a/Framework/DataObjects/src/MDHistoWorkspace.cpp
+++ b/Framework/DataObjects/src/MDHistoWorkspace.cpp
@@ -1347,7 +1347,7 @@ uint64_t MDHistoWorkspace::sumNContribEvents() const {
* Get the Q frame system (if any) to use.
*/
// clang-format off
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(strict-aliasing)
// clang-format on
Kernel::SpecialCoordinateSystem
MDHistoWorkspace::getSpecialCoordinateSystem() const {
diff --git a/Framework/DataObjects/test/MDBoxIteratorTest.h b/Framework/DataObjects/test/MDBoxIteratorTest.h
index 93fc5a6f589..0a0bb76b287 100644
--- a/Framework/DataObjects/test/MDBoxIteratorTest.h
+++ b/Framework/DataObjects/test/MDBoxIteratorTest.h
@@ -492,9 +492,9 @@ public:
pBC(MDBox<MDLeanEvent<2>, 2>::getBoxController())
{}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(getIsMasked, bool());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
~MockMDBox() override { delete pBC; }
};
@@ -570,10 +570,10 @@ public:
/// Mock Skipping Policy Type to inject.
class MockSkippingPolicy : public SkippingPolicy {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(keepGoing, bool());
MOCK_METHOD0(Die, void());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
~MockSkippingPolicy() override { Die(); }
};
diff --git a/Framework/DataObjects/test/MDGridBoxTest.h b/Framework/DataObjects/test/MDGridBoxTest.h
index 5f35b0ddba6..341b1c301cc 100644
--- a/Framework/DataObjects/test/MDGridBoxTest.h
+++ b/Framework/DataObjects/test/MDGridBoxTest.h
@@ -47,12 +47,12 @@ private:
MockMDBox()
: MDBox<MDLeanEvent<1>, 1>(new API::BoxController(1)),
pBC(MDBox<MDLeanEvent<1>, 1>::getBoxController()) {}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(getIsMasked, bool());
MOCK_METHOD0(mask, void());
MOCK_METHOD0(unmask, void());
~MockMDBox() override { delete pBC; }
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
// the sp to a box controller used as general reference to all tested
diff --git a/Framework/DataObjects/test/MockObjects.h b/Framework/DataObjects/test/MockObjects.h
index 9e271ecd35f..d1f7b2ec458 100644
--- a/Framework/DataObjects/test/MockObjects.h
+++ b/Framework/DataObjects/test/MockObjects.h
@@ -10,7 +10,7 @@
namespace Mantid {
namespace DataObjects {
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockPeakShapeFactory : public PeakShapeFactory {
public:
@@ -37,6 +37,6 @@ public:
}
}
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif /* MOCKOBJECTS_H_ */
diff --git a/Framework/Geometry/src/Objects/RuleItems.cpp b/Framework/Geometry/src/Objects/RuleItems.cpp
index f23833f8389..fd64337e510 100644
--- a/Framework/Geometry/src/Objects/RuleItems.cpp
+++ b/Framework/Geometry/src/Objects/RuleItems.cpp
@@ -34,17 +34,17 @@
#endif
#include "MantidKernel/WarningSuppressions.h"
-GCC_DIAG_OFF(conversion)
// clang-format off
-GCC_DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(cast-qual)
// clang-format on
#include <TopoDS_Shape.hxx>
#include <BRepAlgoAPI_Common.hxx>
#include <BRepAlgoAPI_Fuse.hxx>
#include <BRepPrimAPI_MakeBox.hxx>
-GCC_DIAG_ON(conversion)
// clang-format off
-GCC_DIAG_ON(cast-qual)
+DIAG_ON(conversion)
+DIAG_ON(cast-qual)
// clang-format on
#endif
diff --git a/Framework/Geometry/src/Rendering/GeometryTriangulator.cpp b/Framework/Geometry/src/Rendering/GeometryTriangulator.cpp
index ec15829f2b8..7ba3e7d1e45 100644
--- a/Framework/Geometry/src/Rendering/GeometryTriangulator.cpp
+++ b/Framework/Geometry/src/Rendering/GeometryTriangulator.cpp
@@ -23,9 +23,9 @@
#endif
#endif
-GCC_DIAG_OFF(conversion)
// clang-format off
-GCC_DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(cast-qual)
// clang-format on
#include <gp_Trsf.hxx>
#include <gp_Pnt.hxx>
@@ -39,9 +39,9 @@ GCC_DIAG_OFF(cast-qual)
#include <BRepBuilderAPI_Transform.hxx>
#include <BRep_Tool.hxx>
#include <Poly_Triangulation.hxx>
-GCC_DIAG_ON(conversion)
// clang-format off
-GCC_DIAG_ON(cast-qual)
+DIAG_ON(conversion)
+DIAG_ON(cast-qual)
// clang-format on
#ifdef __INTEL_COMPILER
diff --git a/Framework/Geometry/src/Rendering/RenderingHelpers.cpp b/Framework/Geometry/src/Rendering/RenderingHelpers.cpp
index af230c87276..76e17374af5 100644
--- a/Framework/Geometry/src/Rendering/RenderingHelpers.cpp
+++ b/Framework/Geometry/src/Rendering/RenderingHelpers.cpp
@@ -28,9 +28,9 @@
#endif
#endif
-GCC_DIAG_OFF(conversion)
// clang-format off
-GCC_DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(cast-qual)
// clang-format on
#include <gp_Pnt.hxx>
#include <TopoDS.hxx>
@@ -41,9 +41,9 @@ GCC_DIAG_OFF(cast-qual)
#include <Poly_Array1OfTriangle.hxx>
#include <TColgp_Array1OfPnt.hxx>
#include <Poly_Triangulation.hxx>
-GCC_DIAG_ON(conversion)
// clang-format off
-GCC_DIAG_ON(cast-qual)
+DIAG_ON(conversion)
+DIAG_ON(cast-qual)
// clang-format on
#ifdef __INTEL_COMPILER
diff --git a/Framework/Geometry/src/Surfaces/Cone.cpp b/Framework/Geometry/src/Surfaces/Cone.cpp
index 6414902e4bf..111420ccd02 100644
--- a/Framework/Geometry/src/Surfaces/Cone.cpp
+++ b/Framework/Geometry/src/Surfaces/Cone.cpp
@@ -30,14 +30,14 @@
#endif
#include "MantidKernel/WarningSuppressions.h"
-GCC_DIAG_OFF(conversion)
// clang-format off
-GCC_DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(cast-qual)
// clang-format on
#include <BRepPrimAPI_MakeCone.hxx>
-GCC_DIAG_ON(conversion)
// clang-format off
-GCC_DIAG_ON(cast-qual)
+DIAG_ON(conversion)
+DIAG_ON(cast-qual)
// clang-format on
#endif
diff --git a/Framework/Geometry/src/Surfaces/Cylinder.cpp b/Framework/Geometry/src/Surfaces/Cylinder.cpp
index ee1d6fba81e..d4af5cac27a 100644
--- a/Framework/Geometry/src/Surfaces/Cylinder.cpp
+++ b/Framework/Geometry/src/Surfaces/Cylinder.cpp
@@ -16,14 +16,14 @@
#endif
#include "MantidKernel/WarningSuppressions.h"
-GCC_DIAG_OFF(conversion)
// clang-format off
-GCC_DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(cast-qual)
// clang-format on
#include <BRepPrimAPI_MakeCylinder.hxx>
-GCC_DIAG_ON(conversion)
// clang-format off
-GCC_DIAG_ON(cast-qual)
+DIAG_ON(conversion)
+DIAG_ON(cast-qual)
// clang-format on
#endif
diff --git a/Framework/Geometry/src/Surfaces/Plane.cpp b/Framework/Geometry/src/Surfaces/Plane.cpp
index 5bf951c2b1b..1a84602898a 100644
--- a/Framework/Geometry/src/Surfaces/Plane.cpp
+++ b/Framework/Geometry/src/Surfaces/Plane.cpp
@@ -17,18 +17,18 @@
#endif
#include "MantidKernel/WarningSuppressions.h"
-GCC_DIAG_OFF(conversion)
// clang-format off
-GCC_DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(cast-qual)
// clang-format on
#include <BRepPrimAPI_MakeBox.hxx>
#include <BRepBuilderAPI_MakeFace.hxx>
#include <BRepPrimAPI_MakeHalfSpace.hxx>
#include <BRepAlgoAPI_Common.hxx>
#include <gp_Pln.hxx>
-GCC_DIAG_ON(conversion)
// clang-format off
-GCC_DIAG_ON(cast-qual)
+DIAG_ON(conversion)
+DIAG_ON(cast-qual)
// clang-format on
#endif
diff --git a/Framework/Geometry/src/Surfaces/Sphere.cpp b/Framework/Geometry/src/Surfaces/Sphere.cpp
index 750d20ae14a..315f3a6881c 100644
--- a/Framework/Geometry/src/Surfaces/Sphere.cpp
+++ b/Framework/Geometry/src/Surfaces/Sphere.cpp
@@ -14,14 +14,14 @@
#endif
#include "MantidKernel/WarningSuppressions.h"
-GCC_DIAG_OFF(conversion)
// clang-format off
-GCC_DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(cast-qual)
// clang-format on
#include <BRepPrimAPI_MakeSphere.hxx>
-GCC_DIAG_ON(conversion)
// clang-format off
-GCC_DIAG_ON(cast-qual)
+DIAG_ON(conversion)
+DIAG_ON(cast-qual)
// clang-format on
#endif
diff --git a/Framework/Geometry/src/Surfaces/Surface.cpp b/Framework/Geometry/src/Surfaces/Surface.cpp
index b5610a3ffd8..a2b436e85e9 100644
--- a/Framework/Geometry/src/Surfaces/Surface.cpp
+++ b/Framework/Geometry/src/Surfaces/Surface.cpp
@@ -29,14 +29,14 @@
#endif
#include "MantidKernel/WarningSuppressions.h"
-GCC_DIAG_OFF(conversion)
// clang-format off
-GCC_DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(cast-qual)
// clang-format on
#include <TopoDS_Shape.hxx>
-GCC_DIAG_ON(conversion)
// clang-format off
-GCC_DIAG_ON(cast-qual)
+DIAG_ON(conversion)
+DIAG_ON(cast-qual)
// clang-format on
#endif
diff --git a/Framework/Geometry/src/Surfaces/Torus.cpp b/Framework/Geometry/src/Surfaces/Torus.cpp
index f537c08e25b..44025b8c323 100644
--- a/Framework/Geometry/src/Surfaces/Torus.cpp
+++ b/Framework/Geometry/src/Surfaces/Torus.cpp
@@ -29,14 +29,14 @@
#endif
#include "MantidKernel/WarningSuppressions.h"
-GCC_DIAG_OFF(conversion)
// clang-format off
-GCC_DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(cast-qual)
// clang-format on
#include <TopoDS_Shape.hxx>
-GCC_DIAG_ON(conversion)
// clang-format off
-GCC_DIAG_ON(cast-qual)
+DIAG_ON(conversion)
+DIAG_ON(cast-qual)
// clang-format on
#endif
diff --git a/Framework/Geometry/test/BasicHKLFiltersTest.h b/Framework/Geometry/test/BasicHKLFiltersTest.h
index ead68b6fa11..3b5a550e70a 100644
--- a/Framework/Geometry/test/BasicHKLFiltersTest.h
+++ b/Framework/Geometry/test/BasicHKLFiltersTest.h
@@ -136,7 +136,7 @@ public:
TS_ASSERT(Mock::VerifyAndClearExpectations(mock.get()))
}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
private:
class MockStructureFactorCalculator : public StructureFactorCalculator {
public:
@@ -144,5 +144,5 @@ private:
MOCK_CONST_METHOD1(getFSquared, double(const V3D &));
};
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif /* MANTID_GEOMETRY_BASICHKLFILTERSTEST_H_ */
diff --git a/Framework/Geometry/test/BraggScattererFactoryTest.h b/Framework/Geometry/test/BraggScattererFactoryTest.h
index 34737190bef..2586d2f8fd8 100644
--- a/Framework/Geometry/test/BraggScattererFactoryTest.h
+++ b/Framework/Geometry/test/BraggScattererFactoryTest.h
@@ -56,10 +56,10 @@ private:
~MockScatterer() override {}
std::string name() const override { return "MockScatterer"; }
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(clone, BraggScatterer_sptr());
MOCK_CONST_METHOD1(calculateStructureFactor, StructureFactor(const V3D &));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
};
diff --git a/Framework/Geometry/test/BraggScattererInCrystalStructureTest.h b/Framework/Geometry/test/BraggScattererInCrystalStructureTest.h
index e39b4093bc9..28147bf85b7 100644
--- a/Framework/Geometry/test/BraggScattererInCrystalStructureTest.h
+++ b/Framework/Geometry/test/BraggScattererInCrystalStructureTest.h
@@ -112,12 +112,12 @@ private:
public:
MockBraggScatterer() : BraggScattererInCrystalStructure() {}
~MockBraggScatterer() override {}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(name, std::string());
MOCK_CONST_METHOD0(clone, BraggScatterer_sptr());
MOCK_CONST_METHOD1(calculateStructureFactor, StructureFactor(const V3D &));
MOCK_METHOD1(afterScattererPropertySet, void(const std::string &));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
};
diff --git a/Framework/Geometry/test/BraggScattererTest.h b/Framework/Geometry/test/BraggScattererTest.h
index b3e80316e10..f2b52ce9177 100644
--- a/Framework/Geometry/test/BraggScattererTest.h
+++ b/Framework/Geometry/test/BraggScattererTest.h
@@ -43,12 +43,12 @@ private:
class MockBraggScatterer : public BraggScatterer {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(name, std::string());
MOCK_CONST_METHOD0(clone, BraggScatterer_sptr());
MOCK_CONST_METHOD1(calculateStructureFactor, StructureFactor(const V3D &));
MOCK_METHOD1(afterScattererPropertySet, void(const std::string &));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
};
diff --git a/Framework/Geometry/test/CSGObjectTest.h b/Framework/Geometry/test/CSGObjectTest.h
index 0c9f7bb10e4..0f7db17dcdd 100644
--- a/Framework/Geometry/test/CSGObjectTest.h
+++ b/Framework/Geometry/test/CSGObjectTest.h
@@ -45,7 +45,7 @@ namespace {
// -----------------------------------------------------------------------------
class MockRNG final : public Mantid::Kernel::PseudoRandomNumberGenerator {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD0(nextValue, double());
MOCK_METHOD2(nextValue, double(double, double));
MOCK_METHOD2(nextInt, int(int, int));
@@ -56,7 +56,7 @@ public:
MOCK_METHOD2(setRange, void(const double, const double));
MOCK_CONST_METHOD0(min, double());
MOCK_CONST_METHOD0(max, double());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
}
diff --git a/Framework/Geometry/test/CompositeImplicitFunctionTest.h b/Framework/Geometry/test/CompositeImplicitFunctionTest.h
index f6861a2047f..5ddd3d87ef3 100644
--- a/Framework/Geometry/test/CompositeImplicitFunctionTest.h
+++ b/Framework/Geometry/test/CompositeImplicitFunctionTest.h
@@ -18,11 +18,11 @@ private:
// composite.
class MockImplicitFunction : public Mantid::Geometry::MDImplicitFunction {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(toXMLString, std::string());
MOCK_CONST_METHOD0(getName, std::string());
MOCK_METHOD1(isPointContained, bool(const Mantid::coord_t *coords));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
bool isPointContained(const std::vector<Mantid::coord_t> &) override {
return true;
}
diff --git a/Framework/Geometry/test/GroupTest.h b/Framework/Geometry/test/GroupTest.h
index b67088ec47c..c2a16693b78 100644
--- a/Framework/Geometry/test/GroupTest.h
+++ b/Framework/Geometry/test/GroupTest.h
@@ -3,10 +3,11 @@
#include <cxxtest/TestSuite.h>
-#include "MantidKernel/V3D.h"
#include "MantidGeometry/Crystal/Group.h"
#include "MantidGeometry/Crystal/SymmetryOperationFactory.h"
#include "MantidGeometry/Crystal/UnitCell.h"
+#include "MantidKernel/V3D.h"
+#include "MantidKernel/WarningSuppressions.h"
#include <boost/make_shared.hpp>
using namespace Mantid::Geometry;
@@ -367,16 +368,15 @@ public:
Group_const_sptr null;
TS_ASSERT_THROWS(null * null, std::invalid_argument);
-// AppleClang gives a warning if we don't use the result
-#if __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-comparison"
-#endif
+ // clang gives a warning if we don't use the result
+ // clang-format off
+ DIAG_OFF(unused-comparison)
+ // clang-format on
TS_ASSERT_THROWS(null == null, std::invalid_argument);
TS_ASSERT_THROWS(null != null, std::invalid_argument);
-#if __clang__
-#pragma clang diagnostic pop
-#endif
+ // clang-format off
+ DIAG_ON(unused-comparison)
+ // clang-format on
TS_ASSERT_THROWS(three * null, std::invalid_argument);
TS_ASSERT_THROWS(null * three, std::invalid_argument);
diff --git a/Framework/Geometry/test/HKLFilterTest.h b/Framework/Geometry/test/HKLFilterTest.h
index 08f8bbd89a7..d73a4cabe78 100644
--- a/Framework/Geometry/test/HKLFilterTest.h
+++ b/Framework/Geometry/test/HKLFilterTest.h
@@ -184,7 +184,7 @@ public:
TS_ASSERT_EQUALS(orFilterCasted->getLHS(), lhs);
TS_ASSERT_EQUALS(orFilterCasted->getRHS(), rhs);
}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
private:
class MockHKLFilter : public HKLFilter {
public:
@@ -212,5 +212,5 @@ private:
MOCK_CONST_METHOD1(isAllowed, bool(const V3D &));
};
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif /* MANTID_GEOMETRY_HKLFILTERTEST_H_ */
diff --git a/Framework/Geometry/test/InstrumentDefinitionParserTest.h b/Framework/Geometry/test/InstrumentDefinitionParserTest.h
index ea47421b1f6..f5ccd58a921 100644
--- a/Framework/Geometry/test/InstrumentDefinitionParserTest.h
+++ b/Framework/Geometry/test/InstrumentDefinitionParserTest.h
@@ -22,7 +22,7 @@ using namespace testing;
using ScopedFileHelper::ScopedFile;
class InstrumentDefinitionParserTest : public CxxTest::TestSuite {
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
private:
/// Mock Type to act as IDF files.
class MockIDFObject : public Mantid::Geometry::IDFObject {
@@ -40,7 +40,7 @@ private:
MOCK_CONST_METHOD0(exists, bool());
MOCK_CONST_METHOD0(getParentDirectory, const Poco::Path());
};
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
/**
Helper type to pass around related IDF environment information in a
collection.
diff --git a/Framework/Geometry/test/MDGeometryXMLBuilderTest.h b/Framework/Geometry/test/MDGeometryXMLBuilderTest.h
index 0e8c66ac877..86d9b8c26eb 100644
--- a/Framework/Geometry/test/MDGeometryXMLBuilderTest.h
+++ b/Framework/Geometry/test/MDGeometryXMLBuilderTest.h
@@ -34,7 +34,7 @@ private:
/// dependency.
class MockIMDDimension : public Mantid::Geometry::IMDDimension {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(getName, std::string());
MOCK_CONST_METHOD0(getUnits, const Mantid::Kernel::UnitLabel());
MOCK_CONST_METHOD0(getDimensionId, const std::string &());
@@ -48,7 +48,7 @@ private:
MOCK_METHOD3(setRange, void(size_t nBins, coord_t min, coord_t max));
MOCK_CONST_METHOD0(getMDUnits, const Kernel::MDUnit &());
MOCK_CONST_METHOD0(getMDFrame, const Geometry::MDFrame &());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
static std::string createDimensionXMLString(unsigned int nbins, int min,
diff --git a/Framework/Geometry/test/MeshObjectTest.h b/Framework/Geometry/test/MeshObjectTest.h
index 15ba9a18e27..2115f7de14b 100644
--- a/Framework/Geometry/test/MeshObjectTest.h
+++ b/Framework/Geometry/test/MeshObjectTest.h
@@ -37,7 +37,7 @@ namespace {
// -----------------------------------------------------------------------------
class MockRNG final : public Mantid::Kernel::PseudoRandomNumberGenerator {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD0(nextValue, double());
MOCK_METHOD2(nextValue, double(double, double));
MOCK_METHOD2(nextInt, int(int, int));
@@ -48,7 +48,7 @@ public:
MOCK_METHOD2(setRange, void(const double, const double));
MOCK_CONST_METHOD0(min, double());
MOCK_CONST_METHOD0(max, double());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
std::unique_ptr<MeshObject> createCube(const double size, const V3D ¢re) {
diff --git a/Framework/Geometry/test/MockObjects.h b/Framework/Geometry/test/MockObjects.h
index 168b8db8a00..5635147723c 100644
--- a/Framework/Geometry/test/MockObjects.h
+++ b/Framework/Geometry/test/MockObjects.h
@@ -23,7 +23,7 @@ using boost::regex;
namespace {
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
/*------------------------------------------------------------
Mock Peak Transform
@@ -121,5 +121,5 @@ public:
MOCK_CONST_METHOD0(getPeakShape, const Mantid::Geometry::PeakShape &());
};
}
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif /* MANTIDGEOMETRYTEST_MOCKOBJECTS_H_ */
diff --git a/Framework/Geometry/test/PeakTransformSelectorTest.h b/Framework/Geometry/test/PeakTransformSelectorTest.h
index ac3c438324c..cef3d4ee338 100644
--- a/Framework/Geometry/test/PeakTransformSelectorTest.h
+++ b/Framework/Geometry/test/PeakTransformSelectorTest.h
@@ -23,12 +23,12 @@ private:
enum { value = I };
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(createDefaultTransform, PeakTransform_sptr());
MOCK_CONST_METHOD2(createTransform,
PeakTransform_sptr(const std::string &,
const std::string &));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
using MockPeakTransformFactory = MockPeakTransformFactoryType<0>;
diff --git a/Framework/Geometry/test/SampleEnvironmentTest.h b/Framework/Geometry/test/SampleEnvironmentTest.h
index 2890c717f08..aa4f0922f1f 100644
--- a/Framework/Geometry/test/SampleEnvironmentTest.h
+++ b/Framework/Geometry/test/SampleEnvironmentTest.h
@@ -21,7 +21,7 @@ namespace {
// -----------------------------------------------------------------------------
class MockRNG final : public Mantid::Kernel::PseudoRandomNumberGenerator {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD0(nextValue, double());
MOCK_METHOD2(nextValue, double(double, double));
MOCK_METHOD2(nextInt, int(int, int));
@@ -32,7 +32,7 @@ public:
MOCK_METHOD2(setRange, void(const double, const double));
MOCK_CONST_METHOD0(min, double());
MOCK_CONST_METHOD0(max, double());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
}
diff --git a/Framework/Geometry/test/SpaceGroupFactoryTest.h b/Framework/Geometry/test/SpaceGroupFactoryTest.h
index 47bf1c43250..a4e5974ddea 100644
--- a/Framework/Geometry/test/SpaceGroupFactoryTest.h
+++ b/Framework/Geometry/test/SpaceGroupFactoryTest.h
@@ -398,9 +398,9 @@ private:
MockSpaceGroupGenerator(size_t number, const std::string &hmSymbol,
const std::string &generatorInformation)
: AbstractSpaceGroupGenerator(number, hmSymbol, generatorInformation) {}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(generateGroup, Group_const_sptr());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
/* Testing TransformationSpaceGroupGenerator is a bit hard in the sense that
diff --git a/Framework/Geometry/test/StructureFactorCalculatorTest.h b/Framework/Geometry/test/StructureFactorCalculatorTest.h
index 07f26d2044b..225a1a9eb3d 100644
--- a/Framework/Geometry/test/StructureFactorCalculatorTest.h
+++ b/Framework/Geometry/test/StructureFactorCalculatorTest.h
@@ -99,11 +99,11 @@ private:
*/
class MockStructureFactorCalculator : public StructureFactorCalculator {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD1(getF, StructureFactor(const V3D &hkl));
MOCK_METHOD1(crystalStructureSetHook,
void(const CrystalStructure &crystalStructure));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
};
diff --git a/Framework/Geometry/test/SymmetryElementFactoryTest.h b/Framework/Geometry/test/SymmetryElementFactoryTest.h
index 521bdb6e3aa..d7e9c4d2f91 100644
--- a/Framework/Geometry/test/SymmetryElementFactoryTest.h
+++ b/Framework/Geometry/test/SymmetryElementFactoryTest.h
@@ -396,12 +396,12 @@ private:
class TestableSymmetryElementWithAxisGenerator
: public SymmetryElementWithAxisGenerator {
friend class SymmetryElementFactoryTest;
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD1(generateElement,
SymmetryElement_sptr(const SymmetryOperation &));
MOCK_CONST_METHOD1(canProcess, bool(const SymmetryOperation &));
MOCK_CONST_METHOD1(determineSymbol, std::string(const SymmetryOperation &));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
class TestableSymmetryElementRotationGenerator
diff --git a/Framework/Geometry/test/SymmetryElementTest.h b/Framework/Geometry/test/SymmetryElementTest.h
index a6dab9ede8d..7f3097507ee 100644
--- a/Framework/Geometry/test/SymmetryElementTest.h
+++ b/Framework/Geometry/test/SymmetryElementTest.h
@@ -159,7 +159,7 @@ public:
private:
class MockSymmetryElement : public SymmetryElement {
friend class SymmetryElementTest;
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
public:
MockSymmetryElement(const std::string &hmSymbol)
: SymmetryElement(hmSymbol) {}
@@ -175,7 +175,7 @@ private:
: SymmetryElementWithAxis(symbol, axis, translation) {}
MOCK_CONST_METHOD0(clone, SymmetryElement_sptr());
};
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
#endif /* MANTID_GEOMETRY_SYMMETRYELEMENTTEST_H_ */
diff --git a/Framework/ICat/src/CatalogSearch.cpp b/Framework/ICat/src/CatalogSearch.cpp
index be251804f99..ce895254051 100644
--- a/Framework/ICat/src/CatalogSearch.cpp
+++ b/Framework/ICat/src/CatalogSearch.cpp
@@ -1,12 +1,12 @@
#if GCC_VERSION >= 40800 // 4.8.0
// clang-format off
-GCC_DIAG_OFF(literal-suffix)
+DIAG_OFF(literal-suffix)
// clang-format on
#endif
#include "MantidICat/CatalogSearch.h"
#if GCC_VERSION >= 40800 // 4.8.0
// clang-format off
-GCC_DIAG_ON(literal-suffix)
+DIAG_ON(literal-suffix)
// clang-format on
#endif
diff --git a/Framework/ICat/src/GSoap.cpp b/Framework/ICat/src/GSoap.cpp
index d0c2ea6339a..f4c23869b1e 100644
--- a/Framework/ICat/src/GSoap.cpp
+++ b/Framework/ICat/src/GSoap.cpp
@@ -5,16 +5,16 @@
// it is automatically generated code
//------------------------------------------------------------------------------
// clang-format off
-GCC_DIAG_OFF(cast-qual)
-GCC_DIAG_OFF(conversion)
-GCC_DIAG_OFF(unused-parameter)
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(unused-parameter)
+DIAG_OFF(strict-aliasing)
+DIAG_OFF(format)
+DIAG_OFF(vla)
// clang-format on
-GCC_DIAG_OFF(format)
-GCC_DIAG_OFF(vla)
#if GCC_VERSION >= 40800 // 4.8.0
// clang-format off
-GCC_DIAG_OFF(literal-suffix)
+DIAG_OFF(literal-suffix)
// clang-format on
#endif
#ifdef _WIN32
diff --git a/Framework/ICat/src/GSoap/stdsoap2.cpp b/Framework/ICat/src/GSoap/stdsoap2.cpp
index fc03059c463..3fef47ec183 100644
--- a/Framework/ICat/src/GSoap/stdsoap2.cpp
+++ b/Framework/ICat/src/GSoap/stdsoap2.cpp
@@ -1,19 +1,14 @@
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wcast-align"
-#endif
#include "MantidKernel/WarningSuppressions.h"
// ignore warnings in gSOAP
// Long-term solution is to use gSOAP as an external library or external
// project. see issue #19433
// clang-format off
-#if defined(__GNUC__) && __GNUC__ >= 7
-GCC_DIAG_OFF(deprecated-declarations)
-GCC_DIAG_OFF(format-overflow)
-GCC_DIAG_OFF(format-truncation)
-GCC_DIAG_OFF(implicit-fallthrough)
-#endif
+DIAG_OFF(deprecated-declarations)
+DIAG_OFF(format-overflow)
+DIAG_OFF(format-truncation)
+DIAG_OFF(implicit-fallthrough)
+DIAG_OFF(cast-align)
// clang-format on
/*
@@ -17022,14 +17017,9 @@ soap::~soap() {
/******************************************************************************/
// clang-format off
-#if defined(__GNUC__) && __GNUC__ >= 7
-GCC_DIAG_ON(deprecated-declarations)
-GCC_DIAG_ON(format-overflow)
-GCC_DIAG_ON(format-truncation)
-GCC_DIAG_ON(implicit-fallthrough)
-#endif
+DIAG_ON(deprecated-declarations)
+DIAG_ON(format-overflow)
+DIAG_ON(format-truncation)
+DIAG_ON(implicit-fallthrough)
+DIAG_ON(cast-align)
// clang-format on
-
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
diff --git a/Framework/ICat/src/ICat3/ICat3GSoapGenerated.cpp b/Framework/ICat/src/ICat3/ICat3GSoapGenerated.cpp
index d1b54aeaaf7..0835075b17c 100644
--- a/Framework/ICat/src/ICat3/ICat3GSoapGenerated.cpp
+++ b/Framework/ICat/src/ICat3/ICat3GSoapGenerated.cpp
@@ -5,16 +5,16 @@
// it is automatically generated code
//------------------------------------------------------------------------------
// clang-format off
-GCC_DIAG_OFF(cast-qual)
-GCC_DIAG_OFF(conversion)
-GCC_DIAG_OFF(unused-parameter)
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(unused-parameter)
+DIAG_OFF(strict-aliasing)
+DIAG_OFF(format)
+DIAG_OFF(vla)
// clang-format on
-GCC_DIAG_OFF(format)
-GCC_DIAG_OFF(vla)
#if GCC_VERSION >= 40800 // 4.8.0
// clang-format off
-GCC_DIAG_OFF(literal-suffix)
+DIAG_OFF(literal-suffix)
// clang-format on
#endif
#ifdef _WIN32
diff --git a/Framework/ICat/src/ICat3/ICat3Helper.cpp b/Framework/ICat/src/ICat3/ICat3Helper.cpp
index f613f2b30be..1b9c9a846af 100644
--- a/Framework/ICat/src/ICat3/ICat3Helper.cpp
+++ b/Framework/ICat/src/ICat3/ICat3Helper.cpp
@@ -3,7 +3,7 @@
#include "MantidAPI/WorkspaceFactory.h"
#if GCC_VERSION >= 40800 // 4.8.0
// clang-format off
-GCC_DIAG_OFF(literal-suffix)
+DIAG_OFF(literal-suffix)
// clang-format on
#endif
#include "MantidICat/ICat3/ICat3Helper.h"
diff --git a/Framework/ICat/src/ICat4/ICat4GSoapGenerated.cpp b/Framework/ICat/src/ICat4/ICat4GSoapGenerated.cpp
index b58295fd0b3..dc5885d73fb 100644
--- a/Framework/ICat/src/ICat4/ICat4GSoapGenerated.cpp
+++ b/Framework/ICat/src/ICat4/ICat4GSoapGenerated.cpp
@@ -5,16 +5,16 @@
// it is automatically generated code
//------------------------------------------------------------------------------
// clang-format off
-GCC_DIAG_OFF(cast-qual)
-GCC_DIAG_OFF(conversion)
-GCC_DIAG_OFF(unused-parameter)
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(cast-qual)
+DIAG_OFF(conversion)
+DIAG_OFF(unused-parameter)
+DIAG_OFF(strict-aliasing)
+DIAG_OFF(format)
+DIAG_OFF(vla)
// clang-format on
-GCC_DIAG_OFF(format)
-GCC_DIAG_OFF(vla)
#if GCC_VERSION >= 40800 // 4.8.0
// clang-format off
-GCC_DIAG_OFF(literal-suffix)
+DIAG_OFF(literal-suffix)
// clang-format on
#endif
#ifdef _WIN32
diff --git a/Framework/Kernel/inc/MantidKernel/PropertyHelper.h b/Framework/Kernel/inc/MantidKernel/PropertyHelper.h
index 1fbe4423e46..ad0e64d7119 100644
--- a/Framework/Kernel/inc/MantidKernel/PropertyHelper.h
+++ b/Framework/Kernel/inc/MantidKernel/PropertyHelper.h
@@ -124,14 +124,8 @@ std::string toPrettyString(
}
return Strings::shorten(retVal, maxLength);
}
-
-// AppleClang gives warning if the result is unused.
-#if __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-function"
-#endif
// clang-format off
-GCC_DIAG_OFF(unused-function)
+DIAG_OFF(unused-function)
// clang-format on
/** Explicit specialization for a property of type std::vector<bool>.
* This will catch Vectors of char, double, float etc.
@@ -148,11 +142,8 @@ std::string toPrettyString(
maxLength);
}
// clang-format off
-GCC_DIAG_ON(unused-function)
+DIAG_ON(unused-function)
// clang-format on
-#if __clang__
-#pragma clang diagnostic pop
-#endif
/// Specialization for a property of type std::vector<std::vector>.
template <typename T>
diff --git a/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h b/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h
index a9195a1f037..3e6eaab2c1c 100644
--- a/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h
+++ b/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h
@@ -76,30 +76,34 @@
// define macros for turning the warning suppression on/off for GCC
// note that we turn off unknown warnings here as well so that we can use the
// same macro for GCC and clang.
+// clang-format off
#if GCC_VERSION >= 40600 // GCC 4.6.0
-#define DIAG_OFF(x) \
- DIAG_PRAGMA(push) \
- DIAG_PRAGMA(ignored DIAG_JOINSTR(-W, unknown-warning)) \
+#define DIAG_OFF(x) \
+ DIAG_PRAGMA(push) \
+ DIAG_PRAGMA(ignored DIAG_JOINSTR(-W, unknown-warning)) \
DIAG_PRAGMA(ignored DIAG_JOINSTR(-W, x))
#define DIAG_ON(x) DIAG_PRAGMA(pop)
#else
-#define DIAG_OFF(x) \
- DIAG_PRAGMA(ignored DIAG_JOINSTR(-W, unknown-warning)) \
+#define DIAG_OFF(x) \
+ DIAG_PRAGMA(ignored DIAG_JOINSTR(-W, unknown-warning)) \
DIAG_PRAGMA(ignored DIAG_JOINSTR(-W, x))
-#define DIAG_ON(x) \
- DIAG_PRAGMA(warning DIAG_JOINSTR(-W, unknown-warning)) \
- DIAG_PRAGMA(warning DIAG_JOINSTR(-W, x))
+#define DIAG_ON(x) \
+ DIAG_PRAGMA(warning DIAG_JOINSTR(-W, unknown-warning)) \
+ DIAG_PRAGMA(warning DIAG_JOINSTR(-W, x))
#endif
+// clang-format on
#elif defined(CLANG_VERSION) && CLANG_VERSION >= 306
// define macros for turning the warning suppression on/off for clang
// note that we turn off unknown warnings here as well so that we can use the
// same macro for GCC and clang.
-#define DIAG_OFF(x) \
- DIAG_PRAGMA(push) \
- DIAG_PRAGMA(ignored DIAG_JOINSTR(-W, unknown-warning-option)) \
- DIAG_PRAGMA(ignored DIAG_JOINSTR(-W, x))
+// clang-format off
+#define DIAG_OFF(x) \
+ DIAG_PRAGMA(push) \
+ DIAG_PRAGMA(ignored DIAG_JOINSTR(-W, unknown-warning-option)) \
+ DIAG_PRAGMA(ignored DIAG_JOINSTR(-W, x))
#define DIAG_ON(x) DIAG_PRAGMA(pop)
+// clang-format on
#else
// neither clang or GCC
#define DIAG_OFF(x)
@@ -108,7 +112,6 @@
#endif
-
// Defining this macro separately since clang-tidy tries to add spaces around
// the hyphen and we use it in a lot of test files.
// clang-format off
@@ -124,10 +127,10 @@
#endif
// clang-format on
-#ifdef GCC_VERSION
-#define GCC_UNUSED_FUNCTION __attribute__((unused))
+#if defined(GCC_VERSION) || defined(CLANG_VERSION)
+#define UNUSED_FUNCTION __attribute__((unused))
#else
-#define GCC_UNUSED_FUNCTION
+#define UNUSED_FUNCTION
#endif
#endif /*MANTID_KERNEL_WARNINGSUPPRESSIONS_H_*/
diff --git a/Framework/Kernel/inc/MantidKernel/normal_distribution.h b/Framework/Kernel/inc/MantidKernel/normal_distribution.h
index 54941b602e3..c7c304b1fcd 100644
--- a/Framework/Kernel/inc/MantidKernel/normal_distribution.h
+++ b/Framework/Kernel/inc/MantidKernel/normal_distribution.h
@@ -171,9 +171,7 @@ public:
};
// clang-format off
-#if !defined(__clang__)
-GCC_DIAG_OFF(maybe-uninitialized)
-#endif
+DIAG_OFF(maybe-uninitialized)
// clang-format on
template <class _RealType>
template <class _URNG>
@@ -201,9 +199,7 @@ _RealType normal_distribution<_RealType>::operator()(_URNG &__g,
return _Up * __p.stddev() + __p.mean();
}
// clang-format off
-#if !defined(__clang__)
-GCC_DIAG_ON(maybe-uninitialized)
-#endif
+DIAG_ON(maybe-uninitialized)
// clang-format on
template <class _CharT, class _Traits, class _RT>
diff --git a/Framework/Kernel/test/MDUnitFactoryTest.h b/Framework/Kernel/test/MDUnitFactoryTest.h
index e3846529748..a6f16cd77f0 100644
--- a/Framework/Kernel/test/MDUnitFactoryTest.h
+++ b/Framework/Kernel/test/MDUnitFactoryTest.h
@@ -14,7 +14,7 @@ using namespace testing;
/**
* Helper Mock MDUnit
*/
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockMDUnit : public MDUnit {
public:
MOCK_CONST_METHOD0(getUnitLabel, UnitLabel());
@@ -31,7 +31,7 @@ public:
MOCK_CONST_METHOD1(createRaw, MDUnit *(const std::string &));
MOCK_CONST_METHOD1(canInterpret, bool(const std::string &));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
class MDUnitFactoryTest : public CxxTest::TestSuite {
public:
// This pair of boilerplate methods prevent the suite being created statically
diff --git a/Framework/Kernel/test/NDRandomNumberGeneratorTest.h b/Framework/Kernel/test/NDRandomNumberGeneratorTest.h
index 8954034ea46..521b4635c2a 100644
--- a/Framework/Kernel/test/NDRandomNumberGeneratorTest.h
+++ b/Framework/Kernel/test/NDRandomNumberGeneratorTest.h
@@ -17,12 +17,12 @@ private:
public:
Mock3DRandomNumberGenerator()
: Mantid::Kernel::NDRandomNumberGenerator(3) {}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD0(generateNextPoint, void());
MOCK_METHOD0(restart, void());
MOCK_METHOD0(save, void());
MOCK_METHOD0(restore, void());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
public:
diff --git a/Framework/Kernel/test/UserCatalogInfoTest.h b/Framework/Kernel/test/UserCatalogInfoTest.h
index 34d5d9680ae..64fcf75a3aa 100644
--- a/Framework/Kernel/test/UserCatalogInfoTest.h
+++ b/Framework/Kernel/test/UserCatalogInfoTest.h
@@ -19,7 +19,7 @@ operator<<(std::basic_ostream<CharType, CharTrait> &out,
return out;
}
}
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
using namespace Mantid::Kernel;
class MockCatalogConfigService : public CatalogConfigService {
public:
@@ -37,7 +37,7 @@ public:
MOCK_CONST_METHOD0(linuxPrefix, const std::string());
MOCK_CONST_METHOD0(clone, ICatalogInfo *());
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
// Adaptee
struct UserType {
std::string getString(const std::string &) const { return "my_value"; }
diff --git a/Framework/LiveData/inc/MantidLiveData/ISIS/TCPEventStreamDefs.h b/Framework/LiveData/inc/MantidLiveData/ISIS/TCPEventStreamDefs.h
index fec497f9fc0..97e7f424fff 100644
--- a/Framework/LiveData/inc/MantidLiveData/ISIS/TCPEventStreamDefs.h
+++ b/Framework/LiveData/inc/MantidLiveData/ISIS/TCPEventStreamDefs.h
@@ -1,15 +1,18 @@
#ifndef TCP_EVENT_STREAM_DEFS_H
#define TCP_EVENT_STREAM_DEFS_H
+#include "MantidKernel/WarningSuppressions.h"
+
#include <cstdint>
#include <cstring>
#include <ctime>
#include <vector>
// to ignore warnings when comparing header versions
-#if defined(__GNUC__) && !(defined(__INTEL_COMPILER))
-#pragma GCC diagnostic ignored "-Wtype-limits"
-#elif defined(_WIN32)
+// clang-format off
+DIAG_OFF(type-limits)
+// clang-format on
+#if defined(_WIN32)
#pragma warning(disable : 4296)
#endif
@@ -49,10 +52,10 @@ struct TCPStreamEventHeader {
TCPStreamEventHeader(uint32_t type_)
: marker1(marker), marker2(marker), version(current_version),
length(sizeof(TCPStreamEventHeader)), type(type_) {}
-#if __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wtautological-compare"
-#endif
+
+ // clang-format off
+ DIAG_OFF(autological-compare)
+ // clang-format on
bool isValid() const {
return marker1 == marker && marker2 == marker &&
length >= sizeof(TCPStreamEventHeader) &&
@@ -60,9 +63,10 @@ struct TCPStreamEventHeader {
minorVersion() >= TCPStreamEventHeader::minor_version &&
type != InvalidStream;
}
-#if __clang__
-#pragma clang diagnostic pop
-#endif
+ // clang-format off
+ DIAG_ON(autological-compare)
+ // clang-format on
+
static const uint32_t major_version =
1; ///< starts at 1, then incremented whenever layout of this or further
/// packets changes in a non backward compatible way
@@ -190,4 +194,8 @@ struct TCPStreamEventDataSE {
};
}
}
+
+// clang-format off
+DIAG_ON(type-limits)
+// clang-format on
#endif /* TCP_EVENT_STREAM_DEFS_H */
diff --git a/Framework/LiveData/src/ISIS/ISISHistoDataListener.cpp b/Framework/LiveData/src/ISIS/ISISHistoDataListener.cpp
index 198b01fa5a5..e6ead5a47d9 100644
--- a/Framework/LiveData/src/ISIS/ISISHistoDataListener.cpp
+++ b/Framework/LiveData/src/ISIS/ISISHistoDataListener.cpp
@@ -22,7 +22,7 @@
// Avoid compiler warnings on gcc from unused static constants in
// isisds_command.h
// clang-format off
-GCC_DIAG_OFF(unused-variable)
+DIAG_OFF(unused-variable)
// clang-format on
#endif
#include "DAE/idc.h"
diff --git a/Framework/LiveData/src/ISIS/ISISLiveEventDataListener.cpp b/Framework/LiveData/src/ISIS/ISISLiveEventDataListener.cpp
index 53c620436f3..ec5fa9a69a9 100644
--- a/Framework/LiveData/src/ISIS/ISISLiveEventDataListener.cpp
+++ b/Framework/LiveData/src/ISIS/ISISLiveEventDataListener.cpp
@@ -20,7 +20,7 @@
// Avoid compiler warnings on gcc from unused static constants in
// isisds_command.h
// clang-format off
-GCC_DIAG_OFF(unused-variable)
+DIAG_OFF(unused-variable)
// clang-format on
#endif
#include "DAE/idc.h"
diff --git a/Framework/LiveData/src/Kafka/KafkaEventStreamDecoder.cpp b/Framework/LiveData/src/Kafka/KafkaEventStreamDecoder.cpp
index d702caa6db8..ce1c7af7835 100644
--- a/Framework/LiveData/src/Kafka/KafkaEventStreamDecoder.cpp
+++ b/Framework/LiveData/src/Kafka/KafkaEventStreamDecoder.cpp
@@ -14,13 +14,17 @@
#include "MantidLiveData/Exception.h"
#include "MantidLiveData/Kafka/KafkaTopicSubscriber.h"
-GCC_DIAG_OFF(conversion)
+// clang-format off
+DIAG_OFF(conversion)
+// clang-format on
#include "private/Schema/ba57_run_info_generated.h"
#include "private/Schema/df12_det_spec_map_generated.h"
#include "private/Schema/ev42_events_generated.h"
#include "private/Schema/f142_logdata_generated.h"
#include "private/Schema/is84_isis_events_generated.h"
-GCC_DIAG_ON(conversion)
+// clang-format off
+DIAG_ON(conversion)
+// clang-format on
using namespace Mantid::Types;
diff --git a/Framework/LiveData/test/KafkaTesting.h b/Framework/LiveData/test/KafkaTesting.h
index 10fccde3adf..e0e52f06a5c 100644
--- a/Framework/LiveData/test/KafkaTesting.h
+++ b/Framework/LiveData/test/KafkaTesting.h
@@ -8,13 +8,17 @@
#include "MantidTypes/Core/DateAndTime.h"
#include <gmock/gmock.h>
-GCC_DIAG_OFF(conversion)
+// clang-format off
+DIAG_OFF(conversion)
+// clang-format on
#include "Kafka/private/Schema/ba57_run_info_generated.h"
#include "Kafka/private/Schema/df12_det_spec_map_generated.h"
#include "Kafka/private/Schema/ev42_events_generated.h"
#include "Kafka/private/Schema/f142_logdata_generated.h"
#include "Kafka/private/Schema/is84_isis_events_generated.h"
-GCC_DIAG_ON(conversion)
+// clang-format off
+DIAG_ON(conversion)
+// clang-format on
#include <ctime>
@@ -29,7 +33,7 @@ public:
std::unique_ptr<Mantid::LiveData::IKafkaStreamSubscriber>;
using IKafkaStreamSubscriber_ptr = Mantid::LiveData::IKafkaStreamSubscriber *;
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
// GMock cannot mock non-copyable return types so we resort to a small
// adapter method. Users have to use EXPECT_CALL(subscribe_) instead
MOCK_CONST_METHOD2(subscribe_, IKafkaStreamSubscriber_ptr(
@@ -50,7 +54,7 @@ public:
return std::unique_ptr<Mantid::LiveData::IKafkaStreamSubscriber>(
this->subscribe_(s, offset, option));
}
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
// -----------------------------------------------------------------------------
diff --git a/Framework/MDAlgorithms/src/LoadSQW2.cpp b/Framework/MDAlgorithms/src/LoadSQW2.cpp
index 434846121ae..07855d71443 100644
--- a/Framework/MDAlgorithms/src/LoadSQW2.cpp
+++ b/Framework/MDAlgorithms/src/LoadSQW2.cpp
@@ -12,12 +12,13 @@
#include "MantidGeometry/MDGeometry/MDHistoDimension.h"
#include "MantidGeometry/MDGeometry/MDHistoDimensionBuilder.h"
#include "MantidKernel/ListValidator.h"
-#include "MantidKernel/make_unique.h"
#include "MantidKernel/Matrix.h"
#include "MantidKernel/Memory.h"
#include "MantidKernel/ThreadScheduler.h"
#include "MantidKernel/Timer.h"
#include "MantidKernel/V3D.h"
+#include "MantidKernel/WarningSuppressions.h"
+#include "MantidKernel/make_unique.h"
namespace Mantid {
namespace MDAlgorithms {
@@ -482,12 +483,11 @@ std::vector<float> LoadSQW2::calculateDimLimitsFromData() {
return dimLimits;
}
-#ifdef __clang__
// The missing braces warning is a false positive -
// https://llvm.org/bugs/show_bug.cgi?id=21629
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wmissing-braces"
-#endif
+// clang-format off
+DIAG_OFF(missing-braces)
+// clang-format on
/**
* Create the Q MDHistoDimension for the output frame and given information
* from the file
@@ -540,9 +540,10 @@ LoadSQW2::createQDimension(size_t index, float dimMin, float dimMax,
return builder.create();
}
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+
+// clang-format off
+DIAG_ON(missing-braces)
+// clang-format on
/**
* Create an energy dimension
diff --git a/Framework/MDAlgorithms/test/BinMDTest.h b/Framework/MDAlgorithms/test/BinMDTest.h
index 980e8d0b7b4..c2e46f0fc7c 100644
--- a/Framework/MDAlgorithms/test/BinMDTest.h
+++ b/Framework/MDAlgorithms/test/BinMDTest.h
@@ -34,7 +34,7 @@ using namespace Mantid::MDAlgorithms;
using Mantid::coord_t;
class BinMDTest : public CxxTest::TestSuite {
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
private:
// Helper class. Mock Implicit function.
class MockImplicitFunction : public Mantid::Geometry::MDImplicitFunction {
@@ -45,7 +45,7 @@ private:
std::string getName() const override { return "MockImplicitFunction"; }
MOCK_CONST_METHOD0(toXMLString, std::string());
};
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
// Helper class. Builds mock implicit functions.
class MockImplicitFunctionBuilder
: public Mantid::API::ImplicitFunctionBuilder {
diff --git a/Framework/MDAlgorithms/test/BinaryOperationMDTest.h b/Framework/MDAlgorithms/test/BinaryOperationMDTest.h
index eef27e2ee8c..d3ea69b26bb 100644
--- a/Framework/MDAlgorithms/test/BinaryOperationMDTest.h
+++ b/Framework/MDAlgorithms/test/BinaryOperationMDTest.h
@@ -19,7 +19,7 @@ using namespace Mantid::DataObjects;
using namespace Mantid::MDAlgorithms;
using namespace testing;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockBinaryOperationMD : public BinaryOperationMD {
public:
@@ -35,7 +35,7 @@ public:
Mantid::DataObjects::WorkspaceSingleValue_const_sptr scalar));
void exec() override { BinaryOperationMD::exec(); }
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
class BinaryOperationMDTest : public CxxTest::TestSuite {
public:
// This pair of boilerplate methods prevent the suite being created statically
diff --git a/Framework/MDAlgorithms/test/BooleanBinaryOperationMDTest.h b/Framework/MDAlgorithms/test/BooleanBinaryOperationMDTest.h
index dc7024cd302..a29594e1afc 100644
--- a/Framework/MDAlgorithms/test/BooleanBinaryOperationMDTest.h
+++ b/Framework/MDAlgorithms/test/BooleanBinaryOperationMDTest.h
@@ -9,7 +9,7 @@
using namespace Mantid::MDAlgorithms;
using namespace testing;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockBooleanBinaryOperationMD : public BooleanBinaryOperationMD {
public:
MOCK_METHOD0(initExtraProperties, void());
@@ -17,7 +17,7 @@ public:
void(Mantid::DataObjects::MDHistoWorkspace_sptr,
Mantid::DataObjects::MDHistoWorkspace_const_sptr));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
class BooleanBinaryOperationMDTest : public CxxTest::TestSuite {
public:
void test_basics() {
diff --git a/Framework/MDAlgorithms/test/LoadSQW2Test.h b/Framework/MDAlgorithms/test/LoadSQW2Test.h
index f54287f8e6f..292a2d375e6 100644
--- a/Framework/MDAlgorithms/test/LoadSQW2Test.h
+++ b/Framework/MDAlgorithms/test/LoadSQW2Test.h
@@ -8,8 +8,9 @@
#include "MantidAPI/Run.h"
#include "MantidAPI/Sample.h"
#include "MantidGeometry/Crystal/OrientedLattice.h"
-#include "MantidMDAlgorithms/LoadSQW2.h"
+#include "MantidKernel/WarningSuppressions.h"
#include "MantidKernel/make_unique.h"
+#include "MantidMDAlgorithms/LoadSQW2.h"
#include <Poco/TemporaryFile.h>
@@ -189,12 +190,9 @@ private:
}
}
-#ifdef __clang__
-// The missing braces warning is a false positive -
-// https://llvm.org/bugs/show_bug.cgi?id=21629
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wmissing-braces"
-#endif
+ // clang-format off
+ DIAG_OFF(missing-braces)
+ // clang-format on
DimensionProperties getExpectedDimProperties(std::string outputFrame,
DataType dtype) {
DimensionProperties expected;
@@ -235,9 +233,9 @@ private:
return expected;
}
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+ // clang-format off
+ DIAG_ON(missing-braces)
+ // clang-format on
void checkExperimentInfoAsExpected(const IMDEventWorkspace &outputWS) {
TS_ASSERT_EQUALS(2, outputWS.getNumExperimentInfo());
diff --git a/Framework/MDAlgorithms/test/PreprocessDetectorsToMDTest.h b/Framework/MDAlgorithms/test/PreprocessDetectorsToMDTest.h
index c13b00a06eb..dd4d3efa652 100644
--- a/Framework/MDAlgorithms/test/PreprocessDetectorsToMDTest.h
+++ b/Framework/MDAlgorithms/test/PreprocessDetectorsToMDTest.h
@@ -101,7 +101,6 @@ public:
auto &Azimuthal = tws->getColVector<double>("Azimuthal");
auto &detDir = tws->getColVector<Kernel::V3D>("DetDirections");
- TS_ASSERT(&detDir[0]);
TS_ASSERT_EQUALS(nVal, detDir.size());
for (size_t i = 0; i < nVal; i++) {
diff --git a/Framework/MDAlgorithms/test/UnaryOperationMDTest.h b/Framework/MDAlgorithms/test/UnaryOperationMDTest.h
index a7ffd215560..af029f93541 100644
--- a/Framework/MDAlgorithms/test/UnaryOperationMDTest.h
+++ b/Framework/MDAlgorithms/test/UnaryOperationMDTest.h
@@ -23,11 +23,11 @@ using namespace testing;
class MockUnaryOperationMD : public UnaryOperationMD {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD1(execEvent, void(Mantid::API::IMDEventWorkspace_sptr));
MOCK_METHOD0(checkInputs, void());
MOCK_METHOD1(execHisto, void(Mantid::DataObjects::MDHistoWorkspace_sptr));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
void exec() override { UnaryOperationMD::exec(); }
};
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/Algorithm.cpp b/Framework/PythonInterface/mantid/api/src/Exports/Algorithm.cpp
index d2621202c0d..423f2c29b1f 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/Algorithm.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/Algorithm.cpp
@@ -58,14 +58,13 @@ using declarePropertyType3 = void (*)(boost::python::object &,
using declarePropertyType4 = void (*)(boost::python::object &,
const std::string &,
const boost::python::object &, const int);
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
// Overload types
BOOST_PYTHON_FUNCTION_OVERLOADS(declarePropertyType1_Overload,
PythonAlgorithm::declarePyAlgProperty, 2, 3)
@@ -73,10 +72,11 @@ BOOST_PYTHON_FUNCTION_OVERLOADS(declarePropertyType2_Overload,
PythonAlgorithm::declarePyAlgProperty, 3, 6)
BOOST_PYTHON_FUNCTION_OVERLOADS(declarePropertyType3_Overload,
PythonAlgorithm::declarePyAlgProperty, 4, 5)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
/**
* Map a CancelException to a Python KeyboardInterupt
* @param exc A cancel exception to translate. Unused here as the message is
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/AlgorithmFactory.cpp b/Framework/PythonInterface/mantid/api/src/Exports/AlgorithmFactory.cpp
index c11799f6d88..b1b8c889f48 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/AlgorithmFactory.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/AlgorithmFactory.cpp
@@ -82,7 +82,7 @@ list getDescriptors(AlgorithmFactoryImpl &self, bool includeHidden) {
std::recursive_mutex PYALG_REGISTER_MUTEX;
// clang-format off
-GCC_DIAG_OFF(cast-qual)
+DIAG_OFF(cast-qual)
// clang-format on
/**
@@ -118,24 +118,25 @@ void subscribe(AlgorithmFactoryImpl &self, const boost::python::object &obj) {
// from the FileLoaderRegistry
FileLoaderRegistry::Instance().unsubscribe(descr.first, descr.second);
}
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(existsOverloader, exists, 1, 2)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
///@endcond
}
// clang-format off
-GCC_DIAG_ON(cast-qual)
+DIAG_ON(cast-qual)
// clang-format on
void export_AlgorithmFactory() {
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/AlgorithmManager.cpp b/Framework/PythonInterface/mantid/api/src/Exports/AlgorithmManager.cpp
index 17e516340fa..a0587d8cb71 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/AlgorithmManager.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/AlgorithmManager.cpp
@@ -56,24 +56,24 @@ boost::python::list runningInstancesOf(AlgorithmManagerImpl &self,
///@cond
//------------------------------------------------------------------------------------------------------
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
/// Define overload generators
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(create_overloads,
AlgorithmManagerImpl::create, 1, 2)
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(createUnmanaged_overloads,
AlgorithmManagerImpl::createUnmanaged, 1,
2)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
///@endcond
}
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/Axis.cpp b/Framework/PythonInterface/mantid/api/src/Exports/Axis.cpp
index c5374df149d..2a32a21e5da 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/Axis.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/Axis.cpp
@@ -29,21 +29,20 @@ GET_POINTER_SPECIALIZATION(Axis)
namespace {
//------------------------------- Overload macros ---------------------------
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
// Overloads for operator() function which has 1 optional argument
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(Axis_getValue, Axis::getValue, 1, 2)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
-
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
/**
* Extract the axis values as a sequence. A numpy array is used if the
* data is numerical or a simple python list is used if the data is a string
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/CompositeFunction.cpp b/Framework/PythonInterface/mantid/api/src/Exports/CompositeFunction.cpp
index ff4ffee34c9..f850a9fe7f9 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/CompositeFunction.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/CompositeFunction.cpp
@@ -19,18 +19,18 @@ using getParameterType2 =
using setParameterType2 = void (CompositeFunction::*)(const std::string &,
const double &, bool);
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
-GCC_DIAG_OFF(conversion)
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
+DIAG_OFF(conversion)
+// clang-format on
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(setParameterType2_Overloads,
setParameter, 2, 3)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
} // namespace
void export_CompositeFunction() {
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/ExperimentInfo.cpp b/Framework/PythonInterface/mantid/api/src/Exports/ExperimentInfo.cpp
index 1fef2a19a2f..32325425ed8 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/ExperimentInfo.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/ExperimentInfo.cpp
@@ -18,21 +18,21 @@ using namespace boost::python;
GET_POINTER_SPECIALIZATION(ExperimentInfo)
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
/// Overload generator for getInstrumentFilename
BOOST_PYTHON_FUNCTION_OVERLOADS(getInstrumentFilename_Overload,
ExperimentInfo::getInstrumentFilename, 1, 2)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
void export_ExperimentInfo() {
register_ptr_to_python<boost::shared_ptr<ExperimentInfo>>();
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/FileFinder.cpp b/Framework/PythonInterface/mantid/api/src/Exports/FileFinder.cpp
index 0431dcd3f7c..26f6be43d65 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/FileFinder.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/FileFinder.cpp
@@ -9,19 +9,19 @@ using Mantid::API::FileFinderImpl;
using namespace boost::python;
namespace {
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(getFullPathOverloader, getFullPath, 1, 2)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
}
void export_FileFinder() {
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/IFunction.cpp b/Framework/PythonInterface/mantid/api/src/Exports/IFunction.cpp
index 3cc36a8ea48..0a0bf2692b4 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/IFunction.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/IFunction.cpp
@@ -50,14 +50,13 @@ double getError(IFunction &self, std::string const &name) {
// -- Set property overloads --
// setProperty(index,value,explicit)
using setParameterType1 = void (IFunction::*)(size_t, const double &, bool);
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(setParameterType1_Overloads,
setParameter, 2, 3)
// setProperty(index,value,explicit)
@@ -74,10 +73,11 @@ BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(fix_Overloads, fix, 1, 2)
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(fixAll_Overloads, fixAll, 0, 1)
using removeTieByName = void (IFunction::*)(const std::string &);
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
///@endcond
}
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/IMaskWorkspace.cpp b/Framework/PythonInterface/mantid/api/src/Exports/IMaskWorkspace.cpp
index b5d7c509b12..e03233f2ace 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/IMaskWorkspace.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/IMaskWorkspace.cpp
@@ -7,7 +7,7 @@
#include <boost/python/list.hpp>
// clang-format off
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(strict-aliasing)
// clang-format on
using Mantid::API::IMaskWorkspace;
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/MatrixWorkspace.cpp b/Framework/PythonInterface/mantid/api/src/Exports/MatrixWorkspace.cpp
index 38480dd58b8..389f63f20cc 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/MatrixWorkspace.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/MatrixWorkspace.cpp
@@ -49,21 +49,21 @@ using return_readwrite_numpy =
return_value_policy<VectorRefToNumpy<WrapReadWrite>>;
//------------------------------- Overload macros ---------------------------
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
// Overloads for binIndexOf function which has 1 optional argument
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(MatrixWorkspace_binIndexOfOverloads,
MatrixWorkspace::binIndexOf, 1, 2)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
/**
* Set the values from an python array-style object into the given spectrum in
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/Projection.cpp b/Framework/PythonInterface/mantid/api/src/Exports/Projection.cpp
index 505e150c33d..0239146f3f5 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/Projection.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/Projection.cpp
@@ -15,7 +15,7 @@ using namespace Mantid::API;
using namespace Mantid::PythonInterface;
using namespace boost::python;
// clang-format off
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(strict-aliasing)
// clang-format on
namespace {
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/Run.cpp b/Framework/PythonInterface/mantid/api/src/Exports/Run.cpp
index cce9b24dbfa..dcb42b16655 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/Run.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/Run.cpp
@@ -115,20 +115,20 @@ bpl::list keys(Run &self) {
return names;
}
}
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(integrateProtonCharge_Overload,
integrateProtonCharge, 0, 1)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
void export_Run() {
// Pointer
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/Workspace.cpp b/Framework/PythonInterface/mantid/api/src/Exports/Workspace.cpp
index 68a4e2a8e2c..227f9999e6c 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/Workspace.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/Workspace.cpp
@@ -19,20 +19,21 @@ GET_POINTER_SPECIALIZATION(Workspace)
namespace {
///@cond
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(Workspace_isDirtyOverloads,
Workspace::isDirty, 0, 1)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
+
///@endcond
}
diff --git a/Framework/PythonInterface/mantid/api/src/Exports/WorkspaceFactory.cpp b/Framework/PythonInterface/mantid/api/src/Exports/WorkspaceFactory.cpp
index 3ded562f0ae..9561fa83a4e 100644
--- a/Framework/PythonInterface/mantid/api/src/Exports/WorkspaceFactory.cpp
+++ b/Framework/PythonInterface/mantid/api/src/Exports/WorkspaceFactory.cpp
@@ -46,22 +46,22 @@ Workspace_sptr createFromParentPtr(WorkspaceFactoryImpl &self,
}
/// Overload generator for create
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
BOOST_PYTHON_FUNCTION_OVERLOADS(createFromParent_Overload, createFromParentPtr,
2, 5)
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(createTable_Overload, createTable, 0, 1)
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(createPeaks_Overload, createPeaks, 0, 1)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
}
void export_WorkspaceFactory() {
diff --git a/Framework/PythonInterface/mantid/api/src/PythonAlgorithm/AlgorithmAdapter.cpp b/Framework/PythonInterface/mantid/api/src/PythonAlgorithm/AlgorithmAdapter.cpp
index 27cde8ecbc1..c20274fd4ae 100644
--- a/Framework/PythonInterface/mantid/api/src/PythonAlgorithm/AlgorithmAdapter.cpp
+++ b/Framework/PythonInterface/mantid/api/src/PythonAlgorithm/AlgorithmAdapter.cpp
@@ -1,13 +1,14 @@
#include "MantidPythonInterface/api/PythonAlgorithm/AlgorithmAdapter.h"
-#include "MantidPythonInterface/kernel/Registry/PropertyWithValueFactory.h"
-#include "MantidPythonInterface/kernel/Environment/WrapperHelpers.h"
-#include "MantidPythonInterface/kernel/Environment/CallMethod.h"
-#include "MantidPythonInterface/kernel/Environment/GlobalInterpreterLock.h"
-#include "MantidPythonInterface/kernel/Converters/PySequenceToVector.h"
#include "MantidAPI/DataProcessorAlgorithm.h"
-#include "MantidAPI/SerialAlgorithm.h"
-#include "MantidAPI/ParallelAlgorithm.h"
#include "MantidAPI/DistributedAlgorithm.h"
+#include "MantidAPI/ParallelAlgorithm.h"
+#include "MantidAPI/SerialAlgorithm.h"
+#include "MantidKernel/WarningSuppressions.h"
+#include "MantidPythonInterface/kernel/Converters/PySequenceToVector.h"
+#include "MantidPythonInterface/kernel/Environment/CallMethod.h"
+#include "MantidPythonInterface/kernel/Environment/GlobalInterpreterLock.h"
+#include "MantidPythonInterface/kernel/Environment/WrapperHelpers.h"
+#include "MantidPythonInterface/kernel/Registry/PropertyWithValueFactory.h"
#include <boost/python/class.hpp>
#include <boost/python/dict.hpp>
@@ -145,10 +146,10 @@ bool AlgorithmAdapter<BaseAlgorithm>::isRunning() const {
return SuperClass::isRunning();
} else {
Environment::GlobalInterpreterLock gil;
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wparentheses-equality"
-#endif
+
+ // clang-format off
+ DIAG_OFF(parentheses-equality)
+ // clang-format on
PyObject *result = PyObject_CallObject(m_isRunningObj, nullptr);
if (PyErr_Occurred())
throw Environment::PythonException();
@@ -164,9 +165,9 @@ bool AlgorithmAdapter<BaseAlgorithm>::isRunning() const {
throw std::runtime_error(
"Algorithm.isRunning - Expected bool return type.");
}
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+ // clang-format off
+ DIAG_ON(parentheses-equality)
+ // clang-format on
}
/**
diff --git a/Framework/PythonInterface/mantid/geometry/src/Exports/Component.cpp b/Framework/PythonInterface/mantid/geometry/src/Exports/Component.cpp
index 3d698a7e310..489bb6f3340 100644
--- a/Framework/PythonInterface/mantid/geometry/src/Exports/Component.cpp
+++ b/Framework/PythonInterface/mantid/geometry/src/Exports/Component.cpp
@@ -8,15 +8,14 @@ using Mantid::Geometry::IComponent;
using namespace boost::python;
namespace {
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
// Default parameter function overloads
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(Component_getParameterNames,
@@ -47,11 +46,11 @@ BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(Component_getParamShortDescription,
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(Component_getParamDescription,
Component::getParamDescription, 1, 2)
-GCC_DIAG_ON(conversion)
-
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
}
void export_Component() {
class_<Component, bases<IComponent>, boost::noncopyable>("Component", no_init)
diff --git a/Framework/PythonInterface/mantid/geometry/src/Exports/Goniometer.cpp b/Framework/PythonInterface/mantid/geometry/src/Exports/Goniometer.cpp
index 696b7904f1b..0797ea91273 100644
--- a/Framework/PythonInterface/mantid/geometry/src/Exports/Goniometer.cpp
+++ b/Framework/PythonInterface/mantid/geometry/src/Exports/Goniometer.cpp
@@ -16,21 +16,21 @@ using namespace boost::python;
namespace //<unnamed>
{
///@cond
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
// define overloaded functions
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(getEulerAngles_overloads,
Goniometer::getEulerAngles, 0, 1)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
///@endcond
/// Set the U vector via a numpy array
diff --git a/Framework/PythonInterface/mantid/geometry/src/Exports/IMDDimension.cpp b/Framework/PythonInterface/mantid/geometry/src/Exports/IMDDimension.cpp
index b4ea42225ef..e4a1c6c3fdd 100644
--- a/Framework/PythonInterface/mantid/geometry/src/Exports/IMDDimension.cpp
+++ b/Framework/PythonInterface/mantid/geometry/src/Exports/IMDDimension.cpp
@@ -16,7 +16,7 @@ using namespace boost::python;
GET_POINTER_SPECIALIZATION(IMDDimension)
// clang-format off
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(strict-aliasing)
// clang-format on
namespace {
diff --git a/Framework/PythonInterface/mantid/kernel/src/Converters/DateAndTime.cpp b/Framework/PythonInterface/mantid/kernel/src/Converters/DateAndTime.cpp
index 8ae377da147..461f2ad1616 100644
--- a/Framework/PythonInterface/mantid/kernel/src/Converters/DateAndTime.cpp
+++ b/Framework/PythonInterface/mantid/kernel/src/Converters/DateAndTime.cpp
@@ -1,4 +1,5 @@
#include "MantidPythonInterface/kernel/Converters/DateAndTime.h"
+#include "MantidKernel/WarningSuppressions.h"
#include "MantidPythonInterface/kernel/Converters/NumpyFunctions.h"
#include <boost/make_shared.hpp>
#include <boost/python.hpp>
@@ -46,14 +47,13 @@ PyArray_Descr *descr_ns() { return func_PyArray_Descr("M8[ns]"); }
// internal function that handles raw pointer
boost::shared_ptr<Types::Core::DateAndTime>
to_dateandtime(const PyObject *datetime) {
-#if __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wcast-qual"
-#endif
+ // clang-format off
+DIAG_OFF(cast-qual)
+ // clang-format on
if (!PyArray_IsScalar(datetime, Datetime)) {
-#if __clang__
-#pragma clang diagnostic pop
-#endif
+ // clang-format off
+DIAG_ON(cast-qual)
+ // clang-format on
throw std::runtime_error("Expected datetime64");
}
diff --git a/Framework/PythonInterface/mantid/kernel/src/Converters/PyObjectToVMD.cpp b/Framework/PythonInterface/mantid/kernel/src/Converters/PyObjectToVMD.cpp
index 618decc87ea..8f7c008549c 100644
--- a/Framework/PythonInterface/mantid/kernel/src/Converters/PyObjectToVMD.cpp
+++ b/Framework/PythonInterface/mantid/kernel/src/Converters/PyObjectToVMD.cpp
@@ -16,7 +16,7 @@ using boost::python::object;
using boost::python::len;
// clang-format off
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(strict-aliasing)
// clang-format on
namespace Mantid {
diff --git a/Framework/PythonInterface/mantid/kernel/src/Exports/ConfigService.cpp b/Framework/PythonInterface/mantid/kernel/src/Exports/ConfigService.cpp
index 80e8adbb5b3..96d1149cdc9 100644
--- a/Framework/PythonInterface/mantid/kernel/src/Exports/ConfigService.cpp
+++ b/Framework/PythonInterface/mantid/kernel/src/Exports/ConfigService.cpp
@@ -32,23 +32,23 @@ std::string getStringUsingCache(ConfigServiceImpl &self,
return self.getString(key, true);
}
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
/// Overload generator for getInstrument
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(getInstrument_Overload, getInstrument, 0,
1)
/// Overload generator for getString
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(getString_Overload, getString, 1, 2)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
}
void export_ConfigService() {
diff --git a/Framework/PythonInterface/mantid/kernel/src/Exports/Property.cpp b/Framework/PythonInterface/mantid/kernel/src/Exports/Property.cpp
index 6afa71964e1..7a4610f42fb 100644
--- a/Framework/PythonInterface/mantid/kernel/src/Exports/Property.cpp
+++ b/Framework/PythonInterface/mantid/kernel/src/Exports/Property.cpp
@@ -24,19 +24,20 @@ using Mantid::PythonInterface::std_vector_exporter;
using namespace boost::python;
GET_POINTER_SPECIALIZATION(Property)
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(valueAsPrettyStrOverloader,
valueAsPrettyStr, 0, 2)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
void export_Property() {
register_ptr_to_python<Property *>();
diff --git a/Framework/PythonInterface/mantid/kernel/src/Exports/Statistics.cpp b/Framework/PythonInterface/mantid/kernel/src/Exports/Statistics.cpp
index ff875b07332..7af14bf7efe 100644
--- a/Framework/PythonInterface/mantid/kernel/src/Exports/Statistics.cpp
+++ b/Framework/PythonInterface/mantid/kernel/src/Exports/Statistics.cpp
@@ -97,21 +97,21 @@ Statistics getStatisticsNumpy(const NumPy::NdArray &data,
}
}
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
// Define an overload to handle the default argument
BOOST_PYTHON_FUNCTION_OVERLOADS(getStatisticsOverloads, getStatisticsNumpy, 1,
2)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
//============================ Z score
//============================================
@@ -160,21 +160,21 @@ std::vector<double> getModifiedZscoreNumpy(const NumPy::NdArray &data,
}
}
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
// Define an overload to handle the default argument
BOOST_PYTHON_FUNCTION_OVERLOADS(getModifiedZscoreOverloads,
getModifiedZscoreNumpy, 1, 2)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
//============================ getMoments
//============================================
@@ -225,21 +225,21 @@ std::vector<double> getMomentsAboutOriginNumpy(const NumPy::NdArray &indep,
return getMomentsNumpyImpl(&getMomentsAboutOrigin, indep, depend, maxMoment);
}
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
// Define an overload to handle the default argument
BOOST_PYTHON_FUNCTION_OVERLOADS(getMomentsAboutOriginOverloads,
getMomentsAboutOriginNumpy, 2, 3)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
/**
* Proxy for @see Mantid::Kernel::getMomentsAboutMean so that it can accept
* numpy arrays
@@ -251,21 +251,21 @@ std::vector<double> getMomentsAboutMeanNumpy(const NumPy::NdArray &indep,
return getMomentsNumpyImpl(&getMomentsAboutMean, indep, depend, maxMoment);
}
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
// Define an overload to handle the default argument
BOOST_PYTHON_FUNCTION_OVERLOADS(getMomentsAboutMeanOverloads,
getMomentsAboutMeanNumpy, 2, 3)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
///@endcond
}
diff --git a/Framework/PythonInterface/mantid/kernel/src/Registry/PropertyWithValueFactory.cpp b/Framework/PythonInterface/mantid/kernel/src/Registry/PropertyWithValueFactory.cpp
index ff167998560..052bbebb7b9 100644
--- a/Framework/PythonInterface/mantid/kernel/src/Registry/PropertyWithValueFactory.cpp
+++ b/Framework/PythonInterface/mantid/kernel/src/Registry/PropertyWithValueFactory.cpp
@@ -2,10 +2,11 @@
// Includes
//-----------------------------------------------------------------------------
#include "MantidPythonInterface/kernel/Registry/PropertyWithValueFactory.h"
+#include "MantidKernel/PropertyWithValue.h"
+#include "MantidKernel/WarningSuppressions.h"
#include "MantidPythonInterface/kernel/Registry/MappingTypeHandler.h"
-#include "MantidPythonInterface/kernel/Registry/TypedPropertyValueHandler.h"
#include "MantidPythonInterface/kernel/Registry/SequenceTypeHandler.h"
-#include "MantidKernel/PropertyWithValue.h"
+#include "MantidPythonInterface/kernel/Registry/TypedPropertyValueHandler.h"
#include <boost/make_shared.hpp>
@@ -186,10 +187,9 @@ const std::string PropertyWithValueFactory::isArray(PyObject *const object) {
PyObject *item = PySequence_Fast_GET_ITEM(object, 0);
// Boolean can be cast to int, so check first.
-#if __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wparentheses-equality"
-#endif
+ // clang-format off
+ DIAG_OFF(parentheses-equality)
+ // clang-format on
if (PyBool_Check(item)) {
throw std::runtime_error(
"Unable to support extracting arrays of booleans.");
@@ -197,9 +197,9 @@ const std::string PropertyWithValueFactory::isArray(PyObject *const object) {
if (PyLong_Check(item)) {
return std::string("LongIntArray");
}
-#if __clang__
-#pragma clang diagnostic pop
-#endif
+ // clang-format off
+ DIAG_ON(parentheses-equality)
+// clang-format on
#if PY_MAJOR_VERSION < 3
// In python 2 ints & longs are separate
diff --git a/Framework/PythonInterface/test/testhelpers/WorkspaceCreationHelperModule.cpp b/Framework/PythonInterface/test/testhelpers/WorkspaceCreationHelperModule.cpp
index 61e734beea9..36f88528d07 100644
--- a/Framework/PythonInterface/test/testhelpers/WorkspaceCreationHelperModule.cpp
+++ b/Framework/PythonInterface/test/testhelpers/WorkspaceCreationHelperModule.cpp
@@ -22,14 +22,13 @@ using namespace Mantid::DataObjects::MDEventsTestHelper;
using namespace Mantid::PythonInterface::Policies;
using namespace WorkspaceCreationHelper;
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wunused-local-typedef"
-#endif
+// clang-format off
+DIAG_OFF(unknown-pragmas)
+DIAG_OFF(unused-local-typdef)
// Ignore -Wconversion warnings coming from boost::python
// Seen with GCC 7.1.1 and Boost 1.63.0
-GCC_DIAG_OFF(conversion)
+DIAG_OFF(conversion)
+// clang-format on
BOOST_PYTHON_FUNCTION_OVERLOADS(create2DWorkspaceWithFullInstrument_overloads,
create2DWorkspaceWithFullInstrument, 2, 4)
@@ -39,10 +38,11 @@ BOOST_PYTHON_FUNCTION_OVERLOADS(makeFakeMDHistoWorkspace_overloads,
BOOST_PYTHON_FUNCTION_OVERLOADS(
create2DWorkspaceWithRectangularInstrument_overloads,
create2DWorkspaceWithRectangularInstrument, 3, 3)
-GCC_DIAG_ON(conversion)
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+// clang-format off
+DIAG_ON(conversion)
+DIAG_ON(unknown-pragmas)
+DIAG_ON(unused-local-typdef)
+// clang-format on
BOOST_PYTHON_MODULE(WorkspaceCreationHelper) {
using namespace boost::python;
diff --git a/Framework/SINQ/inc/MantidSINQ/PoldiUtilities/PoldiMockInstrumentHelpers.h b/Framework/SINQ/inc/MantidSINQ/PoldiUtilities/PoldiMockInstrumentHelpers.h
index eb0672a6c57..41f3fb1d6ad 100644
--- a/Framework/SINQ/inc/MantidSINQ/PoldiUtilities/PoldiMockInstrumentHelpers.h
+++ b/Framework/SINQ/inc/MantidSINQ/PoldiUtilities/PoldiMockInstrumentHelpers.h
@@ -53,14 +53,14 @@ public:
void loadConfiguration(Instrument_const_sptr poldiInstrument) override {
UNUSED_ARG(poldiInstrument);
}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD0(efficiency, double());
MOCK_METHOD1(twoTheta, double(int elementIndex));
MOCK_METHOD1(distanceFromSample, double(int elementIndex));
MOCK_METHOD0(elementCount, size_t());
MOCK_METHOD0(centralElement, size_t());
MOCK_METHOD2(qLimits, DoublePair(double lambdaMin, double lambdaMax));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
const std::vector<int> &availableElements() override {
return m_availableElements;
@@ -105,14 +105,14 @@ public:
void loadConfiguration(Instrument_const_sptr poldiInstrument) override {
UNUSED_ARG(poldiInstrument)
}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD0(rotationSpeed, double());
MOCK_METHOD0(cycleTime, double());
MOCK_METHOD0(zeroOffset, double());
MOCK_METHOD0(distanceFromSample, double());
MOCK_METHOD1(setRotationSpeed, void(double rotationSpeed));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
const std::vector<double> &slitPositions() override {
return m_slitPositions;
diff --git a/Framework/SINQ/test/PoldiSpectrumPawleyFunctionTest.h b/Framework/SINQ/test/PoldiSpectrumPawleyFunctionTest.h
index e1251164486..15f7b2a39ae 100644
--- a/Framework/SINQ/test/PoldiSpectrumPawleyFunctionTest.h
+++ b/Framework/SINQ/test/PoldiSpectrumPawleyFunctionTest.h
@@ -21,7 +21,7 @@ using Mantid::Kernel::V3D;
using ::testing::_;
using ::testing::Mock;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockPawleyFunction : public IPawleyFunction {
public:
@@ -45,7 +45,7 @@ public:
MOCK_METHOD4(setMatrixWorkspace,
void(MatrixWorkspace_const_sptr, size_t, double, double));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
protected:
void init() override { setDecoratedFunction("Gaussian"); }
};
diff --git a/MantidPlot/src/PythonScript.cpp b/MantidPlot/src/PythonScript.cpp
index 30bd97b20e0..c7bf3395d61 100644
--- a/MantidPlot/src/PythonScript.cpp
+++ b/MantidPlot/src/PythonScript.cpp
@@ -32,6 +32,7 @@
#endif
#include "PythonScript.h"
+#include "MantidKernel/WarningSuppressions.h"
#include "PythonScripting.h"
#include "sipAPI_qti.h"
@@ -539,14 +540,13 @@ QVariant PythonScript::evaluateImpl() {
}
}
/* bool */
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wparentheses-equality"
-#endif
+ // clang-format off
+ DIAG_OFF(parentheses-equality)
+ // clang-format on
else if (PyBool_Check(pyret)) {
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
+ // clang-format off
+ DIAG_ON(parentheses-equality)
+ // clang-format on
qret = QVariant(pyret == Py_True);
}
// could handle advanced types (such as PyList->QValueList) here if needed
diff --git a/qt/paraview_ext/PVPlugins/Sources/MDEWSource/vtkMDEWSource.cxx b/qt/paraview_ext/PVPlugins/Sources/MDEWSource/vtkMDEWSource.cxx
index 73df2744afc..4ec4bf724db 100644
--- a/qt/paraview_ext/PVPlugins/Sources/MDEWSource/vtkMDEWSource.cxx
+++ b/qt/paraview_ext/PVPlugins/Sources/MDEWSource/vtkMDEWSource.cxx
@@ -186,7 +186,7 @@ int vtkMDEWSource::RequestData(vtkInformation *, vtkInformationVector **,
}
// clang-format off
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(strict-aliasing)
// clang-format on
int vtkMDEWSource::RequestInformation(
vtkInformation *vtkNotUsed(request),
diff --git a/qt/paraview_ext/VatesAPI/src/vtkDataSetToPeaksFilteredDataSet.cpp b/qt/paraview_ext/VatesAPI/src/vtkDataSetToPeaksFilteredDataSet.cpp
index 7797305d984..4999cbb5ebc 100644
--- a/qt/paraview_ext/VatesAPI/src/vtkDataSetToPeaksFilteredDataSet.cpp
+++ b/qt/paraview_ext/VatesAPI/src/vtkDataSetToPeaksFilteredDataSet.cpp
@@ -177,7 +177,7 @@ vtkDataSetToPeaksFilteredDataSet::getPeaksInfo(
}
// clang-format off
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(strict-aliasing)
// clang-format on
/**
* Get the radius from a PeakShape object.
@@ -225,7 +225,6 @@ Kernel::V3D vtkDataSetToPeaksFilteredDataSet::getPeakPosition(
return position;
}
-// GCC_DIAG_ON(strict-aliasing)
/**
* Get the radius for no shape
* @returns The shape of the radius.
diff --git a/qt/paraview_ext/VatesAPI/test/BoxInfoTest.h b/qt/paraview_ext/VatesAPI/test/BoxInfoTest.h
index bf3d5175bae..77b42a29445 100644
--- a/qt/paraview_ext/VatesAPI/test/BoxInfoTest.h
+++ b/qt/paraview_ext/VatesAPI/test/BoxInfoTest.h
@@ -55,7 +55,7 @@ public:
}
// clang-format off
- GCC_DIAG_OFF(strict-aliasing)
+ DIAG_OFF(strict-aliasing)
// clang-format on
void test_initial_recursion_depth_is_1_for_MD_Event_w_split() {
// Arrange
diff --git a/qt/paraview_ext/VatesAPI/test/ConcretePeaksPresenterVsiTest.h b/qt/paraview_ext/VatesAPI/test/ConcretePeaksPresenterVsiTest.h
index 548610c922e..efd6d6cc00a 100644
--- a/qt/paraview_ext/VatesAPI/test/ConcretePeaksPresenterVsiTest.h
+++ b/qt/paraview_ext/VatesAPI/test/ConcretePeaksPresenterVsiTest.h
@@ -23,7 +23,7 @@
using namespace ::testing;
using namespace Mantid::VATES;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockPeakConcrete : public Mantid::DataObjects::Peak {
public:
MOCK_CONST_METHOD0(getHKL, Mantid::Kernel::V3D(void));
@@ -38,7 +38,7 @@ public:
MOCK_METHOD1(getPeak, Mantid::DataObjects::Peak &(int peakNum));
MOCK_CONST_METHOD1(getPeak, const Mantid::DataObjects::Peak &(int peakNum));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
class ConcretePeaksPresenterVsiTest : public CxxTest::TestSuite {
public:
void testSetupPresenterCorrectly() {
@@ -114,4 +114,4 @@ public:
}
};
-#endif
\ No newline at end of file
+#endif
diff --git a/qt/paraview_ext/VatesAPI/test/MDEWInMemoryLoadingPresenterTest.h b/qt/paraview_ext/VatesAPI/test/MDEWInMemoryLoadingPresenterTest.h
index 797b1b4bbdd..67f60552160 100644
--- a/qt/paraview_ext/VatesAPI/test/MDEWInMemoryLoadingPresenterTest.h
+++ b/qt/paraview_ext/VatesAPI/test/MDEWInMemoryLoadingPresenterTest.h
@@ -26,12 +26,12 @@ private:
// Helper type. Mocks a Workspace Provider.
class MockWorkspaceProvider : public Mantid::VATES::WorkspaceProvider {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD1(canProvideWorkspace, bool(std::string));
MOCK_CONST_METHOD1(fetchWorkspace,
Mantid::API::Workspace_sptr(std::string));
MOCK_CONST_METHOD1(disposeWorkspace, void(std::string));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
// Helper method. Generates and returns a valid IMDEventWorkspace
diff --git a/qt/paraview_ext/VatesAPI/test/MDHWInMemoryLoadingPresenterTest.h b/qt/paraview_ext/VatesAPI/test/MDHWInMemoryLoadingPresenterTest.h
index 21716b3fb4e..13505a319b3 100644
--- a/qt/paraview_ext/VatesAPI/test/MDHWInMemoryLoadingPresenterTest.h
+++ b/qt/paraview_ext/VatesAPI/test/MDHWInMemoryLoadingPresenterTest.h
@@ -27,12 +27,12 @@ private:
// Helper type. Mocks a Workspace Provider.
class MockWorkspaceProvider : public Mantid::VATES::WorkspaceProvider {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD1(canProvideWorkspace, bool(std::string));
MOCK_CONST_METHOD1(fetchWorkspace,
Mantid::API::Workspace_sptr(std::string));
MOCK_CONST_METHOD1(disposeWorkspace, void(std::string));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
// Helper method. Generates and returns a valid IMDHistoWorkspace
diff --git a/qt/paraview_ext/VatesAPI/test/MockObjects.h b/qt/paraview_ext/VatesAPI/test/MockObjects.h
index 0a58626c34f..d780778f224 100644
--- a/qt/paraview_ext/VatesAPI/test/MockObjects.h
+++ b/qt/paraview_ext/VatesAPI/test/MockObjects.h
@@ -69,7 +69,7 @@ public:
~FakeIMDDimension() override {}
};
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
//=================================================================================================
/// Concrete mocked implementation of IMDWorkspace for testing.
class MockIMDWorkspace : public Mantid::API::IMDWorkspace {
@@ -178,7 +178,7 @@ public:
MOCK_METHOD1(eventRaised, void(double));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
class FakeProgressAction : public Mantid::VATES::ProgressAction {
void eventRaised(double) override {}
@@ -189,7 +189,7 @@ Create a field data entry containing (as contents) the argument text.
@param testData : Text to enter
@return new vtkFieldData object containing text.
*/
-GCC_UNUSED_FUNCTION vtkFieldData *
+UNUSED_FUNCTION vtkFieldData *
createFieldDataWithCharArray(std::string testData) {
vtkFieldData *fieldData = vtkFieldData::New();
vtkCharArray *charArray = vtkCharArray::New();
@@ -274,7 +274,7 @@ view.
view.
@return full xml as string.
*/
-GCC_UNUSED_FUNCTION std::string
+UNUSED_FUNCTION std::string
constructXML(const std::string &xDimensionIdMapping,
const std::string &yDimensionIdMapping,
const std::string &zDimensionIdMapping,
@@ -372,7 +372,7 @@ view.
view.
@return full xml as string.
*/
-GCC_UNUSED_FUNCTION std::string
+UNUSED_FUNCTION std::string
constructXMLForMDEvHelperData(const std::string &xDimensionIdMapping,
const std::string &yDimensionIdMapping,
const std::string &zDimensionIdMapping,
@@ -403,7 +403,7 @@ Mantid::API::Workspace_sptr createSimple3DWorkspace() {
return outWs;
}
-GCC_UNUSED_FUNCTION Mantid::API::Workspace_sptr
+UNUSED_FUNCTION Mantid::API::Workspace_sptr
get3DWorkspace(bool integratedTDimension, bool sliceMD) {
using namespace Mantid::API;
using namespace Mantid::DataObjects;
@@ -442,8 +442,8 @@ get3DWorkspace(bool integratedTDimension, bool sliceMD) {
* @param fieldName : The requested field data entry
* @return The value of the requested field data entry
*/
-GCC_UNUSED_FUNCTION std::string getStringFieldDataValue(vtkDataSet *ds,
- std::string fieldName) {
+UNUSED_FUNCTION std::string getStringFieldDataValue(vtkDataSet *ds,
+ std::string fieldName) {
vtkAbstractArray *value =
ds->GetFieldData()->GetAbstractArray(fieldName.c_str());
vtkStringArray *array = vtkStringArray::SafeDownCast(value);
diff --git a/qt/paraview_ext/VatesAPI/test/VatesKnowledgeSerializerTest.h b/qt/paraview_ext/VatesAPI/test/VatesKnowledgeSerializerTest.h
index db580dd97bb..d6c180ba680 100644
--- a/qt/paraview_ext/VatesAPI/test/VatesKnowledgeSerializerTest.h
+++ b/qt/paraview_ext/VatesAPI/test/VatesKnowledgeSerializerTest.h
@@ -21,13 +21,13 @@ private:
// Helper class
class MockImplicitFunction : public Mantid::Geometry::MDImplicitFunction {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD1(isPointContained, bool(const Mantid::coord_t *pPoint));
MOCK_METHOD1(isPointContained, bool(const std::vector<Mantid::coord_t> &));
MOCK_METHOD1(isPointContained, bool(const Mantid::Kernel::VMD &));
MOCK_CONST_METHOD0(getName, std::string());
MOCK_CONST_METHOD0(toXMLString, std::string());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
// Test methods
diff --git a/qt/paraview_ext/VatesAPI/test/vtkDataSetFactoryTest.h b/qt/paraview_ext/VatesAPI/test/vtkDataSetFactoryTest.h
index 99cfedb581f..c21dd7ddb85 100644
--- a/qt/paraview_ext/VatesAPI/test/vtkDataSetFactoryTest.h
+++ b/qt/paraview_ext/VatesAPI/test/vtkDataSetFactoryTest.h
@@ -27,14 +27,14 @@ private:
/// Mocked helper type
class MockvtkDataSetFactory : public Mantid::VATES::vtkDataSetFactory {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD1(
create, vtkSmartPointer<vtkDataSet>(Mantid::VATES::ProgressAction &));
MOCK_METHOD1(initialize,
void(const boost::shared_ptr<Mantid::API::Workspace> &));
MOCK_CONST_METHOD0(validate, void());
MOCK_CONST_METHOD0(getFactoryTypeName, std::string());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
void setSuccessorConcrete(std::unique_ptr<vtkDataSetFactory> pSuccessor) {
vtkDataSetFactory::setSuccessor(pSuccessor);
}
diff --git a/qt/paraview_ext/VatesAPI/test/vtkDataSetToPeaksFilteredDataSetTest.h b/qt/paraview_ext/VatesAPI/test/vtkDataSetToPeaksFilteredDataSetTest.h
index 142e573da02..0cf478b3869 100644
--- a/qt/paraview_ext/VatesAPI/test/vtkDataSetToPeaksFilteredDataSetTest.h
+++ b/qt/paraview_ext/VatesAPI/test/vtkDataSetToPeaksFilteredDataSetTest.h
@@ -36,7 +36,7 @@
using namespace Mantid::DataObjects;
using namespace Mantid::VATES;
using namespace ::testing;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockPeakFilter : public Mantid::DataObjects::Peak {
public:
MOCK_CONST_METHOD0(getHKL, Mantid::Kernel::V3D(void));
@@ -50,7 +50,7 @@ public:
MOCK_METHOD1(getPeak, Mantid::DataObjects::Peak &(int peakNum));
MOCK_CONST_METHOD1(getPeak, const Mantid::DataObjects::Peak &(int peakNum));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
struct PeaksFilterDataContainer {
double radius;
double radiusFactor;
diff --git a/qt/paraview_ext/VatesAPI/test/vtkPeakMarkerFactoryTest.h b/qt/paraview_ext/VatesAPI/test/vtkPeakMarkerFactoryTest.h
index 7e5c65cccbd..5708fed44b6 100644
--- a/qt/paraview_ext/VatesAPI/test/vtkPeakMarkerFactoryTest.h
+++ b/qt/paraview_ext/VatesAPI/test/vtkPeakMarkerFactoryTest.h
@@ -25,7 +25,7 @@ using namespace ::testing;
using namespace Mantid::VATES;
using Mantid::VATES::vtkPeakMarkerFactory;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockPeakShape : public Peak {
public:
@@ -55,7 +55,7 @@ public:
MOCK_METHOD1(getPeak, Mantid::DataObjects::Peak &(int peakNum));
MOCK_CONST_METHOD1(getPeak, const Mantid::DataObjects::Peak &(int peakNum));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
//=====================================================================================
// Functional Tests
diff --git a/qt/paraview_ext/VatesSimpleGui/ViewWidgets/src/ViewBase.cpp b/qt/paraview_ext/VatesSimpleGui/ViewWidgets/src/ViewBase.cpp
index 70ca26a40eb..874f9077522 100644
--- a/qt/paraview_ext/VatesSimpleGui/ViewWidgets/src/ViewBase.cpp
+++ b/qt/paraview_ext/VatesSimpleGui/ViewWidgets/src/ViewBase.cpp
@@ -269,7 +269,7 @@ pqPipelineRepresentation *ViewBase::getPvActiveRep() {
}
// clang-format off
-GCC_DIAG_OFF(strict-aliasing)
+DIAG_OFF(strict-aliasing)
// clang-format on
/**
* This function creates a ParaView source from a given plugin name and
diff --git a/qt/scientific_interfaces/test/ALCBaselineModellingPresenterTest.h b/qt/scientific_interfaces/test/ALCBaselineModellingPresenterTest.h
index f73d8446880..37b9be20776 100644
--- a/qt/scientific_interfaces/test/ALCBaselineModellingPresenterTest.h
+++ b/qt/scientific_interfaces/test/ALCBaselineModellingPresenterTest.h
@@ -24,7 +24,7 @@ using Mantid::HistogramData::Counts;
using Mantid::HistogramData::CountStandardDeviations;
using Mantid::HistogramData::LinearGenerator;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockALCBaselineModellingView : public IALCBaselineModellingView {
public:
@@ -91,7 +91,7 @@ MATCHER_P3(QwtDataY, i, value, delta, "") {
MATCHER_P3(VectorValue, i, value, delta, "") {
return fabs(arg.at(i) - value) < delta;
}
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
class ALCBaselineModellingPresenterTest : public CxxTest::TestSuite {
MockALCBaselineModellingView *m_view;
diff --git a/qt/scientific_interfaces/test/ALCDataLoadingPresenterTest.h b/qt/scientific_interfaces/test/ALCDataLoadingPresenterTest.h
index 198408673ed..cd66f852cbe 100644
--- a/qt/scientific_interfaces/test/ALCDataLoadingPresenterTest.h
+++ b/qt/scientific_interfaces/test/ALCDataLoadingPresenterTest.h
@@ -25,7 +25,7 @@ operator<<(std::basic_ostream<CharType, CharTrait> &out,
}
}
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockALCDataLoadingView : public IALCDataLoadingView {
// XXX: A workaround, needed because of the way the comma is treated in a
@@ -78,7 +78,7 @@ MATCHER_P3(VectorValue, i, value, delta, "") {
return fabs(arg.at(i) - value) < delta;
}
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
class ALCDataLoadingPresenterTest : public CxxTest::TestSuite {
MockALCDataLoadingView *m_view;
diff --git a/qt/scientific_interfaces/test/ALCPeakFittingPresenterTest.h b/qt/scientific_interfaces/test/ALCPeakFittingPresenterTest.h
index fc48c3d21b7..904aa8a26e2 100644
--- a/qt/scientific_interfaces/test/ALCPeakFittingPresenterTest.h
+++ b/qt/scientific_interfaces/test/ALCPeakFittingPresenterTest.h
@@ -32,7 +32,7 @@ operator<<(std::basic_ostream<CharType, CharTrait> &out,
}
}
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockALCPeakFittingView : public IALCPeakFittingView {
public:
@@ -359,5 +359,5 @@ public:
m_model->setError("Test error");
}
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif /* MANTIDQT_CUSTOMINTERFACES_ALCPEAKFITTINGTEST_H_ */
diff --git a/qt/scientific_interfaces/test/EnggDiffFittingModelMock.h b/qt/scientific_interfaces/test/EnggDiffFittingModelMock.h
index 462c9b48879..487bf501b97 100644
--- a/qt/scientific_interfaces/test/EnggDiffFittingModelMock.h
+++ b/qt/scientific_interfaces/test/EnggDiffFittingModelMock.h
@@ -13,7 +13,7 @@
using namespace MantidQt::CustomInterfaces;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockEnggDiffFittingModel : public IEnggDiffFittingModel {
@@ -61,6 +61,6 @@ public:
MOCK_METHOD1(removeRun, void(const RunLabel &runLabel));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif // MANTID_CUSTOM_INTERFACES_ENGGDIFFFITTINGMODELMOCK_H
diff --git a/qt/scientific_interfaces/test/EnggDiffFittingViewMock.h b/qt/scientific_interfaces/test/EnggDiffFittingViewMock.h
index 1e7d4c1831f..114f9f32850 100644
--- a/qt/scientific_interfaces/test/EnggDiffFittingViewMock.h
+++ b/qt/scientific_interfaces/test/EnggDiffFittingViewMock.h
@@ -6,7 +6,7 @@
#include <gmock/gmock.h>
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
// This is a simple mock for the tomo interface view when using SCARF.
class MockEnggDiffFittingView
@@ -162,6 +162,6 @@ public:
void(const std::vector<std::string> &rows));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif // MANTID_CUSTOMINTERFACES_ENGGDIFFFITTINGVIEWMOCK_H
diff --git a/qt/scientific_interfaces/test/EnggDiffGSASFittingModelMock.h b/qt/scientific_interfaces/test/EnggDiffGSASFittingModelMock.h
index 0a00dbfafaf..f58d44a4c6e 100644
--- a/qt/scientific_interfaces/test/EnggDiffGSASFittingModelMock.h
+++ b/qt/scientific_interfaces/test/EnggDiffGSASFittingModelMock.h
@@ -6,7 +6,7 @@
#include <gmock/gmock.h>
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
using namespace MantidQt::CustomInterfaces;
@@ -44,6 +44,6 @@ public:
void(boost::shared_ptr<IEnggDiffGSASFittingObserver> observer));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif // MANTID_CUSTOM_INTERFACES_ENGGDIFFFITTINGMODELMOCK_H_
diff --git a/qt/scientific_interfaces/test/EnggDiffGSASFittingViewMock.h b/qt/scientific_interfaces/test/EnggDiffGSASFittingViewMock.h
index 09f5e555c7c..f3501fac9aa 100644
--- a/qt/scientific_interfaces/test/EnggDiffGSASFittingViewMock.h
+++ b/qt/scientific_interfaces/test/EnggDiffGSASFittingViewMock.h
@@ -8,7 +8,7 @@
using namespace MantidQt::CustomInterfaces;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockEnggDiffGSASFittingView : public IEnggDiffGSASFittingView {
@@ -72,6 +72,6 @@ public:
const std::string &warningDescription));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif // MANTID_CUSTOMINTERFACES_ENGGDIFFGSASFITTINGVIEWMOCK_H_
diff --git a/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetModelMock.h b/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetModelMock.h
index 4b7377fd6e0..90bc996e71b 100644
--- a/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetModelMock.h
+++ b/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetModelMock.h
@@ -8,7 +8,7 @@
using namespace MantidQt::CustomInterfaces;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockEnggDiffMultiRunFittingWidgetModel
: public IEnggDiffMultiRunFittingWidgetModel {
@@ -36,6 +36,6 @@ public:
MOCK_METHOD1(removeRun, void(const RunLabel &runLabel));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif // MANTIDQT_CUSTOMINTERFACES_ENGGDIFFMULTIRUNFITTINGWIDGETMODELMOCK_H_
diff --git a/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetPresenterMock.h b/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetPresenterMock.h
index 50337ef8718..5f5457f2874 100644
--- a/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetPresenterMock.h
+++ b/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetPresenterMock.h
@@ -9,7 +9,7 @@
using namespace MantidQt::CustomInterfaces;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockEnggDiffMultiRunFittingWidgetPresenter
: public IEnggDiffMultiRunFittingWidgetPresenter {
@@ -48,6 +48,6 @@ MockEnggDiffMultiRunFittingWidgetPresenter::getWidgetAdder() const {
return Mantid::Kernel::make_unique<FakeEnggDiffMultiRunFittingWidgetAdder>();
}
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif // MANTIDQT_CUSTOMINTERFACES_ENGGDIFFMULTIRUNFITTINGWIDGETPRESENTERMOCK_H_
diff --git a/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetViewMock.h b/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetViewMock.h
index 6539ebe625d..70d12470ded 100644
--- a/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetViewMock.h
+++ b/qt/scientific_interfaces/test/EnggDiffMultiRunFittingWidgetViewMock.h
@@ -8,7 +8,7 @@
using namespace MantidQt::CustomInterfaces;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
using namespace MantidQt::CustomInterfaces;
@@ -53,6 +53,6 @@ public:
MOCK_METHOD1(updateRunList, void(const std::vector<RunLabel> &runLabels));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif // MANTIDQT_CUSTOMINTERFACES_ENGGDIFFMULTIRUNFITTINGWIDGETVIEWMOCK_H_
diff --git a/qt/scientific_interfaces/test/EnggDiffractionParamMock.h b/qt/scientific_interfaces/test/EnggDiffractionParamMock.h
index d9fe717f15b..8ffa856047f 100644
--- a/qt/scientific_interfaces/test/EnggDiffractionParamMock.h
+++ b/qt/scientific_interfaces/test/EnggDiffractionParamMock.h
@@ -6,7 +6,7 @@
#include <gmock/gmock.h>
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
using namespace MantidQt::CustomInterfaces;
@@ -20,6 +20,6 @@ public:
std::string(const std::vector<RunLabel> &runLabels));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif // MANTIDQTCUSTOMINTERFACES_ENGGDIFFRACTION_IENGGDIFFRACTIONPARAMMOCK_H_
diff --git a/qt/scientific_interfaces/test/EnggDiffractionViewMock.h b/qt/scientific_interfaces/test/EnggDiffractionViewMock.h
index bf69da05d53..426384639c5 100644
--- a/qt/scientific_interfaces/test/EnggDiffractionViewMock.h
+++ b/qt/scientific_interfaces/test/EnggDiffractionViewMock.h
@@ -8,7 +8,7 @@
class QwtData;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
// This is a simple mock for the tomo interface view when using SCARF.
class MockEnggDiffractionView
@@ -185,6 +185,6 @@ public:
// virtual void updateTabsInstrument(const std::string & newInstrument) = 0;
MOCK_METHOD1(updateTabsInstrument, void(const std::string &newInstrument));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif // MANTID_CUSTOMINTERFACES_ENGGDIFFRACTIONVIEWMOCK_H
diff --git a/qt/scientific_interfaces/test/MuonAnalysisFitDataPresenterTest.h b/qt/scientific_interfaces/test/MuonAnalysisFitDataPresenterTest.h
index 98bfaf22589..2e7587cc88c 100644
--- a/qt/scientific_interfaces/test/MuonAnalysisFitDataPresenterTest.h
+++ b/qt/scientific_interfaces/test/MuonAnalysisFitDataPresenterTest.h
@@ -51,7 +51,7 @@ operator<<(std::basic_ostream<CharType, CharTrait> &out,
/// Mock data selector widget
class MockDataSelector : public IMuonFitDataSelector {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD0(getFilenames, QStringList());
MOCK_CONST_METHOD0(getStartTime, double());
@@ -75,13 +75,13 @@ public:
MOCK_METHOD1(setDatasetNames, void(const QStringList &));
MOCK_CONST_METHOD0(getDatasetName, QString());
MOCK_METHOD0(askUserWhetherToOverwrite, bool());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
/// Mock fit property browser
class MockFitBrowser : public IWorkspaceFitControl, public IMuonFitDataModel {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD1(setWorkspaceName, void(const QString &));
MOCK_METHOD1(setStartX, void(double));
MOCK_METHOD1(setEndX, void(double));
@@ -99,7 +99,7 @@ public:
void preFitChecksRequested(bool sequential) override {
UNUSED_ARG(sequential);
}
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
class MuonAnalysisFitDataPresenterTest : public CxxTest::TestSuite {
diff --git a/qt/scientific_interfaces/test/MuonAnalysisFitFunctionPresenterTest.h b/qt/scientific_interfaces/test/MuonAnalysisFitFunctionPresenterTest.h
index 467a458e9a6..390ce9f2118 100644
--- a/qt/scientific_interfaces/test/MuonAnalysisFitFunctionPresenterTest.h
+++ b/qt/scientific_interfaces/test/MuonAnalysisFitFunctionPresenterTest.h
@@ -25,7 +25,7 @@ public:
m_func =
Mantid::API::FunctionFactory::Instance().createFunction("Gaussian");
}
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD0(getFunctionString, QString());
Mantid::API::IFunction_sptr getGlobalFunction() override { return m_func; }
MOCK_METHOD0(functionStructureChanged, void());
@@ -46,7 +46,7 @@ public:
MOCK_METHOD3(setLocalParameterFixed, void(const QString &, int, bool));
MOCK_METHOD3(setLocalParameterTie, void(const QString &, int, QString));
MOCK_METHOD1(setCurrentDataset, void(int));
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
private:
Mantid::API::IFunction_sptr m_func;
@@ -55,7 +55,7 @@ private:
// Mock muon fit property browser
class MockFitFunctionControl : public IMuonFitFunctionModel {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD1(setFunction, void(const Mantid::API::IFunction_sptr));
MOCK_METHOD0(runFit, void());
MOCK_METHOD0(runSequentialFit, void());
@@ -70,7 +70,7 @@ public:
MOCK_METHOD0(doRemoveGuess, void());
MOCK_METHOD0(doPlotGuess, void());
MOCK_CONST_METHOD0(hasGuess, bool());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
class MuonAnalysisFitFunctionPresenterTest : public CxxTest::TestSuite {
diff --git a/qt/scientific_interfaces/test/ReflMeasureTransferStrategyTest.h b/qt/scientific_interfaces/test/ReflMeasureTransferStrategyTest.h
index 14c0d559a21..f1cb3027523 100644
--- a/qt/scientific_interfaces/test/ReflMeasureTransferStrategyTest.h
+++ b/qt/scientific_interfaces/test/ReflMeasureTransferStrategyTest.h
@@ -18,11 +18,11 @@ using namespace MantidQt::CustomInterfaces;
class MockReflMeasurementItemSource
: public MantidQt::CustomInterfaces::ReflMeasurementItemSource {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_CONST_METHOD2(obtain, MantidQt::CustomInterfaces::MeasurementItem(
const std::string &, const std::string &));
MOCK_CONST_METHOD0(clone, MockReflMeasurementItemSource *());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
class ReflMeasureTransferStrategyTest : public CxxTest::TestSuite {
diff --git a/qt/scientific_interfaces/test/ReflMockObjects.h b/qt/scientific_interfaces/test/ReflMockObjects.h
index 2e1e8beda45..38dfce2f47f 100644
--- a/qt/scientific_interfaces/test/ReflMockObjects.h
+++ b/qt/scientific_interfaces/test/ReflMockObjects.h
@@ -32,7 +32,7 @@ using namespace MantidQt::CustomInterfaces;
using namespace Mantid::API;
using namespace MantidQt::MantidWidgets::DataProcessor;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
/**** Models ****/
@@ -385,6 +385,6 @@ public:
virtual ~MockReflAsciiSaver() = default;
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif /*MANTID_CUSTOMINTERFACES_REFLMOCKOBJECTS_H*/
diff --git a/qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/MockObjects.h b/qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/MockObjects.h
index c1f69fd34f7..fa478e39529 100644
--- a/qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/MockObjects.h
+++ b/qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/MockObjects.h
@@ -29,7 +29,7 @@ const int ScaleCol = 7;
const int OptionsCol = 8;
const int HiddenOptionsCol = 9;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockDataProcessorView : public DataProcessorView {
public:
@@ -242,6 +242,6 @@ public:
};
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif /*MANTID_MANTIDWIDGETS_DATAPROCESSORVIEWMOCKOBJECTS_H*/
diff --git a/qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/ProgressableViewMockObject.h b/qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/ProgressableViewMockObject.h
index 3c151f809af..7c028b53a9b 100644
--- a/qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/ProgressableViewMockObject.h
+++ b/qt/widgets/common/inc/MantidQtWidgets/Common/DataProcessorUI/ProgressableViewMockObject.h
@@ -10,11 +10,11 @@ using namespace MantidQt::MantidWidgets::DataProcessor;
class MockProgressableView : public ProgressableView {
public:
- GCC_DIAG_OFF_SUGGEST_OVERRIDE
+ DIAG_OFF_SUGGEST_OVERRIDE
MOCK_METHOD1(setProgress, void(int));
MOCK_METHOD2(setProgressRange, void(int, int));
MOCK_METHOD0(clearProgress, void());
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
};
#endif /* MANTID_MANTIDWIDGETS_PROGRESSABLEVIEWMOCKOBJECT_H */
diff --git a/qt/widgets/common/inc/MantidQtWidgets/Common/WorkspacePresenter/WorkspaceDockMockObjects.h b/qt/widgets/common/inc/MantidQtWidgets/Common/WorkspacePresenter/WorkspaceDockMockObjects.h
index 2c7e37bfd83..48b60d7b115 100644
--- a/qt/widgets/common/inc/MantidQtWidgets/Common/WorkspacePresenter/WorkspaceDockMockObjects.h
+++ b/qt/widgets/common/inc/MantidQtWidgets/Common/WorkspacePresenter/WorkspaceDockMockObjects.h
@@ -12,7 +12,7 @@
using namespace MantidQt::MantidWidgets;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockMantidDisplayBase;
@@ -103,6 +103,6 @@ public:
MOCK_METHOD1(notifyFromWorkspaceProvider, void(Flag flag));
};
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
-#endif // MANTIDQT_MANTIDWIDGETS_WORKSPACEDOCKMOCKOBJECTS_H
\ No newline at end of file
+#endif // MANTIDQT_MANTIDWIDGETS_WORKSPACEDOCKMOCKOBJECTS_H
diff --git a/qt/widgets/common/test/ProjectSaveMockObjects.h b/qt/widgets/common/test/ProjectSaveMockObjects.h
index bfda855a056..d9b293c272a 100644
--- a/qt/widgets/common/test/ProjectSaveMockObjects.h
+++ b/qt/widgets/common/test/ProjectSaveMockObjects.h
@@ -10,7 +10,7 @@
using namespace MantidQt::API;
using namespace MantidQt::MantidWidgets;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class MockProjectSaveView : public IProjectSaveView {
public:
diff --git a/qt/widgets/legacyqwt/test/SignalRangeTest.h b/qt/widgets/legacyqwt/test/SignalRangeTest.h
index fec9a6fcf5b..5f295ef58cb 100644
--- a/qt/widgets/legacyqwt/test/SignalRangeTest.h
+++ b/qt/widgets/legacyqwt/test/SignalRangeTest.h
@@ -12,7 +12,7 @@
#include "MantidAPI/IMDIterator.h"
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
class SignalRangeTest : public CxxTest::TestSuite {
private:
@@ -86,7 +86,7 @@ private:
MOCK_CONST_METHOD0(getLinearIndex, size_t());
MOCK_CONST_METHOD1(isWithinBounds, bool(size_t));
};
- GCC_DIAG_ON_SUGGEST_OVERRIDE
+ DIAG_ON_SUGGEST_OVERRIDE
class NormalizableMockIterator : public MockMDIterator {
public:
Mantid::signal_t getNormalizedSignal() const override {
diff --git a/qt/widgets/sliceviewer/test/MockObjects.h b/qt/widgets/sliceviewer/test/MockObjects.h
index 239adff69ef..25c8d27b641 100644
--- a/qt/widgets/sliceviewer/test/MockObjects.h
+++ b/qt/widgets/sliceviewer/test/MockObjects.h
@@ -25,7 +25,7 @@ using namespace Mantid::Geometry;
using namespace Mantid;
using boost::regex;
-GCC_DIAG_OFF_SUGGEST_OVERRIDE
+DIAG_OFF_SUGGEST_OVERRIDE
namespace {
/*------------------------------------------------------------
@@ -197,6 +197,6 @@ public:
};
}
-GCC_DIAG_ON_SUGGEST_OVERRIDE
+DIAG_ON_SUGGEST_OVERRIDE
#endif
--
GitLab