Commit 9a03fe0f authored by Gagik Vardanyan's avatar Gagik Vardanyan
Browse files

unit and system tests, release note

parent 23c69c2d
......@@ -987,6 +987,8 @@ double LoadILLReflectometry::sourceSampleDistance() const {
pairSeparation = doubleFromRun("Distance.ChopperGap") / 100; // in [m]
m_localWorkspace->mutableRun().addProperty("Distance.ChopperGap",
pairSeparation, "meter", true);
m_localWorkspace->mutableRun().addProperty(
"VirtualChopper.dist_chop_samp", pairCentre, "meter", true);
} catch (std::runtime_error &) {
try {
pairCentre = mmToMeter(doubleFromRun(
......
......@@ -240,7 +240,7 @@ public:
const auto chopperCentre =
run.getPropertyValueAsType<double>("VirtualChopper.dist_chop_samp");
const auto chopperSeparation =
run.getPropertyValueAsType<double>("Distance.ChopperGap") / 100.;
run.getPropertyValueAsType<double>("Distance.ChopperGap");
const auto sourceSample = chopperCentre - 0.5 * chopperSeparation;
const auto &spectrumInfo = output->spectrumInfo();
const auto l1 = spectrumInfo.l1();
......@@ -254,8 +254,8 @@ public:
TS_ASSERT_EQUALS(sourcePos.Y(), 0.)
TS_ASSERT_EQUALS(sourcePos.Z(), -sourceSample)
TS_ASSERT_EQUALS(run.getProperty("VirtualChopper.dist_chop_samp")->units(),
"")
TS_ASSERT_EQUALS(run.getProperty("Distance.ChopperGap")->units(), "")
"meter")
TS_ASSERT_EQUALS(run.getProperty("Distance.ChopperGap")->units(), "meter")
AnalysisDataService::Instance().clear();
}
......@@ -684,7 +684,7 @@ public:
} else {
v8 = loader.doubleFromRun("VirtualChopper.dist_chop_samp");
TS_ASSERT_EQUALS(
run.getProperty("VirtualChopper.dist_chop_samp")->units(), "")
run.getProperty("VirtualChopper.dist_chop_samp")->units(), "meter")
}
TS_ASSERT_EQUALS(v7, v8)
AnalysisDataService::Instance().clear();
......
559cab02caed2efc456b0a8bc4164c94
f2dd13cea349789ecede50a8a9f21224
736676e82637c4bce8523fc75f23b88b
1cc0721828b6ac2a3b6fab0f4b937456
......@@ -9,6 +9,20 @@ Reflectometry Changes
putting new features at the top of the section, followed by
improvements, followed by bug fixes.
Algorithms
##########
Improvements
------------
- Sample waviness term is removed from resolution calculation in incoherent mode in :ref:`ReflectometryMomentumTransfer <algm-ReflectometryMomentumTransfer>`.
- Flag to enable / disable apply scaling factor from `ScalingFactorFile`, called `ApplyScalingFactor`, added to :ref:`algm-LiquidsReflectometryReduction`.
Bug fixes
---------
- :ref:`LoadILLReflectometry <algm-LoadILLReflectometry>` has been fixed to update the sample logs of chopper gap and chopper position with correct units regardless the wrong setting in nexus files.
ISIS Reflectometry Interface
############################
......@@ -46,13 +60,4 @@ Bug fixes
- A bug has been fixed where creating a new Batch would result in the Experiment/Instrument settings of all batches being reset to their defaults.
- A bug has been fixed where clicking Restore Defaults on an Experiment/Instrument tab would cause all Experiment and Instrument tabs in every batch to be reset to defaults. Now, only the tab where you click Restore Defaults is changed.
Algorithms
##########
Improvements
------------
- Flag to enable / disable apply scaling factor from `ScalingFactorFile`, called `ApplyScalingFactor`, added to :ref:`algm-LiquidsReflectometryReduction`.
- Sample waviness term is removed from resolution calculation in incoherent mode in :ref:`ReflectometryMomentumTransfer <algm-ReflectometryMomentumTransfer>`.
:ref:`Release 5.1.0 <v5.1.0>`
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment