From 8d656ec6174ac8bd62689fb8141c7aa250b09628 Mon Sep 17 00:00:00 2001 From: Owen Arnold <owen.arnold@stfc.ac.uk> Date: Fri, 9 Mar 2012 10:57:05 +0000 Subject: [PATCH] refs #4932. Fix GCC error --- .../ParaViewWidgets/QtWidgets/DimensionWidget.cpp | 2 +- .../ParaViewWidgets/QtWidgets/LowHighStepInputWidget.cpp | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Code/Mantid/Vates/ParaviewPlugins/ParaViewWidgets/QtWidgets/DimensionWidget.cpp b/Code/Mantid/Vates/ParaviewPlugins/ParaViewWidgets/QtWidgets/DimensionWidget.cpp index e89d05b4ce5..0d2b755ed56 100644 --- a/Code/Mantid/Vates/ParaviewPlugins/ParaViewWidgets/QtWidgets/DimensionWidget.cpp +++ b/Code/Mantid/Vates/ParaviewPlugins/ParaViewWidgets/QtWidgets/DimensionWidget.cpp @@ -23,7 +23,7 @@ Constructor */ DimensionWidget::DimensionWidget(Mantid::VATES::BinDisplay binDisplay) { - //TODO: The following cascade can be refactored out. + //Prefer dependency injection to the following conditional statements. if(binDisplay == Mantid::VATES::Simple) { m_binWidget = new SimpleBinInputWidget; diff --git a/Code/Mantid/Vates/ParaviewPlugins/ParaViewWidgets/QtWidgets/LowHighStepInputWidget.cpp b/Code/Mantid/Vates/ParaviewPlugins/ParaViewWidgets/QtWidgets/LowHighStepInputWidget.cpp index 0af1f6ae277..38d995ed1ef 100644 --- a/Code/Mantid/Vates/ParaviewPlugins/ParaViewWidgets/QtWidgets/LowHighStepInputWidget.cpp +++ b/Code/Mantid/Vates/ParaviewPlugins/ParaViewWidgets/QtWidgets/LowHighStepInputWidget.cpp @@ -37,8 +37,7 @@ LowHighStepInputWidget::LowHighStepInputWidget() connect(m_step, SIGNAL(editingFinished()), this, SLOT(nBinsListener())); - QDoubleValidator* stepValidator = new QDoubleValidator; - stepValidator->setBottom(0); + QDoubleValidator* stepValidator = new QDoubleValidator(0, 10000, 5, this); m_step->setValidator(stepValidator); QHBoxLayout* layout = new QHBoxLayout; -- GitLab