filter rotation prop for only rect and ellipse

qt/widgets/instrumentview/inc/MantidQtWidgets/InstrumentView/InstrumentWidgetMaskTab.h

@@ -146,6 +146,7 @@ private:
   void loadMaskViewFromProject(const std::string &name);
   /// Run the LoadMask algorithm to get a MaskWorkspace
   std::shared_ptr<Mantid::API::MatrixWorkspace> loadMask(const std::string &fileName);
+  bool isRotationSupported();
 
 protected:
   /// Is it used?

qt/widgets/instrumentview/inc/MantidQtWidgets/InstrumentView/ProjectionSurface.h

@@ -181,6 +181,10 @@ public:
     m_maskShapes.setCurrentBoundingRotation(rotation);
   }
 
+  std::string getCurrentShapeType() const {
+    return m_maskShapes.getCurrentShapeType();
+  }
+
   /// Initialize interactive shape creation.
   /// @param type :: Type of the shape. For available types see code of
   /// Shape2DCollection::createShape(const QString& type,int x,int y) const

qt/widgets/instrumentview/inc/MantidQtWidgets/InstrumentView/Shape2DCollection.h

@@ -73,6 +73,7 @@ public:
   void setCurrentBoundingRect(const RectF &rect);
   double getCurrentBoundingRotation() const;
   void setCurrentBoundingRotation(const double rotation);
+  std::string getCurrentShapeType() const;
   // double properties
   QStringList getCurrentDoubleNames() const;
   double getCurrentDouble(const QString &prop) const;

qt/widgets/instrumentview/src/InstrumentWidgetMaskTab.cpp

@@ -623,12 +623,16 @@ void InstrumentWidgetMaskTab::setProperties() {
   m_top = addDoubleProperty("top");
   m_right = addDoubleProperty("right");
   m_bottom = addDoubleProperty("bottom");
-  m_rotation = addDoubleProperty("rotation");
+
   boundingRectGroup->addSubProperty(m_left);
   boundingRectGroup->addSubProperty(m_top);
   boundingRectGroup->addSubProperty(m_right);
   boundingRectGroup->addSubProperty(m_bottom);
-  boundingRectGroup->addSubProperty(m_rotation);
+  
+  if(isRotationSupported()) {
+    m_rotation = addDoubleProperty("rotation");
+    boundingRectGroup->addSubProperty(m_rotation);
+  }
 
   // point properties
   QStringList pointProperties = m_instrWidget->getSurface()->getCurrentPointNames();
@@ -653,7 +657,8 @@ void InstrumentWidgetMaskTab::setProperties() {
   }
 
   //rotation property
-  m_doubleManager->setValue(m_rotation, m_instrWidget->getSurface()->getCurrentBoundingRotation());
+  if(isRotationSupported())
+    m_doubleManager->setValue(m_rotation, m_instrWidget->getSurface()->getCurrentBoundingRotation());
 
   shapeChanged();
 }
@@ -676,7 +681,9 @@ void InstrumentWidgetMaskTab::doubleChanged(QtProperty *prop) {
 
     QRectF rect(QPointF(x0, y0), QPointF(x1, y1));
     m_instrWidget->getSurface()->setCurrentBoundingRect(RectF(rect));
-    m_instrWidget->getSurface()->setCurrentBoundingRotation(m_doubleManager->value(m_rotation));
+
+    if(isRotationSupported())
+        m_instrWidget->getSurface()->setCurrentBoundingRotation(m_doubleManager->value(m_rotation));
 
   } else {
     QString name = m_doublePropertyMap[prop];
@@ -1429,4 +1436,9 @@ bool InstrumentWidgetMaskTab::saveMaskViewToProject(const std::string &name, con
   return true;
 }
 
+bool InstrumentWidgetMaskTab::isRotationSupported(){
+  const auto shapeType = m_instrWidget->getSurface()->getCurrentShapeType();
+  return shapeType == "rectangle" || shapeType == "ellipse";
+}
+
 } // namespace MantidQt::MantidWidgets

qt/widgets/instrumentview/src/Shape2DCollection.cpp

@@ -578,6 +578,13 @@ void Shape2DCollection::clear() {
   emit shapesDeselected();
 }
 
+std::string Shape2DCollection::getCurrentShapeType() const {
+  if (m_currentShape) {
+    return m_currentShape->type();
+  }
+  return "none";
+}
+
 QStringList Shape2DCollection::getCurrentDoubleNames() const {
   if (m_currentShape) {
     return m_currentShape->getDoubleNames();