From 844f163771f3722c75c2718b632b35a7db28d2bf Mon Sep 17 00:00:00 2001
From: Lamar Moore <lamar.moore@stfc.ac.uk>
Date: Wed, 19 Sep 2018 09:54:01 +0100
Subject: [PATCH] fix cppcheck errors #23073
---
qt/widgets/instrumentview/src/BankTextureBuilder.cpp | 2 +-
qt/widgets/instrumentview/src/PanelsSurface.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/qt/widgets/instrumentview/src/BankTextureBuilder.cpp b/qt/widgets/instrumentview/src/BankTextureBuilder.cpp
index 5d15e340ea9..4cf5c38052a 100644
--- a/qt/widgets/instrumentview/src/BankTextureBuilder.cpp
+++ b/qt/widgets/instrumentview/src/BankTextureBuilder.cpp
@@ -65,7 +65,7 @@ void addColorsToTopAndBottomTextures(
}
}
-void upload2DTexture(const std::pair<size_t, size_t> textSizes,
+void upload2DTexture(const std::pair<size_t, size_t> &textSizes,
GLuint &textureID, std::vector<char> &texture) {
auto w = textSizes.first;
auto h = textSizes.second;
diff --git a/qt/widgets/instrumentview/src/PanelsSurface.cpp b/qt/widgets/instrumentview/src/PanelsSurface.cpp
index c4aeb193e4e..defd0e34f16 100644
--- a/qt/widgets/instrumentview/src/PanelsSurface.cpp
+++ b/qt/widgets/instrumentview/src/PanelsSurface.cpp
@@ -310,7 +310,7 @@ void PanelsSurface::addFlatBankOfDetectors(
QVector<QPointF> vert;
vert << p1 << p0;
info->polygon = QPolygonF(vert);
- PRAGMA_OMP(parallel for)
+#pragma omp parallel for
for (int i = 0; i < static_cast<int>(detectors.size()); ++i) {
auto detector = detectors[i];
addDetector(detector, pos0, index, info->rotation);
--
GitLab