diff --git a/Framework/Algorithms/test/MonteCarloTesting.h b/Framework/Algorithms/test/MonteCarloTesting.h index 26dd5a02aeda6ac98c3b6dd72c7c9c2e69b4d81b..e47f65dbd1ba36e3e7072aeaca20bd735b1b8f57 100644 --- a/Framework/Algorithms/test/MonteCarloTesting.h +++ b/Framework/Algorithms/test/MonteCarloTesting.h @@ -8,6 +8,7 @@ #include "MantidKernel/Material.h" #include "MantidKernel/PseudoRandomNumberGenerator.h" #include "MantidKernel/WarningSuppressions.h" +#include "MantidKernel/make_unique.h" #include "MantidTestHelpers/ComponentCreationHelper.h" #include <gmock/gmock.h> diff --git a/Framework/DataHandling/test/SaveParameterFileTest.h b/Framework/DataHandling/test/SaveParameterFileTest.h index bd4fd8da473cc7c687f50dbcc790a67dce7d4b80..8f201b814036b5cc29862adbf70d9bacef29d4ea 100644 --- a/Framework/DataHandling/test/SaveParameterFileTest.h +++ b/Framework/DataHandling/test/SaveParameterFileTest.h @@ -15,6 +15,7 @@ #include "MantidGeometry/IDetector.h" #include "MantidGeometry/Instrument.h" #include "MantidGeometry/Instrument/Component.h" +#include "MantidGeometry/Instrument/ParameterFactory.h" #include "MantidKernel/Exception.h" #include "MantidKernel/StringTokenizer.h" #include "MantidTestHelpers/ScopedFileHelper.h" diff --git a/Framework/DataObjects/src/MDBoxFlatTree.cpp b/Framework/DataObjects/src/MDBoxFlatTree.cpp index 8d39771ffdf12b0bf0329fc4407edbeba5128ca5..7a9232e17ff28a54448c6285e29f13da33762e64 100644 --- a/Framework/DataObjects/src/MDBoxFlatTree.cpp +++ b/Framework/DataObjects/src/MDBoxFlatTree.cpp @@ -4,6 +4,7 @@ #include "MantidAPI/FileBackedExperimentInfo.h" #include "MantidAPI/WorkspaceHistory.h" #include "MantidGeometry/Instrument.h" +#include "MantidKernel/Logger.h" #include "MantidKernel/Strings.h" #include <Poco/File.h> diff --git a/Framework/Geometry/inc/MantidGeometry/Instrument/ParameterMap.h b/Framework/Geometry/inc/MantidGeometry/Instrument/ParameterMap.h index 9ffebaf72b0c3edc51b28a3b1e1960cac4c0be72..83bc80a18e32a811441c15afd172a0afe076257c 100644 --- a/Framework/Geometry/inc/MantidGeometry/Instrument/ParameterMap.h +++ b/Framework/Geometry/inc/MantidGeometry/Instrument/ParameterMap.h @@ -6,7 +6,6 @@ #include "MantidGeometry/IDetector.h" #include "MantidGeometry/IDTypes.h" //For specnum_t #include "MantidGeometry/Instrument/Parameter.h" -#include "MantidGeometry/Instrument/ParameterFactory.h" #include "tbb/concurrent_unordered_map.h" @@ -142,7 +141,7 @@ public: void add(const std::string &type, const IComponent *comp, const std::string &name, const T &value, const std::string *const pDescription = nullptr) { - auto param = ParameterFactory::create(type, name); + auto param = create(type, name); auto typedParam = boost::dynamic_pointer_cast<ParameterType<T>>(param); assert(typedParam); // If not true the factory has created the wrong type typedParam->setValue(value); @@ -341,6 +340,9 @@ public: pmap_cit end() const { return m_map.end(); } private: + boost::shared_ptr<Parameter> create(const std::string &className, + const std::string &name) const; + /// Assignment operator ParameterMap &operator=(ParameterMap *rhs); /// internal function to get position of the parameter in the parameter map diff --git a/Framework/Geometry/src/Instrument.cpp b/Framework/Geometry/src/Instrument.cpp index ed3f35541097fb048e36d1e970bd513901c2077d..96afd7b431f093a52c285e72a5e348710544af7c 100644 --- a/Framework/Geometry/src/Instrument.cpp +++ b/Framework/Geometry/src/Instrument.cpp @@ -4,6 +4,7 @@ #include "MantidGeometry/Instrument/ReferenceFrame.h" #include "MantidGeometry/Instrument/RectangularDetector.h" #include "MantidKernel/Exception.h" +#include "MantidKernel/Logger.h" #include "MantidKernel/PhysicalConstants.h" #include <boost/make_shared.hpp> diff --git a/Framework/Geometry/src/Instrument/Detector.cpp b/Framework/Geometry/src/Instrument/Detector.cpp index ce6d6b477919482b56129096303b37be9cc25a4d..bb0fd7612c84f86bcc8cf657d268ad9e5da025b9 100644 --- a/Framework/Geometry/src/Instrument/Detector.cpp +++ b/Framework/Geometry/src/Instrument/Detector.cpp @@ -1,5 +1,6 @@ #include "MantidGeometry/Instrument/Detector.h" #include "MantidGeometry/Instrument/ParameterMap.h" +#include "MantidKernel/Logger.h" namespace Mantid { namespace Geometry { diff --git a/Framework/Geometry/src/Instrument/DetectorGroup.cpp b/Framework/Geometry/src/Instrument/DetectorGroup.cpp index abc36ded770f0b95735c53ce7becf958eee74473..7cfc6b7dc5872ee4ae4aa5462b9749d72f40fb0a 100644 --- a/Framework/Geometry/src/Instrument/DetectorGroup.cpp +++ b/Framework/Geometry/src/Instrument/DetectorGroup.cpp @@ -1,9 +1,7 @@ -//---------------------------------------------------------------------- -// Includes -//---------------------------------------------------------------------- #include "MantidGeometry/Instrument/DetectorGroup.h" #include "MantidGeometry/Objects/BoundingBox.h" #include "MantidKernel/Exception.h" +#include "MantidKernel/Logger.h" #include "MantidKernel/Material.h" namespace Mantid { diff --git a/Framework/Geometry/src/Instrument/ParameterMap.cpp b/Framework/Geometry/src/Instrument/ParameterMap.cpp index d79e376fe4d51f2e28c774e573531028b4371feb..1aac5cc4f0f719f616b649ddd76d810d4ad70bc4 100644 --- a/Framework/Geometry/src/Instrument/ParameterMap.cpp +++ b/Framework/Geometry/src/Instrument/ParameterMap.cpp @@ -4,6 +4,7 @@ #include "MantidKernel/Cache.h" #include "MantidKernel/MultiThreaded.h" #include "MantidGeometry/Instrument.h" +#include "MantidGeometry/Instrument/ParameterFactory.h" #include <cstring> #include <boost/algorithm/string.hpp> @@ -1101,5 +1102,12 @@ void ParameterMap::addParameterFilename(const std::string &filename) { m_parameterFileNames.push_back(filename); } + /// Wrapper for ParameterFactory::create to avoid include in header +boost::shared_ptr<Parameter> +ParameterMap::create(const std::string &className, + const std::string &name) const { + return ParameterFactory::create(className, name); +} + } // Namespace Geometry } // Namespace Mantid diff --git a/Framework/Geometry/src/Rendering/GluGeometryHandler.cpp b/Framework/Geometry/src/Rendering/GluGeometryHandler.cpp index 2014b93e034fabf3724496ec28de44b2f24eb7f3..3ecd3e61fc9033bc6315ed5630e7dde6852ece11 100644 --- a/Framework/Geometry/src/Rendering/GluGeometryHandler.cpp +++ b/Framework/Geometry/src/Rendering/GluGeometryHandler.cpp @@ -3,6 +3,7 @@ #include "MantidGeometry/Objects/Object.h" #include "MantidGeometry/Rendering/GeometryHandler.h" #include "MantidGeometry/Rendering/GluGeometryRenderer.h" +#include "MantidKernel/make_unique.h" #include <boost/make_shared.hpp> diff --git a/Framework/Geometry/test/ParameterMapTest.h b/Framework/Geometry/test/ParameterMapTest.h index 96bc3e32a4ca05eb4aea0f3f4c1f91609ac0891f..4b3a053d158009296e6fe6e3ec95f8a642f8a5ab 100644 --- a/Framework/Geometry/test/ParameterMapTest.h +++ b/Framework/Geometry/test/ParameterMapTest.h @@ -2,6 +2,7 @@ #define PARAMETERMAPTEST_H_ #include "MantidGeometry/Instrument/Parameter.h" +#include "MantidGeometry/Instrument/ParameterFactory.h" #include "MantidGeometry/Instrument/ParameterMap.h" #include "MantidGeometry/Instrument/Detector.h" #include "MantidTestHelpers/ComponentCreationHelper.h" diff --git a/Framework/Geometry/test/SampleEnvironmentFactoryTest.h b/Framework/Geometry/test/SampleEnvironmentFactoryTest.h index 06290556258504d693be53760501fab00137dc23..65a6b4f07ce912d43225cf56a8b6b68a6ccec1eb 100644 --- a/Framework/Geometry/test/SampleEnvironmentFactoryTest.h +++ b/Framework/Geometry/test/SampleEnvironmentFactoryTest.h @@ -5,6 +5,7 @@ #include "MantidGeometry/Instrument/SampleEnvironmentFactory.h" #include "MantidGeometry/Instrument/Container.h" #include "MantidGeometry/Objects/ShapeFactory.h" +#include "MantidKernel/make_unique.h" #include "MantidTestHelpers/ComponentCreationHelper.h" diff --git a/Framework/SINQ/src/PoldiUtilities/PoldiAutoCorrelationCore.cpp b/Framework/SINQ/src/PoldiUtilities/PoldiAutoCorrelationCore.cpp index bd62179cc946e391f07a078d7ef8fecff7f7961c..faebce7e8a9fd8d560de60c9cda2f21b30c0a955 100644 --- a/Framework/SINQ/src/PoldiUtilities/PoldiAutoCorrelationCore.cpp +++ b/Framework/SINQ/src/PoldiUtilities/PoldiAutoCorrelationCore.cpp @@ -6,6 +6,7 @@ #include "boost/bind.hpp" #include "MantidAPI/Axis.h" #include "MantidAPI/WorkspaceFactory.h" +#include "MantidKernel/Logger.h" #include "MantidKernel/MultiThreaded.h" #include "MantidSINQ/PoldiUtilities/PoldiDGrid.h" diff --git a/Framework/SINQ/src/PoldiUtilities/PoldiResidualCorrelationCore.cpp b/Framework/SINQ/src/PoldiUtilities/PoldiResidualCorrelationCore.cpp index 08e4c82fdc7c58dedf1d4ffe42c8c78eac105c14..5fa777bf2511044f8a9bbdd60962ce3a83cdb995 100644 --- a/Framework/SINQ/src/PoldiUtilities/PoldiResidualCorrelationCore.cpp +++ b/Framework/SINQ/src/PoldiUtilities/PoldiResidualCorrelationCore.cpp @@ -1,4 +1,5 @@ #include "MantidSINQ/PoldiUtilities/PoldiResidualCorrelationCore.h" +#include "MantidKernel/Logger.h" #include <algorithm> #include <numeric> diff --git a/Vates/VatesAPI/src/MetaDataExtractorUtils.cpp b/Vates/VatesAPI/src/MetaDataExtractorUtils.cpp index 5d520a305637464ca464502c7f0ed4e533f00b64..c542bd383111aabb4012d4f2faf6095e1e34df09 100644 --- a/Vates/VatesAPI/src/MetaDataExtractorUtils.cpp +++ b/Vates/VatesAPI/src/MetaDataExtractorUtils.cpp @@ -7,6 +7,7 @@ #include "MantidAPI/IMDWorkspace.h" #include "MantidGeometry/Instrument.h" #include "MantidKernel/Logger.h" +#include "MantidKernel/MultiThreaded.h" #include "boost/pointer_cast.hpp" #include <cfloat>