From 66cb0570d0334ace408f39c9581f58d5637f9674 Mon Sep 17 00:00:00 2001
From: Gemma Guest <gemma.guest@stfc.ac.uk>
Date: Mon, 3 Jul 2017 12:33:56 +0100
Subject: [PATCH] Re #19773 Revert cppcheck memory leak fix
This will be investigated further as part of issue #19952.
---
Framework/ICat/src/CatalogDownloadDataFiles.cpp | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Framework/ICat/src/CatalogDownloadDataFiles.cpp b/Framework/ICat/src/CatalogDownloadDataFiles.cpp
index 3016bf20468..ecebbac206b 100644
--- a/Framework/ICat/src/CatalogDownloadDataFiles.cpp
+++ b/Framework/ICat/src/CatalogDownloadDataFiles.cpp
@@ -164,8 +164,10 @@ std::string CatalogDownloadDataFiles::doDownloadandSavetoLocalDrive(
nullptr, certificateHandler, context);
// Session takes ownership of socket
- Poco::Net::SecureStreamSocket socket(context);
- Poco::Net::HTTPSClientSession session(socket);
+ Poco::Net::SecureStreamSocket *socket =
+ new Poco::Net::SecureStreamSocket(context);
+ Poco::Net::HTTPSClientSession session(*socket);
+ socket = nullptr;
session.setHost(uri.getHost());
session.setPort(uri.getPort());
--
GitLab