From 59a2027e84d80adefa3964607cf645c3ed873f48 Mon Sep 17 00:00:00 2001
From: Martyn Gigg <martyn.gigg@gmail.com>
Date: Fri, 5 Jan 2018 09:12:48 +0000
Subject: [PATCH] Remove support for updating the IPython banner
It's not required for now and newer versions of Jupyter work quite
differently.
Refs #21251
---
qt/python/mantidqt/widgets/ipythonconsole/widget.py | 10 +---------
qt/python/mantidqt/widgets/test/test_ipythonconsole.py | 5 +----
2 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/qt/python/mantidqt/widgets/ipythonconsole/widget.py b/qt/python/mantidqt/widgets/ipythonconsole/widget.py
index 7d8c44a628c..703e91fe27d 100644
--- a/qt/python/mantidqt/widgets/ipythonconsole/widget.py
+++ b/qt/python/mantidqt/widgets/ipythonconsole/widget.py
@@ -42,12 +42,8 @@ class InProcessIPythonConsole(RichIPythonWidget):
"""
A constructor matching that of RichIPythonWidget
:param args: Positional arguments passed directly to RichIPythonWidget
- :param kwargs: Keyword arguments. The following are used by this
- widget:
- - banner_extra: An additinal string to append to the default banner
+ :param kwargs: Keyword arguments passed directly to RichIPythonWidget
"""
- # remove our arguments
- banner_extra = kwargs.pop("banner_extra", "")
super(InProcessIPythonConsole, self).__init__(*args, **kwargs)
# create an in-process kernel
@@ -60,10 +56,6 @@ class InProcessIPythonConsole(RichIPythonWidget):
shell = kernel.shell
shell.run_code = async_wrapper(shell.run_code, shell)
- # custom banner
- if banner_extra:
- self.banner += "\n" + banner_extra
-
# attach channels and start kenel
kernel_client = kernel_manager.client()
kernel_client.start_channels()
diff --git a/qt/python/mantidqt/widgets/test/test_ipythonconsole.py b/qt/python/mantidqt/widgets/test/test_ipythonconsole.py
index 3ba6575b90b..c985945b6cc 100644
--- a/qt/python/mantidqt/widgets/test/test_ipythonconsole.py
+++ b/qt/python/mantidqt/widgets/test/test_ipythonconsole.py
@@ -33,11 +33,8 @@ class InProcessIPythonConsoleTest(unittest.TestCase):
widget = InProcessIPythonConsole()
self.assertTrue(hasattr(widget, "kernel_manager"))
self.assertTrue(hasattr(widget, "kernel_client"))
+ self.assertTrue(len(widget.banner) > 0)
- def test_banner_extra_updates_banner(self):
- widget = InProcessIPythonConsole(banner_extra="foo")
- self.assertTrue(widget.banner.endswith("foo"))
- self.assertTrue(widget.banner.startswith("Python"))
if __name__ == '__main__':
--
GitLab