From 47ef014c5418c07fc81ad7b2911850f5dc8a8a2c Mon Sep 17 00:00:00 2001
From: Samuel Jones <samjones714@gmail.com>
Date: Wed, 14 Nov 2018 09:01:08 +0000
Subject: [PATCH] Re #23304 Reduce copying of Shared_ptr
---
Framework/API/src/Algorithm.cpp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Framework/API/src/Algorithm.cpp b/Framework/API/src/Algorithm.cpp
index 18301fac783..7bf4718f14e 100644
--- a/Framework/API/src/Algorithm.cpp
+++ b/Framework/API/src/Algorithm.cpp
@@ -1380,14 +1380,14 @@ bool Algorithm::doCallProcessGroups(
// We need to find the workspaces to add the history to.
if (outputWorkspaces.size() == 0 && inputWorkspaces.size() == 0) {
- for (auto ws : m_groupWorkspaces) {
- outputWorkspaces.emplace_back(ws);
- }
+ outputWorkspaces.insert(outputWorkspaces.end(),
+ m_groupWorkspaces.begin(),
+ m_groupWorkspaces.end());
} else if (outputWorkspaces.size() == 0) {
outputWorkspaces = inputWorkspaces;
}
- for (auto outputWorkspace : outputWorkspaces) {
+ for (const auto &outputWorkspace : outputWorkspaces) {
auto outputGroupWS =
boost::dynamic_pointer_cast<WorkspaceGroup>(outputWorkspace);
if (outputGroupWS) {
--
GitLab