From 3aa7e69e9d5eeadd73ee49e5591b29db6149a953 Mon Sep 17 00:00:00 2001
From: Brendan Sullivan <sullivanbt@ornl.gov>
Date: Thu, 20 Dec 2018 08:56:47 -0500
Subject: [PATCH] Re #24329 make reviewer suggested changes

---
 .../inc/MantidCrystal/SetCrystalLocation.h       | 16 ++++++++--------
 Framework/Crystal/src/SetCrystalLocation.cpp     |  6 +++---
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/Framework/Crystal/inc/MantidCrystal/SetCrystalLocation.h b/Framework/Crystal/inc/MantidCrystal/SetCrystalLocation.h
index 310b218375c..925d165201c 100644
--- a/Framework/Crystal/inc/MantidCrystal/SetCrystalLocation.h
+++ b/Framework/Crystal/inc/MantidCrystal/SetCrystalLocation.h
@@ -1,6 +1,6 @@
 // Mantid Repository : https://github.com/mantidproject/mantid
 //
-// Copyright &copy; 2012 ISIS Rutherford Appleton Laboratory UKRI,
+// Copyright &copy; 2018 ISIS Rutherford Appleton Laboratory UKRI,
 //     NScD Oak Ridge National Laboratory, European Spallation Source
 //     & Institut Laue - Langevin
 // SPDX - License - Identifier: GPL - 3.0 +
@@ -23,13 +23,10 @@ namespace Crystal {
 /** SetCrystalLocation
 
 Description:
-This algorithm basically indexes peaks with the crystal orientation matrix
-stored in the peaks workspace.
-The optimization is on the goniometer settings for the runs in the peaks
-workspace and also the sample
-orientation .
-@author Ruth Mikkelson, SNS,ORNL
-@date 01/26/2013
+This algorithm provides a convenient interface to sets the 
+sample position of an events workspace.
+@author Brendan Sullivan, SNS,ORNL
+@date Dec 20 2018
 */
 class DLLExport SetCrystalLocation : public API::Algorithm {
 public:
@@ -39,6 +36,9 @@ public:
     return "This algorithm sets the sample location of the "
            "input event workspace.";
   }
+  const std::vector<std::string> seeAlso() const override {
+    return {"OptimizeCrystalPlacement"};
+  }
 
   int version() const override { return 1; };
 
diff --git a/Framework/Crystal/src/SetCrystalLocation.cpp b/Framework/Crystal/src/SetCrystalLocation.cpp
index e3ed093a869..86568da261d 100644
--- a/Framework/Crystal/src/SetCrystalLocation.cpp
+++ b/Framework/Crystal/src/SetCrystalLocation.cpp
@@ -60,9 +60,9 @@ void SetCrystalLocation::init() {
 void SetCrystalLocation::exec() {
   EventWorkspace_sptr events = getProperty("InputWorkspace");
   EventWorkspace_sptr outEvents = getProperty("OutputWorkspace");
-  double newX = getProperty("NewX");
-  double newY = getProperty("NewY");
-  double newZ = getProperty("NewZ");
+  const double newX = getProperty("NewX");
+  const double newY = getProperty("NewY");
+  const double newZ = getProperty("NewZ");
   V3D newSamplePos = V3D(newX, newY, newZ);
   if (events != outEvents) {
     outEvents = events->clone();
-- 
GitLab