From 05ea2eb2f6a481d0305f59acae0157bf857b070e Mon Sep 17 00:00:00 2001
From: Owen Arnold <owen.arnold@stfc.ac.uk>
Date: Mon, 21 Jan 2019 13:44:38 +0000
Subject: [PATCH] refs #24322. Comments no longer apply
---
.../geometry/src/Exports/ComponentInfoPythonIterator.cpp | 9 ---------
.../geometry/src/Exports/DetectorInfoPythonIterator.cpp | 9 ---------
2 files changed, 18 deletions(-)
diff --git a/Framework/PythonInterface/mantid/geometry/src/Exports/ComponentInfoPythonIterator.cpp b/Framework/PythonInterface/mantid/geometry/src/Exports/ComponentInfoPythonIterator.cpp
index 3a967c61759..a07add6f07d 100644
--- a/Framework/PythonInterface/mantid/geometry/src/Exports/ComponentInfoPythonIterator.cpp
+++ b/Framework/PythonInterface/mantid/geometry/src/Exports/ComponentInfoPythonIterator.cpp
@@ -25,13 +25,4 @@ void export_ComponentInfoPythonIterator() {
.def("next", &ComponentInfoPythonIterator::next)
#endif
;
- /*
- Return value policy for next is to copy the const reference. Copy by value is
- essential for python 2.0 compatibility because items (DetectorInfoItem) will
- outlive their iterators if declared as part of for loops. There is no good
- way to deal with this other than to force a copy so that internals of the
- item are not also corrupted. Future developers may wish to choose a separte
- policy for python 3.0 where this is not a concern, and const ref returns
- would be faster.
- */
}
diff --git a/Framework/PythonInterface/mantid/geometry/src/Exports/DetectorInfoPythonIterator.cpp b/Framework/PythonInterface/mantid/geometry/src/Exports/DetectorInfoPythonIterator.cpp
index 060495bf825..0c7db21d735 100644
--- a/Framework/PythonInterface/mantid/geometry/src/Exports/DetectorInfoPythonIterator.cpp
+++ b/Framework/PythonInterface/mantid/geometry/src/Exports/DetectorInfoPythonIterator.cpp
@@ -25,13 +25,4 @@ void export_DetectorInfoPythonIterator() {
.def("next", &DetectorInfoPythonIterator::next)
#endif
;
- /*
- Return value policy for next is to copy the const reference. Copy by value is
- essential for python 2.0 compatibility because items (DetectorInfoItem) will
- outlive their iterators if declared as part of for loops. There is no good
- way to deal with this other than to force a copy so that internals of the
- item are not also corrupted. Future developers may wish to choose a separte
- policy for python 3.0 where this is not a concern, and const ref returns
- would be faster.
- */
}
--
GitLab