-
Verena Reimund authored
- revert some changes of SpecularReflectionPositionCorrect2 (but keep all const changes) - add new method addSampleLogs to LoadILLReflectometry, sample log of two theta not complete for user given angle - use m_sampleAngleName for FIGARO (many occasions in code where this name is used) - in ReflectometryILLPreprocess(Test): - in case of user given two theta: need to write this to the sample logs - use loader with fixed two theta and line position to avoid peak fitting and final detector rotation - handle LinePosition input properly when moving the detector (only needed if two theta is user given) - provide FIGARO's deflection angle (added a method to common since it handles NeXus variable names) - import and use numpy.full in PreProcess test to improve the test in terms of shape and type of the values. Get blocksize() outside loop. - CalculatePolynomialBackground failed often during testing and it was not easy to adapt the test, deleted background offset and width input properties -> cleanup still tested fully - replaced use of getLogData by getProperty Refs #24123
Verena Reimund authored- revert some changes of SpecularReflectionPositionCorrect2 (but keep all const changes) - add new method addSampleLogs to LoadILLReflectometry, sample log of two theta not complete for user given angle - use m_sampleAngleName for FIGARO (many occasions in code where this name is used) - in ReflectometryILLPreprocess(Test): - in case of user given two theta: need to write this to the sample logs - use loader with fixed two theta and line position to avoid peak fitting and final detector rotation - handle LinePosition input properly when moving the detector (only needed if two theta is user given) - provide FIGARO's deflection angle (added a method to common since it handles NeXus variable names) - import and use numpy.full in PreProcess test to improve the test in terms of shape and type of the values. Get blocksize() outside loop. - CalculatePolynomialBackground failed often during testing and it was not easy to adapt the test, deleted background offset and width input properties -> cleanup still tested fully - replaced use of getLogData by getProperty Refs #24123
Code owners
Assign users and groups as approvers for specific file changes. Learn more.