Skip to content
Snippets Groups Projects
  • Gemma Guest's avatar
    3c888dd8
    Fix a bug where restoring defaults affects all batches · 3c888dd8
    Gemma Guest authored
    Clicking restore-defaults on an Experiment or Instrument tab in a batch should only affect that tab and batch. This commit fixes a bug where a notification was sent to all batches, and every Experiment and Instrument tab was being reset. The fix is to separate updating the instrument (which is required to ensure we have up-to-date settings loaded from the instrument) from the subsequent notification which updates all batches. Instead, the particular Experiment/Instrument tab where the request was made restores its own defaults itself.
    
    Re #28429
    3c888dd8
    History
    Fix a bug where restoring defaults affects all batches
    Gemma Guest authored
    Clicking restore-defaults on an Experiment or Instrument tab in a batch should only affect that tab and batch. This commit fixes a bug where a notification was sent to all batches, and every Experiment and Instrument tab was being reset. The fix is to separate updating the instrument (which is required to ensure we have up-to-date settings loaded from the instrument) from the subsequent notification which updates all batches. Instead, the particular Experiment/Instrument tab where the request was made restores its own defaults itself.
    
    Re #28429
Code owners
Assign users and groups as approvers for specific file changes. Learn more.