Unverified Commit f4df0c48 authored by Alex Langford's avatar Alex Langford Committed by GitHub
Browse files

[lldb][NFCI] Change parameter type in Target::AddNameToBreakpoint (#71241) 

By itself this change does very little, but I plan on refactoring
something from StructuredData and it gets much easier with this change.
parent 002f4224

lldb/include/lldb/Target/Target.h

+3 −2
Original line number Diff line number Diff line
@@ -763,9 +763,10 @@ public: 
  WatchpointList &GetWatchpointList() { return m_watchpoint_list; }



  // Manages breakpoint names:

  void AddNameToBreakpoint(BreakpointID &id, const char *name, Status &error);

  void AddNameToBreakpoint(BreakpointID &id, llvm::StringRef name,

                           Status &error);



  void AddNameToBreakpoint(lldb::BreakpointSP &bp_sp, const char *name,

  void AddNameToBreakpoint(lldb::BreakpointSP &bp_sp, llvm::StringRef name,

                           Status &error);



  void RemoveNameFromBreakpoint(lldb::BreakpointSP &bp_sp, ConstString name);

lldb/source/Target/Target.cpp

+2 −2
Original line number Diff line number Diff line
@@ -727,7 +727,7 @@ void Target::AddBreakpoint(lldb::BreakpointSP bp_sp, bool internal) { 
  }

}



void Target::AddNameToBreakpoint(BreakpointID &id, const char *name,

void Target::AddNameToBreakpoint(BreakpointID &id, llvm::StringRef name,

                                 Status &error) {

  BreakpointSP bp_sp =

      m_breakpoint_list.FindBreakpointByID(id.GetBreakpointID());
@@ -740,7 +740,7 @@ void Target::AddNameToBreakpoint(BreakpointID &id, const char *name, 
  AddNameToBreakpoint(bp_sp, name, error);

}



void Target::AddNameToBreakpoint(BreakpointSP &bp_sp, const char *name,

void Target::AddNameToBreakpoint(BreakpointSP &bp_sp, llvm::StringRef name,

                                 Status &error) {

  if (!bp_sp)

    return;