Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
llvm-doe
llvm-project
Commits
e5911de3
Commit
e5911de3
authored
Jun 24, 2020
by
Sid Manning
Browse files
[Hexagon][llvm-objcopy] Add missing check for SHN_HEXAGON_SCOMMON_1
Differential Revision:
https://reviews.llvm.org/D82484
parent
413a1878
Changes
2
Hide whitespace changes
Inline
Side-by-side
llvm/test/tools/llvm-objcopy/ELF/common-symbol.test
View file @
e5911de3
...
...
@@ -11,10 +11,14 @@ FileHeader:
Symbols
:
-
Name
:
test
Index
:
SHN_COMMON
Value
:
0x1233
Binding
:
STB_GLOBAL
-
Name
:
test1
Index
:
SHN_HEXAGON_SCOMMON
Value
:
0x1234
Binding
:
STB_GLOBAL
-
Name
:
test2
Index
:
SHN_HEXAGON_SCOMMON
Index
:
SHN_HEXAGON_SCOMMON
_1
Value
:
0x1235
Binding
:
STB_GLOBAL
-
Name
:
test3
...
...
@@ -42,7 +46,7 @@ Symbols:
#CHECK-NEXT: }
#CHECK-NEXT: Symbol {
#CHECK-NEXT: Name: test
#CHECK-NEXT: Value: 0x123
4
#CHECK-NEXT: Value: 0x123
3
#CHECK-NEXT: Size: 0
#CHECK-NEXT: Binding: Global (0x1)
#CHECK-NEXT: Type: None (0x0)
...
...
@@ -50,13 +54,22 @@ Symbols:
#CHECK-NEXT: Section: Common (0xFFF2)
#CHECK-NEXT: }
#CHECK-NEXT: Symbol {
#CHECK-NEXT: Name: test1
#CHECK-NEXT: Value: 0x1234
#CHECK-NEXT: Size: 0
#CHECK-NEXT: Binding: Global (0x1)
#CHECK-NEXT: Type: None (0x0)
#CHECK-NEXT: Other: 0
#CHECK-NEXT: Section: Processor Specific (0xFF00)
#CHECK-NEXT: }
#CHECK-NEXT: Symbol {
#CHECK-NEXT: Name: test2
#CHECK-NEXT: Value: 0x1235
#CHECK-NEXT: Size: 0
#CHECK-NEXT: Binding: Global (0x1)
#CHECK-NEXT: Type: None (0x0)
#CHECK-NEXT: Other: 0
#CHECK-NEXT: Section: Processor Specific (0xFF0
0
)
#CHECK-NEXT: Section: Processor Specific (0xFF0
1
)
#CHECK-NEXT: }
#CHECK-NEXT: Symbol {
#CHECK-NEXT: Name: test3
...
...
llvm/tools/llvm-objcopy/ELF/Object.cpp
View file @
e5911de3
...
...
@@ -608,6 +608,7 @@ static bool isValidReservedSectionIndex(uint16_t Index, uint16_t Machine) {
if
(
Machine
==
EM_HEXAGON
)
{
switch
(
Index
)
{
case
SHN_HEXAGON_SCOMMON
:
case
SHN_HEXAGON_SCOMMON_1
:
case
SHN_HEXAGON_SCOMMON_2
:
case
SHN_HEXAGON_SCOMMON_4
:
case
SHN_HEXAGON_SCOMMON_8
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment