Commit e47965bf authored by Matt Arsenault's avatar Matt Arsenault Committed by Matt Arsenault
Browse files

AMDGPU/GlobalISel: Merge trivial legalize rules 

Also move constant-like rules together
parent a6492e22

llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp

+22 −29
Original line number Diff line number Diff line
@@ -303,9 +303,6 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST_, 
    .clampScalar(0, S32, S32)

    .scalarize(0); // TODO: Implement.



  getActionDefinitionsBuilder({G_SADDO, G_SSUBO})

    .lower();



  getActionDefinitionsBuilder(G_BITCAST)

    // Don't worry about the size constraint.

    .legalIf(all(isRegisterType(0), isRegisterType(1)))
@@ -314,6 +311,13 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST_, 
    .lower();





  getActionDefinitionsBuilder(G_CONSTANT)

    .legalFor({S1, S32, S64, S16, GlobalPtr,

               LocalPtr, ConstantPtr, PrivatePtr, FlatPtr })

    .clampScalar(0, S32, S64)

    .widenScalarToNextPow2(0)

    .legalIf(isPointer(0));



  getActionDefinitionsBuilder(G_FCONSTANT)

    .legalFor({S32, S64, S16})

    .clampScalar(0, S16, S64);
@@ -327,21 +331,10 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST_, 
    .widenScalarToNextPow2(0, 32)

    .clampMaxNumElements(0, S32, 16);





  // FIXME: i1 operands to intrinsics should always be legal, but other i1

  // values may not be legal.  We need to figure out how to distinguish

  // between these two scenarios.

  getActionDefinitionsBuilder(G_CONSTANT)

    .legalFor({S1, S32, S64, S16, GlobalPtr,

               LocalPtr, ConstantPtr, PrivatePtr, FlatPtr })

    .clampScalar(0, S32, S64)

    .widenScalarToNextPow2(0)

    .legalIf(isPointer(0));



  setAction({G_FRAME_INDEX, PrivatePtr}, Legal);

  getActionDefinitionsBuilder(G_GLOBAL_VALUE)

    .customFor({LocalPtr, GlobalPtr, ConstantPtr, Constant32Ptr});



  setAction({G_BLOCK_ADDR, CodePtr}, Legal);



  auto &FPOpActions = getActionDefinitionsBuilder(

    { G_FADD, G_FMUL, G_FMA, G_FCANONICALIZE})
@@ -401,9 +394,6 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST_, 
    .scalarize(0)

    .clampScalar(0, S16, S64);



  // TODO: Implement

  getActionDefinitionsBuilder({G_FMINIMUM, G_FMAXIMUM}).lower();



  if (ST.has16BitInsts()) {

    getActionDefinitionsBuilder({G_FSQRT, G_FFLOOR})

      .legalFor({S32, S64, S16})
@@ -425,9 +415,6 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST_, 
    .lowerFor({{S64, S16}}) // FIXME: Implement

    .scalarize(0);



  // TODO: Verify V_BFI_B32 is generated from expanded bit ops.

  getActionDefinitionsBuilder(G_FCOPYSIGN).lower();



  getActionDefinitionsBuilder(G_FSUB)

      // Use actual fsub instruction

      .legalFor({S32})
@@ -502,8 +489,6 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST_, 
    .scalarize(0)

    .alwaysLegal();



  setAction({G_BLOCK_ADDR, CodePtr}, Legal);



  auto &CmpBuilder =

    getActionDefinitionsBuilder(G_ICMP)

    // The compare output type differs based on the register bank of the output,
@@ -895,10 +880,6 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST_, 
                {S32, FlatPtr}, {S64, FlatPtr}})

    .legalFor({{S32, LocalPtr}, {S64, LocalPtr},

               {S32, RegionPtr}, {S64, RegionPtr}});



  getActionDefinitionsBuilder(G_ATOMIC_CMPXCHG_WITH_SUCCESS)

    .lower();



  // TODO: Pointer types, any 32-bit or 64-bit vector



  // Condition should be s32 for scalar, s1 for vector.
@@ -1119,11 +1100,23 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST_, 
    .clampScalar(0, MinLegalScalarShiftTy, S64)

    .lower();



  getActionDefinitionsBuilder({G_READ_REGISTER, G_WRITE_REGISTER}).lower();



  getActionDefinitionsBuilder(G_READCYCLECOUNTER)

    .legalFor({S64});



  getActionDefinitionsBuilder({

      // TODO: Verify V_BFI_B32 is generated from expanded bit ops

      G_FCOPYSIGN,



      G_ATOMIC_CMPXCHG_WITH_SUCCESS,

      G_READ_REGISTER,

      G_WRITE_REGISTER,



      G_SADDO, G_SSUBO,



       // TODO: Implement

      G_FMINIMUM, G_FMAXIMUM

    }).lower();



  getActionDefinitionsBuilder({G_VASTART, G_VAARG, G_BRJT, G_JUMP_TABLE,

        G_DYN_STACKALLOC, G_INDEXED_LOAD, G_INDEXED_SEXTLOAD,

        G_INDEXED_ZEXTLOAD, G_INDEXED_STORE})