Commit e23d6f31 authored by Tim Northover's avatar Tim Northover
Browse files

NeonEmitter: remove special case on casting polymorphic builtins. 

For some reason we were not casting a fairly obscure class of builtin calls we
expected to be polymorphic to vectors of char. It worked because the only
affected intrinsics weren't actually polymorphic after all, but is
unnecessarily complicated.
parent db73bcd9

clang/lib/CodeGen/CGBuiltin.cpp

+5 −0
Original line number Diff line number Diff line
@@ -5456,6 +5456,11 @@ Value *CodeGenFunction::EmitCommonNeonBuiltinExpr( 
    llvm::Type *Tys[2] = { Ty, GetFloatNeonType(this, Type) };

    return EmitNeonCall(CGM.getIntrinsic(LLVMIntrinsic, Tys), Ops, NameHint);

  }

  case NEON::BI__builtin_neon_vcvtx_f32_v: {

    llvm::Type *Tys[2] = { VTy->getTruncatedElementVectorType(VTy), Ty};

    return EmitNeonCall(CGM.getIntrinsic(LLVMIntrinsic, Tys), Ops, NameHint);













  }















  case NEON::BI__builtin_neon_vext_v:















  case NEON::BI__builtin_neon_vextq_v: {















    int CV = cast<ConstantInt>(Ops[2])->getSExtValue();

































clang/utils/TableGen/NeonEmitter.cpp



+2
−5






























Original line number
Diff line number
Diff line








@@ -1078,9 +1078,7 @@ std::string Intrinsic::getBuiltinTypeStr() {













    if (!RetT.isScalar() && RetT.isInteger() && !RetT.isSigned())















      RetT.makeSigned();





























    bool ForcedVectorFloatingType = isFloatingPointProtoModifier(Proto[0]);













    if (LocalCK == ClassB && !RetT.isVoid() && !RetT.isScalar() &&













        !ForcedVectorFloatingType)













    if (LocalCK == ClassB && !RetT.isVoid() && !RetT.isScalar())















      // Cast to vector of 8-bit elements.















      RetT.makeInteger(8, true);

























@@ -1092,8 +1090,7 @@ std::string Intrinsic::getBuiltinTypeStr() {













    if (T.isPoly())















      T.makeInteger(T.getElementSizeInBits(), false);





























    bool ForcedFloatingType = isFloatingPointProtoModifier(Proto[I + 1]);













    if (LocalCK == ClassB && !T.isScalar() && !ForcedFloatingType)













    if (LocalCK == ClassB && !T.isScalar())















      T.makeInteger(8, true);















    // Halves always get converted to 8-bit elements.















    if (T.isHalf() && T.isVector() && !T.isScalarForMangling())