Commit d85785aa authored by Hans Wennborg's avatar Hans Wennborg
Browse files

Merging r324234: 

------------------------------------------------------------------------
r324234 | kamil | 2018-02-05 14:16:22 +0100 (Mon, 05 Feb 2018) | 29 lines

Fix a crash in *NetBSD::Factory::Launch

Summary:
We cannot call process_up->SetState() inside
the NativeProcessNetBSD::Factory::Launch
function because it triggers a NULL pointer
deference.

The generic code for launching a process in:
GDBRemoteCommunicationServerLLGS::LaunchProcess
sets the m_debugged_process_up pointer after
a successful call to  m_process_factory.Launch().
If we attempt to call process_up->SetState()
inside a platform specific Launch function we
end up dereferencing a NULL pointer in
NativeProcessProtocol::GetCurrentThreadID().

Use the proper call process_up->SetState(,false)
that sets notify_delegates to false.

Sponsored by <The NetBSD Foundation>

Reviewers: labath, joerg

Reviewed By: labath

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D42868
------------------------------------------------------------------------

llvm-svn: 324327
parent bdb1df16

lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp

+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ NativeProcessNetBSD::Factory::Launch(ProcessLaunchInfo &launch_info, 


  for (const auto &thread : process_up->m_threads)

    static_cast<NativeThreadNetBSD &>(*thread).SetStoppedBySignal(SIGSTOP);

  process_up->SetState(StateType::eStateStopped);

  process_up->SetState(StateType::eStateStopped, false);



  return std::move(process_up);

}