Commit cb06571a authored by serge-sans-paille's avatar serge-sans-paille
Browse files

Avoid dangling reference on SectionList 

Bug spotted by https://cookieplmonster.github.io/2020/02/01/emulator-bug-llvm-bug/

Basically, holding references to object inside a resized vector is a bad idea.

Differential Revision: https://reviews.llvm.org/D75110
parent e484c175

llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h

+4 −1
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ 
#include "llvm/Support/Host.h"

#include "llvm/Support/Mutex.h"

#include "llvm/Support/SwapByteOrder.h"

#include <deque>

#include <map>

#include <system_error>

#include <unordered_map>
@@ -251,7 +252,9 @@ protected: 


  // A list of all sections emitted by the dynamic linker.  These sections are

  // referenced in the code by means of their index in this list - SectionID.

  typedef SmallVector<SectionEntry, 64> SectionList;

  // Because references may be kept while the list grows, use a container that

  // guarantees reference stability.

  typedef std::deque<SectionEntry> SectionList;

  SectionList Sections;



  typedef unsigned SID; // Type for SectionIDs