Commit bc9ab9a5 authored by Simon Pilgrim's avatar Simon Pilgrim
Browse files

[DAG] CombineToPreIndexedLoadStore - use const APInt& for getAPIntValue(). NFCI. 

Cleanup some code to use auto* properly from cast, and use const APInt& for getAPIntValue() to avoid an unnecessary copy.
parent 86021d98

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

+6 −9
Original line number Diff line number Diff line
@@ -14940,16 +14940,13 @@ bool DAGCombiner::CombineToPreIndexedLoadStore(SDNode *N) { 
    // Therefore, we have:

    //   t0 = (x0 * offset0 - x1 * y0 * y1 *offset1) + (y0 * y1) * t1













    ConstantSDNode *CN =













      cast<ConstantSDNode>(OtherUses[i]->getOperand(OffsetIdx));













    int X0, X1, Y0, Y1;













    auto *CN = cast<ConstantSDNode>(OtherUses[i]->getOperand(OffsetIdx));















    const APInt &Offset0 = CN->getAPIntValue();













    APInt Offset1 = cast<ConstantSDNode>(Offset)->getAPIntValue();

























    X0 = (OtherUses[i]->getOpcode() == ISD::SUB && OffsetIdx == 1) ? -1 : 1;













    Y0 = (OtherUses[i]->getOpcode() == ISD::SUB && OffsetIdx == 0) ? -1 : 1;













    X1 = (AM == ISD::PRE_DEC && !Swapped) ? -1 : 1;













    Y1 = (AM == ISD::PRE_DEC && Swapped) ? -1 : 1;













    const APInt &Offset1 = cast<ConstantSDNode>(Offset)->getAPIntValue();













    int X0 = (OtherUses[i]->getOpcode() == ISD::SUB && OffsetIdx == 1) ? -1 : 1;













    int Y0 = (OtherUses[i]->getOpcode() == ISD::SUB && OffsetIdx == 0) ? -1 : 1;













    int X1 = (AM == ISD::PRE_DEC && !Swapped) ? -1 : 1;













    int Y1 = (AM == ISD::PRE_DEC && Swapped) ? -1 : 1;





























    unsigned Opcode = (Y0 * Y1 < 0) ? ISD::SUB : ISD::ADD;