Commit afd5d912 authored by António Afonso's avatar António Afonso Committed by António Afonso
Browse files

[lldb] Fix TestFormattersSBAPI test 

Summary:
This test was broken in two ways:
* Using the wrong API (e.g.: format = instead of SetFormat)
* The hex checker was only checking "01" which will pass with 0x0000001

Reviewers: clayborg, lanza, wallace

Reviewed By: clayborg

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D70884
parent 3d02fa6d

lldb/packages/Python/lldbsuite/test/python_api/formatters/TestFormattersSBAPI.py

+10 −7
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ class SBFormattersAPITestCase(TestBase): 
        self.expect("frame variable foo.E",

                    substrs=['b8cca70a'])



        format.format = lldb.eFormatOctal

        format.SetFormat(lldb.eFormatOctal)

        category.AddTypeFormat(lldb.SBTypeNameSpecifier("int"), format)

        self.expect("frame variable foo.A",

                    substrs=[' 01'])
@@ -90,10 +90,13 @@ class SBFormattersAPITestCase(TestBase): 
            new_category.IsValid(),

            "getting a non-existing category worked")

        new_category = self.dbg.CreateCategory("foobar")

        new_category.enabled = True

        new_category.SetEnabled(True)

        new_category.AddTypeSummary(

            lldb.SBTypeNameSpecifier(

                "^.*t$", True), summary)

                "^.*t$",

                True,  # is_regexp

            ), summary)



        self.expect("frame variable foo.A",

                    substrs=['hello world'])

        self.expect("frame variable foo.E", matching=False,
@@ -102,7 +105,7 @@ class SBFormattersAPITestCase(TestBase): 
                    substrs=['hello world'])

        self.expect("frame variable foo.F",

                    substrs=['hello world'])

        new_category.enabled = False

        new_category.SetEnabled(False)

        self.expect("frame variable foo.A", matching=False,

                    substrs=['hello world'])

        self.expect("frame variable foo.E", matching=False,
@@ -379,7 +382,7 @@ class SBFormattersAPITestCase(TestBase): 
            lldb.SBTypeSummary.CreateWithScriptCode("return 'hello scripted world';"))

        self.expect("frame variable foo", matching=False,

                    substrs=['hello scripted world'])

        new_category.enabled = True

        new_category.SetEnabled(True)

        self.expect("frame variable foo", matching=True,

                    substrs=['hello scripted world'])