Commit ad74df12 authored by Michael Buch's avatar Michael Buch
Browse files

Revert "[lldb][DWARFExpression] Fix DW_OP_div to use signed division" 

This reverts commit e15d6b52.

Newly added test fails on Darwin platforms and arm.

Differential Revision: https://reviews.llvm.org/D147370
parent e37fce3d

lldb/source/Expression/DWARFExpression.cpp

+2 −6
Original line number Diff line number Diff line
@@ -1436,12 +1436,8 @@ bool DWARFExpression::Evaluate( 
          return false;

        } else {

          stack.pop_back();

          Scalar divisor, dividend;

          divisor = tmp.ResolveValue(exe_ctx);

          dividend = stack.back().ResolveValue(exe_ctx);

          divisor.MakeSigned();

          dividend.MakeSigned();

          stack.back() = dividend / divisor;

          stack.back() =

              stack.back().ResolveValue(exe_ctx) / tmp.ResolveValue(exe_ctx);

          if (!stack.back().ResolveValue(exe_ctx).IsValid()) {

            if (error_ptr)

              error_ptr->SetErrorString("Divide failed.");

lldb/test/Shell/SymbolFile/DWARF/x86/DW_OP_div-with-signed.s

deleted100644 → 0
+0 −468

File deleted.

Preview size limit exceeded, changes collapsed.