Commit a72d15e3 authored by Fangrui Song's avatar Fangrui Song
Browse files

[XRay] Set hasSideEffects flag of PATCHABLE_FUNCTION_{ENTER,EXIT} 

Otherwise they may be picked as the delay slot by mips-delay-slot-filler, if we move patchable-function before mips-delay-slot-filler.
parent 26ba1f77

llvm/include/llvm/Target/Target.td

+2 −2
Original line number Diff line number Diff line
@@ -1182,7 +1182,7 @@ def PATCHABLE_FUNCTION_ENTER : StandardPseudoInstruction { 
  let InOperandList = (ins);

  let AsmString = "# XRay Function Enter.";

  let usesCustomInserter = 1;

  let hasSideEffects = 0;

  let hasSideEffects = 1;

}

def PATCHABLE_RET : StandardPseudoInstruction {

  let OutOperandList = (outs);
@@ -1198,7 +1198,7 @@ def PATCHABLE_FUNCTION_EXIT : StandardPseudoInstruction { 
  let InOperandList = (ins);

  let AsmString = "# XRay Function Exit.";

  let usesCustomInserter = 1;

  let hasSideEffects = 0; // FIXME: is this correct?

  let hasSideEffects = 1;

  let isReturn = 0; // Original return instruction will follow

}

def PATCHABLE_TAIL_CALL : StandardPseudoInstruction {