Commit a4fc3887 authored by Hans Wennborg's avatar Hans Wennborg
Browse files

Merging r353422: 

------------------------------------------------------------------------
r353422 | kadircet | 2019-02-07 17:04:30 +0100 (Thu, 07 Feb 2019) | 18 lines

[clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.

Summary:
clangd is using as many threads as logical cores for BackgroundIndex
by default. We observed that it increases latency of foreground tasks.

This patch aims to change that default to number of physical cores to get rid of
that extra latency.

Reviewers: ilya-biryukov

Reviewed By: ilya-biryukov

Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D57819
------------------------------------------------------------------------

llvm-svn: 354980
parent b02e2366

clang-tools-extra/clangd/index/Background.h

+6 −5
Original line number Diff line number Diff line
@@ -68,11 +68,12 @@ public: 
  /// If BuildIndexPeriodMs is greater than 0, the symbol index will only be

  /// rebuilt periodically (one per \p BuildIndexPeriodMs); otherwise, index is

  /// rebuilt for each indexed file.

  BackgroundIndex(Context BackgroundContext, const FileSystemProvider &,

  BackgroundIndex(

      Context BackgroundContext, const FileSystemProvider &,

      const GlobalCompilationDatabase &CDB,

      BackgroundIndexStorage::Factory IndexStorageFactory,

      size_t BuildIndexPeriodMs = 0,

                  size_t ThreadPoolSize = llvm::hardware_concurrency());

      size_t ThreadPoolSize = llvm::heavyweight_hardware_concurrency());

  ~BackgroundIndex(); // Blocks while the current task finishes.



  // Enqueue translation units for indexing.