Commit 952a540b authored by David Spickett's avatar David Spickett
Browse files

[test] On Mac, don't try to use result of sysctl command if calling it failed. 

If sysctl is not found at all, let the usual exception propogate
so that the user can fix their env. If it fails because of the
permissions required to read the property then print a warning
and continue.

Differential Revision: https://reviews.llvm.org/D72278
parent 10357e1c

llvm/test/lit.cfg.py

+12 −9
Original line number Diff line number Diff line
@@ -324,15 +324,18 @@ llvm_config.feature_config( 
     ('--has-global-isel', {'ON': 'global-isel'})])



if 'darwin' == sys.platform:

    try:

        sysctl_cmd = subprocess.Popen(['sysctl', 'hw.optional.fma'],

                                      stdout=subprocess.PIPE)

    except OSError:

        print('Could not exec sysctl')

    cmd = ['sysctl', 'hw.optional.fma']

    sysctl_cmd = subprocess.Popen(cmd, stdout=subprocess.PIPE)



    # Non zero return, probably a permission issue

    if sysctl_cmd.wait():

        print(

          "Warning: sysctl exists but calling \"{}\" failed, defaulting to no fma3.".format(

          " ".join(cmd)))

    else:

        result = sysctl_cmd.stdout.read().decode('ascii')

    if -1 != result.find('hw.optional.fma: 1'):

        if 'hw.optional.fma: 1' in result:

            config.available_features.add('fma3')

    sysctl_cmd.wait()



# .debug_frame is not emitted for targeting Windows x64.

if not re.match(r'^x86_64.*-(windows-gnu|windows-msvc)', config.target_triple):