Commit 90b8bc00 authored by Peter Collingbourne's avatar Peter Collingbourne
Browse files

IRGen: Call SetLLVMFunctionAttributes{,ForDefinition} on __cfi_check_fail. 

This has the main effect of causing target-cpu and target-features to be set
on __cfi_check_fail, causing the function to become ABI-compatible with other
functions in the case where these attributes affect ABI (e.g. reserve-x18).

Technically we only need to call SetLLVMFunctionAttributes to get the target-*
attributes set, but since we're creating a definition we probably ought to
call the ForDefinition function as well.

Fixes PR44094.

Differential Revision: https://reviews.llvm.org/D70692
parent 1b42cc0d

clang/lib/CodeGen/CGExpr.cpp

+3 −0
Original line number Diff line number Diff line
@@ -3200,6 +3200,9 @@ void CodeGenFunction::EmitCfiCheckFail() { 
  llvm::Function *F = llvm::Function::Create(

      llvm::FunctionType::get(VoidTy, {VoidPtrTy, VoidPtrTy}, false),

      llvm::GlobalValue::WeakODRLinkage, "__cfi_check_fail", &CGM.getModule());



  CGM.SetLLVMFunctionAttributes(GlobalDecl(), FI, F);

  CGM.SetLLVMFunctionAttributesForDefinition(nullptr, F);

  F->setVisibility(llvm::GlobalValue::HiddenVisibility);



  StartFunction(GlobalDecl(), CGM.getContext().VoidTy, F, FI, Args,

clang/test/CodeGen/cfi-check-fail-attrs.c

0 → 100644
+5 −0
Original line number Diff line number Diff line 
// RUN: %clang_cc1 -triple aarch64-unknown-linux -fsanitize-cfi-cross-dso -target-feature +reserve-x18 -emit-llvm -o - %s | FileCheck %s



// CHECK: define weak_odr hidden void @__cfi_check_fail{{.*}} [[ATTR:#[0-9]*]]



// CHECK: attributes [[ATTR]] = {{.*}} "target-features"="+reserve-x18"