Commit 90b5ed99 authored by Nikita Popov's avatar Nikita Popov
Browse files

[InstCombine] Remove unnecessary worklist add; NFCI 

The IRBuilder will automatically add instructions to the worklist.
Adding it manually is unnecessary, but may mess up worklist order.
parent cad91074

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

+1 −3
Original line number Diff line number Diff line
@@ -4680,9 +4680,7 @@ static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 
        ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));

        APInt ShortMask = CI->getValue().trunc(MulWidth);

        Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);

        Instruction *Zext =

            cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));

        IC.Worklist.Add(Zext);

        Value *Zext = Builder.CreateZExt(ShortAnd, BO->getType());

        IC.replaceInstUsesWith(*BO, Zext);

      } else {

        llvm_unreachable("Unexpected Binary operation");