Commit 7ece2050 authored by Serge Bazanski's avatar Serge Bazanski Committed by Fangrui Song
Browse files

[Lanai] fix lowering wide returns 

This implements LanaiTargetLowering::CanLowerReturn, thereby ensuring
all return values conform to the RetCC and get sret-demoted as
necessary.

A regression test is also added that exercises this functionality.

Reviewed By: jpienaar

Differential Revision: https://reviews.llvm.org/D107086
parent ac42f760

llvm/lib/Target/Lanai/LanaiISelLowering.cpp

+9 −0
Original line number Diff line number Diff line
@@ -530,6 +530,15 @@ SDValue LanaiTargetLowering::LowerCCCArguments( 
  return Chain;

}



bool LanaiTargetLowering::CanLowerReturn(

    CallingConv::ID CallConv, MachineFunction &MF, bool IsVarArg,

    const SmallVectorImpl<ISD::OutputArg> &Outs, LLVMContext &Context) const {

  SmallVector<CCValAssign, 16> RVLocs;

  CCState CCInfo(CallConv, IsVarArg, MF, RVLocs, Context);



  return CCInfo.CheckReturn(Outs, RetCC_Lanai32);

}



SDValue

LanaiTargetLowering::LowerReturn(SDValue Chain, CallingConv::ID CallConv,

                                 bool IsVarArg,

llvm/lib/Target/Lanai/LanaiISelLowering.h

+5 −0
Original line number Diff line number Diff line
@@ -90,6 +90,11 @@ public: 
  SDValue LowerSRL_PARTS(SDValue Op, SelectionDAG &DAG) const;

  SDValue LowerVASTART(SDValue Op, SelectionDAG &DAG) const;



  bool CanLowerReturn(CallingConv::ID CallConv, MachineFunction &MF,

                      bool IsVarArg,

                      const SmallVectorImpl<ISD::OutputArg> &Outs,

                      LLVMContext &Context) const override;



  Register getRegisterByName(const char *RegName, LLT VT,

                             const MachineFunction &MF) const override;

  std::pair<unsigned, const TargetRegisterClass *>

llvm/test/CodeGen/Lanai/lowering-128.ll

0 → 100644
+13 −0
Original line number Diff line number Diff line 
; RUN: llc -march=lanai < %s | FileCheck %s



; Tests that lowering wide registers (128 bits or more) works on Lanai.

; The emitted assembly is not checked, we just do a smoketest.



target datalayout = "E-m:e-p:32:32-i64:64-a:0:32-n32-S64"

target triple = "lanai"



; CHECK-LABEL: add128:

define i128 @add128(i128 %x, i128 %y) {

  %a = add i128 %x, %y

  ret i128 %a

}