Commit 7420f969 authored by Reid Kleckner's avatar Reid Kleckner
Browse files

[TableGen] Move generated *Attr class methods out of line 

After this change, clang spends ~200ms parsing Attrs.inc instead of
~560ms. A large part of the cost was from the StringSwitch
instantiations, but this is a good way to avoid similar problems in the
future.

Reviewed By: aaron.ballman, rjmccall

Differential Revision: https://reviews.llvm.org/D76040
parent e79397f5

clang/utils/TableGen/ClangAttrEmitter.cpp

+206 −133
Original line number Diff line number Diff line
@@ -691,8 +691,8 @@ namespace { 
    }



    void writeCtorBody(raw_ostream &OS) const override {

      OS << "    std::copy(" << getUpperName() << ", " << getUpperName()

         << " + " << ArgSizeName << ", " << ArgName << ");\n";

      OS << "  std::copy(" << getUpperName() << ", " << getUpperName() << " + "

         << ArgSizeName << ", " << ArgName << ");\n";

    }



    void writeCtorInitializers(raw_ostream &OS) const override {
@@ -894,9 +894,17 @@ namespace { 
      OS << "    }\n";

    }



    void writeConversion(raw_ostream &OS) const {

      OS << "  static bool ConvertStrTo" << type << "(StringRef Val, ";

      OS << type << " &Out) {\n";

    void writeConversion(raw_ostream &OS, bool Header) const {

      if (Header) {

        OS << "  static bool ConvertStrTo" << type << "(StringRef Val, " << type

           << " &Out);\n";

        OS << "  static const char *Convert" << type << "ToStr(" << type

           << " Val);\n";

        return;

      }



      OS << "bool " << getAttrName() << "Attr::ConvertStrTo" << type

         << "(StringRef Val, " << type << " &Out) {\n";

      OS << "  Optional<" << type << "> R = llvm::StringSwitch<Optional<";

      OS << type << ">>(Val)\n";

      for (size_t I = 0; I < enums.size(); ++I) {
@@ -913,8 +921,8 @@ namespace { 
      // trivial because some enumeration values have multiple named

      // enumerators, such as type_visibility(internal) and

      // type_visibility(hidden) both mapping to TypeVisibilityAttr::Hidden.

      OS << "  static const char *Convert" << type << "ToStr("

         << type << " Val) {\n"

      OS << "const char *" << getAttrName() << "Attr::Convert" << type

         << "ToStr(" << type << " Val) {\n"

         << "  switch(Val) {\n";

      SmallDenseSet<StringRef, 8> Uniques;

      for (size_t I = 0; I < enums.size(); ++I) {
@@ -1006,8 +1014,17 @@ namespace { 
      OS << "      " << WritePCHRecord(QualifiedTypeName, "(*i)");

    }



    void writeConversion(raw_ostream &OS) const {

      OS << "  static bool ConvertStrTo" << type << "(StringRef Val, ";

    void writeConversion(raw_ostream &OS, bool Header) const {

      if (Header) {

        OS << "  static bool ConvertStrTo" << type << "(StringRef Val, " << type

           << " &Out);\n";

        OS << "  static const char *Convert" << type << "ToStr(" << type

           << " Val);\n";

        return;

      }



      OS << "bool " << getAttrName() << "Attr::ConvertStrTo" << type

         << "(StringRef Val, ";

      OS << type << " &Out) {\n";

      OS << "  Optional<" << type << "> R = llvm::StringSwitch<Optional<";

      OS << type << ">>(Val)\n";
@@ -1021,8 +1038,8 @@ namespace { 
      OS << "  return false;\n";

      OS << "}\n\n";



      OS << "  static const char *Convert" << type << "ToStr("

        << type << " Val) {\n"

      OS << "const char *" << getAttrName() << "Attr::Convert" << type

         << "ToStr(" << type << " Val) {\n"

         << "  switch(Val) {\n";

      SmallDenseSet<StringRef, 8> Uniques;

      for (size_t I = 0; I < enums.size(); ++I) {
@@ -1353,7 +1370,7 @@ static void writeDeprecatedAttrValue(raw_ostream &OS, std::string &Variety) { 
  OS << "    OS << \"";

}



static void writeGetSpellingFunction(Record &R, raw_ostream &OS) {

static void writeGetSpellingFunction(const Record &R, raw_ostream &OS) {

  std::vector<FlattenedSpelling> Spellings = GetFlattenedSpellings(R);



  OS << "const char *" << R.getName() << "Attr::getSpelling() const {\n";
@@ -1377,7 +1394,7 @@ static void writeGetSpellingFunction(Record &R, raw_ostream &OS) { 
}



static void

writePrettyPrintFunction(Record &R,

writePrettyPrintFunction(const Record &R,

                         const std::vector<std::unique_ptr<Argument>> &Args,

                         raw_ostream &OS) {

  std::vector<FlattenedSpelling> Spellings = GetFlattenedSpellings(R);
@@ -2231,13 +2248,8 @@ static void emitClangAttrThisIsaIdentifierArgList(RecordKeeper &Records, 
  OS << "#endif // CLANG_ATTR_THIS_ISA_IDENTIFIER_ARG_LIST\n\n";

}



// Emits the class definitions for attributes.

void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) {

  emitSourceFileHeader("Attribute classes' definitions", OS);



  OS << "#ifndef LLVM_CLANG_ATTR_CLASSES_INC\n";

  OS << "#define LLVM_CLANG_ATTR_CLASSES_INC\n\n";



static void emitAttributes(RecordKeeper &Records, raw_ostream &OS,

                           bool Header) {

  std::vector<Record*> Attrs = Records.getAllDerivedDefinitions("Attr");

  ParsedAttrMap AttrMap = getParsedAttrList(Records);
@@ -2271,7 +2283,10 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
        Inheritable = true;

    }



    if (Header)

      OS << "class " << R.getName() << "Attr : public " << SuperName << " {\n";

    else

      OS << "\n// " << R.getName() << "Attr implementation\n\n";



    std::vector<Record*> ArgRecords = R.getValueAsListOfDefs("Args");

    std::vector<std::unique_ptr<Argument>> Args;
@@ -2281,8 +2296,10 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
    bool HasFakeArg = false;

    for (const auto *ArgRecord : ArgRecords) {

      Args.emplace_back(createArgument(*ArgRecord, R.getName()));

      if (Header) {

        Args.back()->writeDeclarations(OS);

        OS << "\n\n";

      }



      // For these purposes, fake takes priority over optional.

      if (Args.back()->isFake()) {
@@ -2292,6 +2309,7 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
      }

    }



    if (Header)

      OS << "public:\n";



    std::vector<FlattenedSpelling> Spellings = GetFlattenedSpellings(R);
@@ -2305,8 +2323,11 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
    // This maps spelling index values to semantic Spelling enumerants.

    SemanticSpellingMap SemanticToSyntacticMap;



    std::string SpellingEnum;

    if (!ElideSpelling)

      OS << CreateSemanticSpellings(Spellings, SemanticToSyntacticMap);

      SpellingEnum = CreateSemanticSpellings(Spellings, SemanticToSyntacticMap);

    if (Header)

      OS << SpellingEnum;



    const auto &ParsedAttrSpellingItr = llvm::find_if(

        AttrMap, [R](const std::pair<std::string, const Record *> &P) {
@@ -2315,7 +2336,12 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 


    // Emit CreateImplicit factory methods.

    auto emitCreate = [&](bool Implicit, bool emitFake) {

      OS << "  static " << R.getName() << "Attr *Create";

      if (Header)

        OS << "  static ";

      OS << R.getName() << "Attr *";

      if (!Header)

        OS << R.getName() << "Attr::";

      OS << "Create";

      if (Implicit)

        OS << "Implicit";

      OS << "(";
@@ -2325,7 +2351,16 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
        OS << ", ";

        ai->writeCtorParameters(OS);

      }

      OS << ", const AttributeCommonInfo &CommonInfo = {SourceRange{}}) {\n";

      OS << ", const AttributeCommonInfo &CommonInfo";

      if (Header)

        OS << " = {SourceRange{}}";

      OS << ")";

      if (Header) {

        OS << ";\n";

        return;

      }



      OS << " {\n";

      OS << "  auto *A = new (Ctx) " << R.getName();

      OS << "Attr(Ctx, CommonInfo";

      for (auto const &ai : Args) {
@@ -2346,7 +2381,12 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
    };



    auto emitCreateNoCI = [&](bool Implicit, bool emitFake) {

      OS <<"  static " << R.getName() << "Attr *Create";

      if (Header)

        OS << "  static ";

      OS << R.getName() << "Attr *";

      if (!Header)

        OS << R.getName() << "Attr::";

      OS << "Create";

      if (Implicit)

        OS << "Implicit";

      OS << "(";
@@ -2357,11 +2397,18 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
        ai->writeCtorParameters(OS);

      }

      OS << ", SourceRange Range, AttributeCommonInfo::Syntax Syntax";

      if (!ElideSpelling)

        OS << ", " << R.getName()

           << "Attr::Spelling S = "

              "static_cast<Spelling>(SpellingNotCalculated)";

      OS << ") {\n";

      if (!ElideSpelling) {

        OS << ", " << R.getName() << "Attr::Spelling S";

        if (Header)

          OS << " = static_cast<Spelling>(SpellingNotCalculated)";

      }

      OS << ")";

      if (Header) {

        OS << ";\n";

        return;

      }



      OS << " {\n";

      OS << "  AttributeCommonInfo I(Range, ";



      if (ParsedAttrSpellingItr != std::end(AttrMap))
@@ -2383,7 +2430,7 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
        ai->writeImplicitCtorArgs(OS);

      }

      OS << ", I);\n";

      OS << "  }\n";

      OS << "}\n\n";

    };



    auto emitCreates = [&](bool emitFake) {
@@ -2393,6 +2440,9 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
      emitCreateNoCI(false, emitFake);

    };



    if (Header)

      OS << "  // Factory methods\n";



    // Emit a CreateImplicit that takes all the arguments.

    emitCreates(true);
@@ -2407,7 +2457,11 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
        if (arg->isOptional()) return emitOpt;

        return true;

      };

      OS << "  " << R.getName()

      if (Header)

        OS << "  ";

      else

        OS << R.getName() << "Attr::";

      OS << R.getName()

         << "Attr(ASTContext &Ctx, const AttributeCommonInfo &CommonInfo";

      OS << '\n';

      for (auto const &ai : Args) {
@@ -2417,8 +2471,12 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
        OS << "\n";

      }



      OS << "             )\n";

      OS << "    : " << SuperName << "(Ctx, CommonInfo, ";

      OS << "             )";

      if (Header) {

        OS << ";\n";

        return;

      }

      OS << "\n  : " << SuperName << "(Ctx, CommonInfo, ";

      OS << "attr::" << R.getName() << ", "

         << (R.getValueAsBit("LateParsed") ? "true" : "false");

      if (Inheritable) {
@@ -2447,6 +2505,9 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
      OS << "}\n\n";

    };



    if (Header)

      OS << "\n  // Constructors\n";



    // Emit a constructor that includes all the arguments.

    // This is necessary for cloning.

    emitCtor(true, true);
@@ -2459,35 +2520,50 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
    if (HasOptArg)

      emitCtor(false, false);



    if (Header) {

      OS << '\n';

      OS << "  " << R.getName() << "Attr *clone(ASTContext &C) const;\n";

      OS << "  void printPretty(raw_ostream &OS,\n"

         << "                   const PrintingPolicy &Policy) const;\n";

      OS << "  const char *getSpelling() const;\n";

    }



    if (!ElideSpelling) {

      assert(!SemanticToSyntacticMap.empty() && "Empty semantic mapping list");

      OS << "  Spelling getSemanticSpelling() const {\n";

      if (Header)

        OS << "  Spelling getSemanticSpelling() const;\n";

      else {

        OS << R.getName() << "Attr::Spelling " << R.getName()

           << "Attr::getSemanticSpelling() const {\n";

        WriteSemanticSpellingSwitch("getAttributeSpellingListIndex()",

                                    SemanticToSyntacticMap, OS);

        OS << "}\n";

      }

    }



    if (Header)

      writeAttrAccessorDefinition(R, OS);



    for (auto const &ai : Args) {

      if (Header) {

        ai->writeAccessors(OS);

      } else {

        ai->writeAccessorDefinitions(OS);

      }

      OS << "\n\n";



      // Don't write conversion routines for fake arguments.

      if (ai->isFake()) continue;



      if (ai->isEnumArg())

        static_cast<const EnumArgument *>(ai.get())->writeConversion(OS);

        static_cast<const EnumArgument *>(ai.get())->writeConversion(OS,

                                                                     Header);

      else if (ai->isVariadicEnumArg())

        static_cast<const VariadicEnumArgument *>(ai.get())

            ->writeConversion(OS);

        static_cast<const VariadicEnumArgument *>(ai.get())->writeConversion(

            OS, Header);

    }



    if (Header) {

      OS << R.getValueAsString("AdditionalMembers");

      OS << "\n\n";
@@ -2495,31 +2571,7 @@ void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) { 
         << "attr::" << R.getName() << "; }\n";



      OS << "};\n\n";

  }



  OS << "#endif // LLVM_CLANG_ATTR_CLASSES_INC\n";

}



// Emits the class method definitions for attributes.

void clang::EmitClangAttrImpl(RecordKeeper &Records, raw_ostream &OS) {

  emitSourceFileHeader("Attribute classes' member function definitions", OS);



  std::vector<Record*> Attrs = Records.getAllDerivedDefinitions("Attr");



  for (auto *Attr : Attrs) {

    Record &R = *Attr;



    if (!R.getValueAsBit("ASTNode"))

      continue;



    std::vector<Record*> ArgRecords = R.getValueAsListOfDefs("Args");

    std::vector<std::unique_ptr<Argument>> Args;

    for (const auto *Arg : ArgRecords)

      Args.emplace_back(createArgument(*Arg, R.getName()));



    for (auto const &ai : Args)

      ai->writeAccessorDefinitions(OS);



    } else {

      OS << R.getName() << "Attr *" << R.getName()

         << "Attr::clone(ASTContext &C) const {\n";

      OS << "  auto *A = new (C) " << R.getName() << "Attr(C, *this";
@@ -2536,6 +2588,27 @@ void clang::EmitClangAttrImpl(RecordKeeper &Records, raw_ostream &OS) { 
      writePrettyPrintFunction(R, Args, OS);

      writeGetSpellingFunction(R, OS);

    }

  }

}

// Emits the class definitions for attributes.

void clang::EmitClangAttrClass(RecordKeeper &Records, raw_ostream &OS) {

  emitSourceFileHeader("Attribute classes' definitions", OS);



  OS << "#ifndef LLVM_CLANG_ATTR_CLASSES_INC\n";

  OS << "#define LLVM_CLANG_ATTR_CLASSES_INC\n\n";



  emitAttributes(Records, OS, true);



  OS << "#endif // LLVM_CLANG_ATTR_CLASSES_INC\n";

}



// Emits the class method definitions for attributes.

void clang::EmitClangAttrImpl(RecordKeeper &Records, raw_ostream &OS) {

  emitSourceFileHeader("Attribute classes' member function definitions", OS);



  emitAttributes(Records, OS, false);



  std::vector<Record *> Attrs = Records.getAllDerivedDefinitions("Attr");



  // Instead of relying on virtual dispatch we just create a huge dispatch

  // switch. This is both smaller and faster than virtual functions.