Commit 672207c3 authored by Nathan James's avatar Nathan James
Browse files

[clang-tidy] Convert config options that are bools to use the bool overload of get(GlobalOrLocal)? 

Summary: This was done with a script that looks for calls to Options.get(GlobalOrLocal) that take an integer for the second argument and the result is either compared not equal to 0 or implicitly converted to bool. There may be other occurances

Reviewers: aaron.ballman, alexfh, gribozavr2

Reviewed By: aaron.ballman

Subscribers: wuzish, nemanjai, xazax.hun, kbarton, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77831
parent 8e2daa0c

clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp

+10 −10
Original line number Diff line number Diff line
@@ -23,16 +23,16 @@ namespace bugprone { 
ArgumentCommentCheck::ArgumentCommentCheck(StringRef Name,

                                           ClangTidyContext *Context)

    : ClangTidyCheck(Name, Context),

      StrictMode(Options.getLocalOrGlobal("StrictMode", 0) != 0),

      IgnoreSingleArgument(Options.get("IgnoreSingleArgument", 0) != 0),

      CommentBoolLiterals(Options.get("CommentBoolLiterals", 0) != 0),

      CommentIntegerLiterals(Options.get("CommentIntegerLiterals", 0) != 0),

      CommentFloatLiterals(Options.get("CommentFloatLiterals", 0) != 0),

      CommentStringLiterals(Options.get("CommentStringLiterals", 0) != 0),

      CommentUserDefinedLiterals(Options.get("CommentUserDefinedLiterals", 0) !=

                                 0),

      CommentCharacterLiterals(Options.get("CommentCharacterLiterals", 0) != 0),

      CommentNullPtrs(Options.get("CommentNullPtrs", 0) != 0),

      StrictMode(Options.getLocalOrGlobal("StrictMode", false)),

      IgnoreSingleArgument(Options.get("IgnoreSingleArgument", false)),

      CommentBoolLiterals(Options.get("CommentBoolLiterals", false)),

      CommentIntegerLiterals(Options.get("CommentIntegerLiterals", false)),

      CommentFloatLiterals(Options.get("CommentFloatLiterals", false)),

      CommentStringLiterals(Options.get("CommentStringLiterals", false)),

      CommentUserDefinedLiterals(

          Options.get("CommentUserDefinedLiterals", false)),

      CommentCharacterLiterals(Options.get("CommentCharacterLiterals", false)),

      CommentNullPtrs(Options.get("CommentNullPtrs", false)),

      IdentRE("^(/\\* *)([_A-Za-z][_A-Za-z0-9]*)( *= *\\*/)$") {}



void ArgumentCommentCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {

clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp

+1 −1
Original line number Diff line number Diff line
@@ -499,7 +499,7 @@ static void insertNullTerminatorExpr(StringRef Name, 
NotNullTerminatedResultCheck::NotNullTerminatedResultCheck(

    StringRef Name, ClangTidyContext *Context)

    : ClangTidyCheck(Name, Context),

      WantToUseSafeFunctions(Options.get("WantToUseSafeFunctions", 1)) {}

      WantToUseSafeFunctions(Options.get("WantToUseSafeFunctions", true)) {}



void NotNullTerminatedResultCheck::storeOptions(

    ClangTidyOptions::OptionMap &Opts) {

clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.h

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ private: 
  // If non-zero it is specifying if the target environment is considered to

  // implement '_s' suffixed memory and string handler functions which are safer

  // than older version (e.g. 'memcpy_s()'). The default value is '1'.

  const int WantToUseSafeFunctions;

  const bool WantToUseSafeFunctions;



  bool UseSafeFunctions = false;

clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp

+4 −4
Original line number Diff line number Diff line
@@ -60,12 +60,12 @@ CharUnits getSizeOfType(const ASTContext &Ctx, const Type *Ty) { 
SizeofExpressionCheck::SizeofExpressionCheck(StringRef Name,

                                             ClangTidyContext *Context)

    : ClangTidyCheck(Name, Context),

      WarnOnSizeOfConstant(Options.get("WarnOnSizeOfConstant", 1) != 0),

      WarnOnSizeOfConstant(Options.get("WarnOnSizeOfConstant", true)),

      WarnOnSizeOfIntegerExpression(

          Options.get("WarnOnSizeOfIntegerExpression", 0) != 0),

      WarnOnSizeOfThis(Options.get("WarnOnSizeOfThis", 1) != 0),

          Options.get("WarnOnSizeOfIntegerExpression", false)),

      WarnOnSizeOfThis(Options.get("WarnOnSizeOfThis", true)),

      WarnOnSizeOfCompareToConstant(

          Options.get("WarnOnSizeOfCompareToConstant", 1) != 0) {}

          Options.get("WarnOnSizeOfCompareToConstant", true)) {}



void SizeofExpressionCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {

  Options.store(Opts, "WarnOnSizeOfConstant", WarnOnSizeOfConstant);

clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ AST_MATCHER_P(IntegerLiteral, isBiggerThan, unsigned, N) { 
StringConstructorCheck::StringConstructorCheck(StringRef Name,

                                               ClangTidyContext *Context)

    : ClangTidyCheck(Name, Context),

      WarnOnLargeLength(Options.get("WarnOnLargeLength", 1) != 0),

      WarnOnLargeLength(Options.get("WarnOnLargeLength", true)),

      LargeLengthThreshold(Options.get("LargeLengthThreshold", 0x800000)) {}



void StringConstructorCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {