Commit 6656e961 authored by Alexandre Ganea's avatar Alexandre Ganea
Browse files

[mlir] Fix compilation warnings 

Fixes:
- (MSVC) F:\llvm-project\mlir\lib\Dialect\Linalg\Analysis\DependenceAnalysis.cpp(103): warning C4551: function call missing argument list
- (Clang) tools\mlir\lib\Dialect\SPIRV\SPIRVCanonicalization.inc(232,1): warning: unused function 'populateWithGenerated' [-Wunused-function]
parent 316f6003

mlir/lib/Dialect/Linalg/Analysis/DependenceAnalysis.cpp

+2 −1
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ using namespace mlir::linalg; 


using llvm::dbgs;



#ifndef NDEBUG

static StringRef toStringRef(LinalgDependenceGraph::DependenceType dt) {

  switch (dt) {

  case LinalgDependenceGraph::DependenceType::RAW:
@@ -39,6 +40,7 @@ static StringRef toStringRef(LinalgDependenceGraph::DependenceType dt) { 
  }

  llvm_unreachable("Unexpected DependenceType");

}

#endif



Value Aliases::find(Value v) {

  if (v.isa<BlockArgument>())
@@ -100,7 +102,6 @@ void LinalgDependenceGraph::addDependenceElem(DependenceType dt, 
                                              LinalgOpView dependentOpView) {

  LLVM_DEBUG(dbgs() << "\nAdd dep type " << toStringRef(dt) << ":\t"

                    << *indexingOpView.op << " -> " << *dependentOpView.op);

  (void)toStringRef;

  dependencesFromGraphs[dt][indexingOpView.op].push_back(

      LinalgDependenceGraphElem{dependentOpView, indexingOpView.view});

  dependencesIntoGraphs[dt][dependentOpView.op].push_back(

mlir/tools/mlir-tblgen/RewriterGen.cpp

+5 −2
Original line number Diff line number Diff line
@@ -1020,8 +1020,11 @@ static void emitRewriters(const RecordKeeper &recordKeeper, raw_ostream &os) { 
  }



  // Emit function to add the generated matchers to the pattern list.

  os << "void __attribute__((unused)) populateWithGenerated(MLIRContext "

        "*context, "

  os << "void\n";

  os << "#if !defined(_MSC_VER) || defined(__clang__)\n";

  os << "__attribute__((unused))\n";

  os << "#endif\n";

  os << "populateWithGenerated(MLIRContext *context, "

     << "OwningRewritePatternList *patterns) {\n";

  for (const auto &name : rewriterNames) {

    os << "  patterns->insert<" << name << ">(context);\n";