Commit 64e888ba authored by Rafael Espindola's avatar Rafael Espindola
Browse files

Set the file offset of zero sized sections. 

There is no reason not to do it and this matches what gold and bfd ld do.

llvm-svn: 244929
parent 556b21aa

lld/ELF/Writer.cpp

+0 −2
Original line number Diff line number Diff line
@@ -123,8 +123,6 @@ template <class ELFT> void OutputSection<ELFT>::setVA(uintX_t VA) { 
}



template <class ELFT> void OutputSection<ELFT>::setFileOffset(uintX_t Off) {

  if (Header.sh_size == 0)

    return;

  Header.sh_offset = Off;

}

lld/test/elf2/basic.s

+2 −2
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ _start: 
# CHECK-NEXT:       SHF_WRITE (0x1)

# CHECK-NEXT:     ]

# CHECK-NEXT:     Address: 0x2000

# CHECK-NEXT:     Offset: 0x0

# CHECK-NEXT:     Offset: 0x1010

# CHECK-NEXT:     Size: 0

# CHECK-NEXT:     Link: 0

# CHECK-NEXT:     Info: 0
@@ -91,7 +91,7 @@ _start: 
# CHECK-NEXT:       SHF_WRITE (0x1)

# CHECK-NEXT:     ]

# CHECK-NEXT:     Address: 0x2000

# CHECK-NEXT:     Offset: 0x0

# CHECK-NEXT:     Offset: 0x1010

# CHECK-NEXT:     Size: 0

# CHECK-NEXT:     Link: 0

# CHECK-NEXT:     Info: 0

lld/test/elf2/basic32.s

+2 −2
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ _start: 
# CHECK-NEXT:       SHF_WRITE (0x1)

# CHECK-NEXT:     ]

# CHECK-NEXT:     Address: 0x2000

# CHECK-NEXT:     Offset: 0x0

# CHECK-NEXT:     Offset: 0x1010

# CHECK-NEXT:     Size: 0

# CHECK-NEXT:     Link: 0

# CHECK-NEXT:     Info: 0
@@ -91,7 +91,7 @@ _start: 
# CHECK-NEXT:       SHF_WRITE (0x1)

# CHECK-NEXT:     ]

# CHECK-NEXT:     Address: 0x2000

# CHECK-NEXT:     Offset: 0x0

# CHECK-NEXT:     Offset: 0x1010

# CHECK-NEXT:     Size: 0

# CHECK-NEXT:     Link: 0

# CHECK-NEXT:     Info: 0

lld/test/elf2/basic32be.s

+2 −2
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ _start: 
# CHECK-NEXT:       SHF_WRITE (0x1)

# CHECK-NEXT:     ]

# CHECK-NEXT:     Address: 0x2000

# CHECK-NEXT:     Offset: 0x0

# CHECK-NEXT:     Offset: 0x1010

# CHECK-NEXT:     Size: 0

# CHECK-NEXT:     Link: 0

# CHECK-NEXT:     Info: 0
@@ -91,7 +91,7 @@ _start: 
# CHECK-NEXT:       SHF_WRITE (0x1)

# CHECK-NEXT:     ]

# CHECK-NEXT:     Address: 0x2000

# CHECK-NEXT:     Offset: 0x0

# CHECK-NEXT:     Offset: 0x1010

# CHECK-NEXT:     Size: 0

# CHECK-NEXT:     Link: 0

# CHECK-NEXT:     Info: 0

lld/test/elf2/basic64be.s

+2 −2
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ _start: 
# CHECK-NEXT:       SHF_WRITE (0x1)

# CHECK-NEXT:     ]

# CHECK-NEXT:     Address: 0x2000

# CHECK-NEXT:     Offset: 0x0

# CHECK-NEXT:     Offset: 0x1010

# CHECK-NEXT:     Size: 0

# CHECK-NEXT:     Link: 0

# CHECK-NEXT:     Info: 0
@@ -96,7 +96,7 @@ _start: 
# CHECK-NEXT:       SHF_WRITE (0x1)

# CHECK-NEXT:     ]

# CHECK-NEXT:     Address: 0x2000

# CHECK-NEXT:     Offset: 0x0

# CHECK-NEXT:     Offset: 0x1010

# CHECK-NEXT:     Size: 0

# CHECK-NEXT:     Link: 0

# CHECK-NEXT:     Info: 0