Commit 5e5ca787 authored by Chandler Carruth's avatar Chandler Carruth
Browse files

Merging r143917: 

------------------------------------------------------------------------
r143917 | chandlerc | 2011-11-07 01:17:31 -0800 (Mon, 07 Nov 2011) | 12 lines

Rip out one of the features I added for the driver-include-management.
We don't actually need a separate flag for non-sysrooted paths as the
driver has to manage the sysroot anyways. The driver is not infrequently
adding paths to the header search based on their existence on the
filesystem. For that, it has to add the sysroot anyways, we should pass
it on down to CC1 already joined. More importantly, the driver cannot in
all cases distinguish between sysrooted paths and paths that are
relative to the Clang binary's installation directory. Essentially, we
always need to ignore the system root for these internal header search
options. It turns out in most of the places we were already providing
the system root in the driver, and then another one in CC1 so this fixes
several bugs.
------------------------------------------------------------------------

llvm-svn: 143956
parent de9c697e

clang/include/clang/Driver/CC1Options.td

+0 −6
Original line number Diff line number Diff line
@@ -653,12 +653,6 @@ def internal_externc_isystem : JoinedOrSeparate<"-internal-externc-isystem">, 
           "implicit extern \"C\" semantics; these are assumed to not be "

           "user-provided and are used to model system and standard headers' "

           "paths.">;

def internal_nosysroot_isystem : JoinedOrSeparate<"-internal-nosysroot-isystem">,

  MetaVarName<"<directory>">,

  HelpText<"Add directory to the internal system include search path without "

           "applying a sysroot to it; these are assumed to not be "

           "user-provided and are used to model system and standard headers' "

           "paths.">;

def iprefix : JoinedOrSeparate<"-iprefix">, MetaVarName<"<prefix>">,

  HelpText<"Set the -iwithprefix/-iwithprefixbefore prefix">;

def iwithprefix : JoinedOrSeparate<"-iwithprefix">, MetaVarName<"<dir>">,

clang/lib/Driver/ToolChains.cpp

+2 −8
Original line number Diff line number Diff line
@@ -1927,12 +1927,9 @@ void Linux::AddClangSystemIncludeArgs(const ArgList &DriverArgs, 
    addSystemInclude(DriverArgs, CC1Args, D.SysRoot + "/usr/local/include");



  if (!DriverArgs.hasArg(options::OPT_nobuiltininc)) {

    // Ignore the sysroot, we *always* look for clang headers relative to

    // supplied path.

    llvm::sys::Path P(D.ResourceDir);

    P.appendComponent("include");

    CC1Args.push_back("-internal-nosysroot-isystem");

    CC1Args.push_back(DriverArgs.MakeArgString(P.str()));

    addSystemInclude(DriverArgs, CC1Args, P.str());

  }



  if (DriverArgs.hasArg(options::OPT_nostdlibinc))
@@ -2390,12 +2387,9 @@ void Windows::AddClangSystemIncludeArgs(const ArgList &DriverArgs, 
    return;



  if (!DriverArgs.hasArg(options::OPT_nobuiltininc)) {

    // Ignore the sysroot, we *always* look for clang headers relative to

    // supplied path.

    llvm::sys::Path P(getDriver().ResourceDir);

    P.appendComponent("include");

    CC1Args.push_back("-internal-nosysroot-isystem");

    CC1Args.push_back(DriverArgs.MakeArgString(P.str()));

    addSystemInclude(DriverArgs, CC1Args, P.str());

  }



  if (DriverArgs.hasArg(options::OPT_nostdlibinc))

clang/lib/Frontend/CompilerInvocation.cpp

+3 −8
Original line number Diff line number Diff line
@@ -571,9 +571,7 @@ static void HeaderSearchOptsToArgs(const HeaderSearchOptions &Opts, 
    } else {

      if (E.IsInternal) {

        assert(E.Group == frontend::System && "Unexpected header search group");

        if (E.IgnoreSysRoot)

          Res.push_back("-internal-nosysroot-isystem");

        else if (E.ImplicitExternC)

        if (E.ImplicitExternC)

          Res.push_back("-internal-externc-isystem");

        else

          Res.push_back("-internal-isystem");
@@ -1475,14 +1473,11 @@ static void ParseHeaderSearchArgs(HeaderSearchOptions &Opts, ArgList &Args) { 


  // Add the internal paths from a driver that detects standard include paths.

  for (arg_iterator I = Args.filtered_begin(OPT_internal_isystem,

                                            OPT_internal_externc_isystem,

                                            OPT_internal_nosysroot_isystem),

                                            OPT_internal_externc_isystem),

                    E = Args.filtered_end();

       I != E; ++I)

    Opts.AddPath((*I)->getValue(Args), frontend::System,

                 false, false,

                 (*I)->getOption().matches(OPT_internal_nosysroot_isystem),

                 /*IsInternal=*/true,

                 false, false, /*IgnoreSysRoot=*/true, /*IsInternal=*/true,

                 (*I)->getOption().matches(OPT_internal_externc_isystem));

}

clang/test/lit.cfg

+1 −2
Original line number Diff line number Diff line
@@ -157,8 +157,7 @@ def getClangBuiltinIncludeDir(clang): 
      lit.fatal("Couldn't find the include dir for Clang ('%s')" % clang)

    return cmd.stdout.read().strip()



config.substitutions.append( ('%clang_cc1',

                              '%s -cc1 -internal-nosysroot-isystem %s'

config.substitutions.append( ('%clang_cc1', '%s -cc1 -internal-isystem %s'

                              % (config.clang,

                                 getClangBuiltinIncludeDir(config.clang))) )