Commit 5ca7fa15 authored Jan 14, 2015 by Rafael Espindola

Handle a symbol being undefined.

This can happen if:
* It is present in a comdat in one file.
* It is not present in the comdat of the file that is kept.
* Is is not used.

This should fix the LTO boostrap.

Thanks to Takumi NAKAMURA for setting up the bot!

llvm-svn: 225983

parent 1cd3c71c

llvm/test/tools/gold/Inputs/comdat.ll

+5 −0

Original line number	Diff line number	Diff line
		$c2 = comdat any
		$c1 = comdat any

		; This is only present in this file. The linker will keep $c1 from the first
		; file and this will be undefined.
		@will_be_undefined = global i32 1, comdat($c1)

		@v1 = weak_odr global i32 41, comdat($c2)
		define weak_odr protected i32 @f1(i8* %this) comdat($c2) {

llvm/tools/gold/gold-plugin.cpp

+5 −1

Original line number	Diff line number	Diff line
		@@ -629,10 +629,14 @@ getModuleForFile(LLVMContext &Context, claimed_file &F, raw_fd_ostream *ApiFile,
		case LDPR_RESOLVED_IR:
		case LDPR_RESOLVED_EXEC:
		case LDPR_RESOLVED_DYN:
		case LDPR_UNDEF:
		assert(GV->isDeclarationForLinker());
		break;

		case LDPR_UNDEF:
		assert(GV->hasComdat());
		Drop.insert(GV);
		break;

		case LDPR_PREVAILING_DEF_IRONLY: {
		keepGlobalValue(*GV, KeptAliases);
		if (!Used.count(GV)) {