Unverified Commit 5bae3a0b authored by Jonas Devlieghere's avatar Jonas Devlieghere
Browse files

[lldb] Remove CompileUnit::SetSupportFiles overload (NFC) 

CompileUnit::SetSupportFiles had two overloads, one that took and lvalue
reference and one that takes an rvalue reference. This removes both and
replaces it with an overload that takes the FileSpecList by value and
moves it into the member variable.

Because we're storing the value as a member, this covers both cases. If
the new FileSpecList was passed by lvalue reference, we'd copy it into
the member anyway. If it was passed as an rvalue reference, we'll have
created a new instance using its move and then immediately move it again
into our member. In either case the number of copies remains unchanged.
parent 5175cd77

lldb/include/lldb/Symbol/CompileUnit.h

+1 −2
Original line number Diff line number Diff line
@@ -331,8 +331,7 @@ public: 
  ///     A line table object pointer that this object now owns.

  void SetLineTable(LineTable *line_table);



  void SetSupportFiles(const FileSpecList &support_files);

  void SetSupportFiles(FileSpecList &&support_files);

  void SetSupportFiles(FileSpecList support_files);



  void SetDebugMacros(const DebugMacrosSP &debug_macros);

lldb/source/Symbol/CompileUnit.cpp

+1 −5
Original line number Diff line number Diff line
@@ -178,11 +178,7 @@ void CompileUnit::SetLineTable(LineTable *line_table) { 
  m_line_table_up.reset(line_table);

}



void CompileUnit::SetSupportFiles(const FileSpecList &support_files) {

  m_support_files = support_files;

}



void CompileUnit::SetSupportFiles(FileSpecList &&support_files) {

void CompileUnit::SetSupportFiles(FileSpecList support_files) {

  m_support_files = std::move(support_files);

}