Commit 4d23764d authored by Reid Kleckner's avatar Reid Kleckner
Browse files

Fix -Wunused-result warnings in LLDB 

Three uses of try_lock intentionally ignore the result, as explained in
the comment. Make that explicit with a void cast.

Add what appears to be a missing return in the clang expression parser
code. It's a functional change, but presumably the right one.

Differential Revision: https://reviews.llvm.org/D70281
parent 0304360a

lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h

+1 −1
Original line number Diff line number Diff line
@@ -312,7 +312,7 @@ private: 
      if (m_exe_ctx.GetTargetPtr())

        return m_exe_ctx.GetTargetPtr();

      else if (m_sym_ctx.target_sp)

        m_sym_ctx.target_sp.get();

        return m_sym_ctx.target_sp.get();

      return nullptr;

    }

lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp

+3 −3
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ bool OperatingSystemPython::UpdateThreadList(ThreadList &old_thread_list, 
  Target &target = m_process->GetTarget();

  std::unique_lock<std::recursive_mutex> api_lock(target.GetAPIMutex(),

                                                  std::defer_lock);

  api_lock.try_lock();

  (void)api_lock.try_lock(); // See above.

  auto interpreter_lock = m_interpreter->AcquireInterpreterLock();



  LLDB_LOGF(log,
@@ -308,7 +308,7 @@ OperatingSystemPython::CreateRegisterContextForThread(Thread *thread, 
  Target &target = m_process->GetTarget();

  std::unique_lock<std::recursive_mutex> api_lock(target.GetAPIMutex(),

                                                  std::defer_lock);

  api_lock.try_lock();

  (void)api_lock.try_lock(); // See above.

  auto interpreter_lock = m_interpreter->AcquireInterpreterLock();



  Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_THREAD));
@@ -395,7 +395,7 @@ lldb::ThreadSP OperatingSystemPython::CreateThread(lldb::tid_t tid, 
    Target &target = m_process->GetTarget();

    std::unique_lock<std::recursive_mutex> api_lock(target.GetAPIMutex(),

                                                    std::defer_lock);

    api_lock.try_lock();

    (void)api_lock.try_lock(); // See above.

    auto interpreter_lock = m_interpreter->AcquireInterpreterLock();



    StructuredData::DictionarySP thread_info_dict =