Commit 497a754a authored by Adam Balogh's avatar Adam Balogh
Browse files

[Clang-Tidy] Quick fix for bug in bugprone-macro-parentheses 43804 

Applying parentheses for statement leads to compilation error. Bug
[[ 43804 | https://bugs.llvm.org/show_bug.cgi?id=43804 ]] is a
compilation error suggested by a wrong fix of this checker. This
patch is a quick fix for this issue.

Differential Revision: https://reviews.llvm.org/D70850
parent 269c1c70

clang-tools-extra/clang-tidy/bugprone/MacroParenthesesCheck.cpp

+1 −1
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ static bool isSurroundedRight(const Token &T) { 
/// Is given TokenKind a keyword?

static bool isKeyword(const Token &T) {

  // FIXME: better matching of keywords to avoid false positives.

  return T.isOneOf(tok::kw_case, tok::kw_const, tok::kw_struct);

  return T.isOneOf(tok::kw_if, tok::kw_case, tok::kw_const, tok::kw_struct);

}



/// Warning is written when one of these operators are not within parentheses.

clang-tools-extra/test/clang-tidy/checkers/bugprone-macro-parentheses.cpp

+1 −0
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ 
#define GOOD30(args...)   std::cout << args;

#define GOOD31(X)         A*X=2

#define GOOD32(X)         std::vector<X>

#define GOOD33(x)         if (!a__##x) a_##x = &f(#x)



// These are allowed for now..

#define MAYBE1            *12.34