Commit 47caa691 authored by Jon Roelofs's avatar Jon Roelofs
Browse files

[clang-tidy] Use ; as separator for HeaderFileExtensions 

... and deprecate use of ',' for the same.

https://reviews.llvm.org/D75621
parent 3486cc01

clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp

+2 −1
Original line number Diff line number Diff line
@@ -32,7 +32,8 @@ DynamicStaticInitializersCheck::DynamicStaticInitializersCheck(StringRef Name, 
      RawStringHeaderFileExtensions(Options.getLocalOrGlobal(

        "HeaderFileExtensions", utils::defaultHeaderFileExtensions())) {

  if (!utils::parseFileExtensions(RawStringHeaderFileExtensions,

                                  HeaderFileExtensions, ',')) {

                                  HeaderFileExtensions,

                                  utils::defaultFileExtensionDelimiters())) {

    llvm::errs() << "Invalid header file extension: "

                 << RawStringHeaderFileExtensions << "\n";

  }

clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.h

+5 −4
Original line number Diff line number Diff line
@@ -19,11 +19,12 @@ namespace bugprone { 
/// Finds dynamically initialized static variables in header files.

///

/// The check supports these options:

///   - `HeaderFileExtensions`: a comma-separated list of filename extensions of

///     header files (The filename extensions should not contain "." prefix).

///     "h,hh,hpp,hxx" by default.

///   - `HeaderFileExtensions`: a semicolon-separated list of filename

///     extensions of header files (The filename extensions should not contain

///     "." prefix). ";h;hh;hpp;hxx" by default.

//

///     For extension-less header files, using an empty string or leaving an

///     empty string between "," if there are other filename extensions.

///     empty string between ";" if there are other filename extensions.

class DynamicStaticInitializersCheck : public ClangTidyCheck {

public:

  DynamicStaticInitializersCheck(StringRef Name, ClangTidyContext *Context);

clang-tools-extra/clang-tidy/google/GlobalNamesInHeadersCheck.cpp

+2 −1
Original line number Diff line number Diff line
@@ -25,7 +25,8 @@ GlobalNamesInHeadersCheck::GlobalNamesInHeadersCheck(StringRef Name, 
      RawStringHeaderFileExtensions(Options.getLocalOrGlobal(

          "HeaderFileExtensions", utils::defaultHeaderFileExtensions())) {

  if (!utils::parseFileExtensions(RawStringHeaderFileExtensions,

                                  HeaderFileExtensions, ',')) {

                                  HeaderFileExtensions,

                                  utils::defaultFileExtensionDelimiters())) {

    llvm::errs() << "Invalid header file extension: "

                 << RawStringHeaderFileExtensions << "\n";

  }

clang-tools-extra/clang-tidy/google/GlobalNamesInHeadersCheck.h

+5 −4
Original line number Diff line number Diff line
@@ -21,11 +21,12 @@ namespace readability { 
/// Right now it only triggers on using declarations and directives.

///

/// The check supports these options:

///   - `HeaderFileExtensions`: a comma-separated list of filename extensions

///     of header files (the filename extensions should not contain "." prefix).

///     "h" by default.

///   - `HeaderFileExtensions`: a semicolon-separated list of filename

///     extensions of header files (the filename extensions should not contain

///     "." prefix). ";h;hh;hpp;hxx" by default.

///

///     For extension-less header files, using an empty string or leaving an

///     empty string between "," if there are other filename extensions.

///     empty string between ";" if there are other filename extensions.

class GlobalNamesInHeadersCheck : public ClangTidyCheck {

public:

  GlobalNamesInHeadersCheck(StringRef Name, ClangTidyContext *Context);

clang-tools-extra/clang-tidy/google/UnnamedNamespaceInHeaderCheck.cpp

+2 −1
Original line number Diff line number Diff line
@@ -24,7 +24,8 @@ UnnamedNamespaceInHeaderCheck::UnnamedNamespaceInHeaderCheck( 
      RawStringHeaderFileExtensions(Options.getLocalOrGlobal(

          "HeaderFileExtensions", utils::defaultHeaderFileExtensions())) {

  if (!utils::parseFileExtensions(RawStringHeaderFileExtensions,

                                  HeaderFileExtensions, ',')) {

                                  HeaderFileExtensions,

                                  utils::defaultFileExtensionDelimiters())) {

    llvm::errs() << "Invalid header file extension: "

                 << RawStringHeaderFileExtensions << "\n";

  }