Commit 43830790 authored by Jay Foad's avatar Jay Foad
Browse files

[AMDGPU] Remove dubious logic in bidirectional list scheduler 

Summary:
pickNodeBidirectional tried to compare the best top candidate and the
best bottom candidate by examining TopCand.Reason and BotCand.Reason.
This is unsound because, after calling pickNodeFromQueue, Cand.Reason
does not reflect the most important reason why Cand was chosen. Rather
it reflects the most recent reason why it beat some other potential
candidate, which could have been for some low priority tie breaker
reason.

I have seen this cause problems where TopCand is a good candidate, but
because TopCand.Reason is ORDER (which is very low priority) it is
repeatedly ignored in favour of a mediocre BotCand. This is not how
bidirectional scheduling is supposed to work.

To fix this I changed the code to always compare TopCand and BotCand
directly, like the generic implementation of pickNodeBidirectional does.
This removes some uncommented AMDGPU-specific logic; if this logic turns
out to be important then perhaps it could be moved into an override of
tryCandidate instead.

Graphics shader benchmarking on gfx10 shows a lot more positive than
negative effects from this change.

Reviewers: arsenm, tstellar, rampitec, kzhuravl, vpykhtin, dstuttard, tpr, atrick, MatzeB

Subscribers: jvesely, wdng, nhaehnle, yaxunl, t-tye, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68338
parent 0a2d415b

llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp

+5 −27
Original line number Diff line number Diff line
@@ -233,33 +233,11 @@ SUnit *GCNMaxOccupancySchedStrategy::pickNodeBidirectional(bool &IsTopNode) { 
  // Pick best from BotCand and TopCand.

  LLVM_DEBUG(dbgs() << "Top Cand: "; traceCandidate(TopCand);

             dbgs() << "Bot Cand: "; traceCandidate(BotCand););

  SchedCandidate Cand;

  if (TopCand.Reason == BotCand.Reason) {

    Cand = BotCand;

    GenericSchedulerBase::CandReason TopReason = TopCand.Reason;

  SchedCandidate Cand = BotCand;

  TopCand.Reason = NoCand;

  GenericScheduler::tryCandidate(Cand, TopCand, nullptr);

  if (TopCand.Reason != NoCand) {

    Cand.setBest(TopCand);

    } else {

      TopCand.Reason = TopReason;

    }

  } else {

    if (TopCand.Reason == RegExcess && TopCand.RPDelta.Excess.getUnitInc() <= 0) {

      Cand = TopCand;

    } else if (BotCand.Reason == RegExcess && BotCand.RPDelta.Excess.getUnitInc() <= 0) {

      Cand = BotCand;

    } else if (TopCand.Reason == RegCritical && TopCand.RPDelta.CriticalMax.getUnitInc() <= 0) {

      Cand = TopCand;

    } else if (BotCand.Reason == RegCritical && BotCand.RPDelta.CriticalMax.getUnitInc() <= 0) {

      Cand = BotCand;

    } else {

      if (BotCand.Reason > TopCand.Reason) {

        Cand = TopCand;

      } else {

        Cand = BotCand;

      }

    }

  }

  LLVM_DEBUG(dbgs() << "Picking: "; traceCandidate(Cand););

llvm/test/CodeGen/AMDGPU/GlobalISel/bswap.ll

+12 −12
Original line number Diff line number Diff line
@@ -374,10 +374,10 @@ define i16 @v_bswap_i16(i16 %src) { 
; GFX7-LABEL: v_bswap_i16:

; GFX7:       ; %bb.0:

; GFX7-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)

; GFX7-NEXT:    v_and_b32_e32 v1, 0xffff, v0

; GFX7-NEXT:    v_lshlrev_b32_e32 v0, 8, v0

; GFX7-NEXT:    v_lshrrev_b32_e32 v1, 8, v1

; GFX7-NEXT:    v_or_b32_e32 v0, v1, v0

; GFX7-NEXT:    v_lshlrev_b32_e32 v1, 8, v0

; GFX7-NEXT:    v_and_b32_e32 v0, 0xffff, v0

; GFX7-NEXT:    v_lshrrev_b32_e32 v0, 8, v0

; GFX7-NEXT:    v_or_b32_e32 v0, v0, v1

; GFX7-NEXT:    s_setpc_b64 s[30:31]

;

; GFX8-LABEL: v_bswap_i16:
@@ -440,10 +440,10 @@ define i32 @v_bswap_i16_zext_to_i32(i16 %src) { 
; GFX7-LABEL: v_bswap_i16_zext_to_i32:

; GFX7:       ; %bb.0:

; GFX7-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)

; GFX7-NEXT:    v_and_b32_e32 v1, 0xffff, v0

; GFX7-NEXT:    v_lshlrev_b32_e32 v0, 8, v0

; GFX7-NEXT:    v_lshrrev_b32_e32 v1, 8, v1

; GFX7-NEXT:    v_or_b32_e32 v0, v1, v0

; GFX7-NEXT:    v_lshlrev_b32_e32 v1, 8, v0

; GFX7-NEXT:    v_and_b32_e32 v0, 0xffff, v0

; GFX7-NEXT:    v_lshrrev_b32_e32 v0, 8, v0

; GFX7-NEXT:    v_or_b32_e32 v0, v0, v1

; GFX7-NEXT:    v_bfe_u32 v0, v0, 0, 16

; GFX7-NEXT:    s_setpc_b64 s[30:31]

;
@@ -469,10 +469,10 @@ define i32 @v_bswap_i16_sext_to_i32(i16 %src) { 
; GFX7-LABEL: v_bswap_i16_sext_to_i32:

; GFX7:       ; %bb.0:

; GFX7-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)

; GFX7-NEXT:    v_and_b32_e32 v1, 0xffff, v0

; GFX7-NEXT:    v_lshlrev_b32_e32 v0, 8, v0

; GFX7-NEXT:    v_lshrrev_b32_e32 v1, 8, v1

; GFX7-NEXT:    v_or_b32_e32 v0, v1, v0

; GFX7-NEXT:    v_lshlrev_b32_e32 v1, 8, v0

; GFX7-NEXT:    v_and_b32_e32 v0, 0xffff, v0

; GFX7-NEXT:    v_lshrrev_b32_e32 v0, 8, v0

; GFX7-NEXT:    v_or_b32_e32 v0, v0, v1

; GFX7-NEXT:    v_bfe_i32 v0, v0, 0, 16

; GFX7-NEXT:    s_setpc_b64 s[30:31]

;

llvm/test/CodeGen/AMDGPU/GlobalISel/fpow.ll

+47 −47
Original line number Diff line number Diff line
@@ -126,21 +126,21 @@ define <2 x half> @v_pow_v2f16(<2 x half> %x, <2 x half> %y) { 
; GFX8-LABEL: v_pow_v2f16:

; GFX8:       ; %bb.0:

; GFX8-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)

; GFX8-NEXT:    v_log_f16_sdwa v2, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_log_f16_e32 v0, v0

; GFX8-NEXT:    v_cvt_f32_f16_sdwa v3, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_cvt_f32_f16_e32 v1, v1

; GFX8-NEXT:    v_log_f16_e32 v2, v0

; GFX8-NEXT:    v_log_f16_sdwa v0, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_cvt_f32_f16_e32 v3, v1

; GFX8-NEXT:    v_cvt_f32_f16_sdwa v1, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_cvt_f32_f16_e32 v2, v2

; GFX8-NEXT:    v_cvt_f32_f16_e32 v0, v0

; GFX8-NEXT:    v_mul_legacy_f32_e32 v2, v2, v3

; GFX8-NEXT:    v_mul_legacy_f32_e32 v0, v0, v1

; GFX8-NEXT:    v_cvt_f16_f32_e32 v1, v2

; GFX8-NEXT:    v_cvt_f16_f32_e32 v0, v0

; GFX8-NEXT:    v_cvt_f16_f32_e32 v1, v2

; GFX8-NEXT:    v_mov_b32_e32 v2, 16

; GFX8-NEXT:    v_exp_f16_e32 v1, v1

; GFX8-NEXT:    v_exp_f16_e32 v0, v0

; GFX8-NEXT:    v_lshlrev_b32_sdwa v1, v2, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_0

; GFX8-NEXT:    v_or_b32_sdwa v0, v0, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_0 src1_sel:DWORD

; GFX8-NEXT:    v_exp_f16_e32 v1, v1

; GFX8-NEXT:    v_lshlrev_b32_sdwa v0, v2, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_0

; GFX8-NEXT:    v_or_b32_sdwa v0, v1, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_0 src1_sel:DWORD

; GFX8-NEXT:    s_setpc_b64 s[30:31]

;

; GFX9-LABEL: v_pow_v2f16:
@@ -154,11 +154,11 @@ define <2 x half> @v_pow_v2f16(<2 x half> %x, <2 x half> %y) { 
; GFX9-NEXT:    v_cvt_f32_f16_e32 v0, v0

; GFX9-NEXT:    v_mul_legacy_f32_e32 v2, v2, v3

; GFX9-NEXT:    v_mul_legacy_f32_e32 v0, v0, v1

; GFX9-NEXT:    v_cvt_f16_f32_e32 v1, v2

; GFX9-NEXT:    v_cvt_f16_f32_e32 v0, v0

; GFX9-NEXT:    v_mov_b32_e32 v2, 0xffff

; GFX9-NEXT:    v_exp_f16_e32 v1, v1

; GFX9-NEXT:    v_cvt_f16_f32_e32 v2, v2

; GFX9-NEXT:    v_exp_f16_sdwa v0, v0 dst_sel:WORD_1 dst_unused:UNUSED_PAD src0_sel:DWORD

; GFX9-NEXT:    v_exp_f16_e32 v1, v2

; GFX9-NEXT:    v_mov_b32_e32 v2, 0xffff

; GFX9-NEXT:    v_and_or_b32 v0, v1, v2, v0

; GFX9-NEXT:    s_setpc_b64 s[30:31]

  %pow = call <2 x half> @llvm.pow.v2f16(<2 x half> %x, <2 x half> %y)
@@ -173,40 +173,40 @@ define <2 x half> @v_pow_v2f16_fneg_lhs(<2 x half> %x, <2 x half> %y) { 
; GFX6-NEXT:    v_and_b32_e32 v0, 0xffff, v0

; GFX6-NEXT:    v_or_b32_e32 v0, v1, v0

; GFX6-NEXT:    v_xor_b32_e32 v0, 0x80008000, v0

; GFX6-NEXT:    v_lshrrev_b32_e32 v1, 16, v0

; GFX6-NEXT:    v_cvt_f32_f16_e32 v1, v0

; GFX6-NEXT:    v_lshrrev_b32_e32 v0, 16, v0

; GFX6-NEXT:    v_cvt_f32_f16_e32 v0, v0

; GFX6-NEXT:    v_cvt_f32_f16_e32 v1, v1

; GFX6-NEXT:    v_cvt_f32_f16_e32 v2, v2

; GFX6-NEXT:    v_log_f32_e32 v1, v1

; GFX6-NEXT:    v_cvt_f32_f16_e32 v3, v3

; GFX6-NEXT:    v_log_f32_e32 v0, v0

; GFX6-NEXT:    v_log_f32_e32 v1, v1

; GFX6-NEXT:    v_mul_legacy_f32_e32 v0, v0, v2

; GFX6-NEXT:    v_mul_legacy_f32_e32 v1, v1, v3

; GFX6-NEXT:    v_exp_f32_e32 v0, v0

; GFX6-NEXT:    v_mul_legacy_f32_e32 v1, v1, v2

; GFX6-NEXT:    v_exp_f32_e32 v1, v1

; GFX6-NEXT:    v_cvt_f16_f32_e32 v0, v0

; GFX6-NEXT:    v_cvt_f16_f32_e32 v1, v1

; GFX6-NEXT:    v_mul_legacy_f32_e32 v0, v0, v3

; GFX6-NEXT:    v_exp_f32_e32 v2, v0

; GFX6-NEXT:    v_cvt_f16_f32_e32 v0, v1

; GFX6-NEXT:    v_cvt_f16_f32_e32 v1, v2

; GFX6-NEXT:    s_setpc_b64 s[30:31]

;

; GFX8-LABEL: v_pow_v2f16_fneg_lhs:

; GFX8:       ; %bb.0:

; GFX8-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)

; GFX8-NEXT:    v_xor_b32_e32 v0, 0x80008000, v0

; GFX8-NEXT:    v_log_f16_sdwa v2, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_log_f16_e32 v0, v0

; GFX8-NEXT:    v_cvt_f32_f16_sdwa v3, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_cvt_f32_f16_e32 v1, v1

; GFX8-NEXT:    v_log_f16_e32 v2, v0

; GFX8-NEXT:    v_log_f16_sdwa v0, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_cvt_f32_f16_e32 v3, v1

; GFX8-NEXT:    v_cvt_f32_f16_sdwa v1, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_cvt_f32_f16_e32 v2, v2

; GFX8-NEXT:    v_cvt_f32_f16_e32 v0, v0

; GFX8-NEXT:    v_mul_legacy_f32_e32 v2, v2, v3

; GFX8-NEXT:    v_mul_legacy_f32_e32 v0, v0, v1

; GFX8-NEXT:    v_cvt_f16_f32_e32 v1, v2

; GFX8-NEXT:    v_cvt_f16_f32_e32 v0, v0

; GFX8-NEXT:    v_cvt_f16_f32_e32 v1, v2

; GFX8-NEXT:    v_mov_b32_e32 v2, 16

; GFX8-NEXT:    v_exp_f16_e32 v1, v1

; GFX8-NEXT:    v_exp_f16_e32 v0, v0

; GFX8-NEXT:    v_lshlrev_b32_sdwa v1, v2, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_0

; GFX8-NEXT:    v_or_b32_sdwa v0, v0, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_0 src1_sel:DWORD

; GFX8-NEXT:    v_exp_f16_e32 v1, v1

; GFX8-NEXT:    v_lshlrev_b32_sdwa v0, v2, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_0

; GFX8-NEXT:    v_or_b32_sdwa v0, v1, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_0 src1_sel:DWORD

; GFX8-NEXT:    s_setpc_b64 s[30:31]

;

; GFX9-LABEL: v_pow_v2f16_fneg_lhs:
@@ -259,22 +259,22 @@ define <2 x half> @v_pow_v2f16_fneg_rhs(<2 x half> %x, <2 x half> %y) { 
; GFX8-LABEL: v_pow_v2f16_fneg_rhs:

; GFX8:       ; %bb.0:

; GFX8-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)

; GFX8-NEXT:    v_log_f16_sdwa v2, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_log_f16_e32 v0, v0

; GFX8-NEXT:    v_log_f16_e32 v2, v0

; GFX8-NEXT:    v_log_f16_sdwa v0, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_xor_b32_e32 v1, 0x80008000, v1

; GFX8-NEXT:    v_cvt_f32_f16_sdwa v3, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_cvt_f32_f16_e32 v2, v2

; GFX8-NEXT:    v_cvt_f32_f16_e32 v3, v1

; GFX8-NEXT:    v_cvt_f32_f16_sdwa v1, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_cvt_f32_f16_e32 v0, v0

; GFX8-NEXT:    v_cvt_f32_f16_e32 v1, v1

; GFX8-NEXT:    v_mul_legacy_f32_e32 v2, v2, v3

; GFX8-NEXT:    v_cvt_f16_f32_e32 v2, v2

; GFX8-NEXT:    v_cvt_f32_f16_e32 v2, v2

; GFX8-NEXT:    v_mul_legacy_f32_e32 v0, v0, v1

; GFX8-NEXT:    v_cvt_f16_f32_e32 v0, v0

; GFX8-NEXT:    v_exp_f16_e32 v1, v2

; GFX8-NEXT:    v_mul_legacy_f32_e32 v2, v2, v3

; GFX8-NEXT:    v_cvt_f16_f32_e32 v1, v2

; GFX8-NEXT:    v_mov_b32_e32 v2, 16

; GFX8-NEXT:    v_exp_f16_e32 v0, v0

; GFX8-NEXT:    v_lshlrev_b32_sdwa v1, v2, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_0

; GFX8-NEXT:    v_or_b32_sdwa v0, v0, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_0 src1_sel:DWORD

; GFX8-NEXT:    v_exp_f16_e32 v1, v1

; GFX8-NEXT:    v_lshlrev_b32_sdwa v0, v2, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_0

; GFX8-NEXT:    v_or_b32_sdwa v0, v1, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_0 src1_sel:DWORD

; GFX8-NEXT:    s_setpc_b64 s[30:31]

;

; GFX9-LABEL: v_pow_v2f16_fneg_rhs:
@@ -336,22 +336,22 @@ define <2 x half> @v_pow_v2f16_fneg_lhs_rhs(<2 x half> %x, <2 x half> %y) { 
; GFX8-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)

; GFX8-NEXT:    s_mov_b32 s4, 0x80008000

; GFX8-NEXT:    v_xor_b32_e32 v0, s4, v0

; GFX8-NEXT:    v_log_f16_sdwa v2, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_log_f16_e32 v0, v0

; GFX8-NEXT:    v_log_f16_e32 v2, v0

; GFX8-NEXT:    v_log_f16_sdwa v0, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_xor_b32_e32 v1, s4, v1

; GFX8-NEXT:    v_cvt_f32_f16_sdwa v3, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_cvt_f32_f16_e32 v2, v2

; GFX8-NEXT:    v_cvt_f32_f16_e32 v3, v1

; GFX8-NEXT:    v_cvt_f32_f16_sdwa v1, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_1

; GFX8-NEXT:    v_cvt_f32_f16_e32 v0, v0

; GFX8-NEXT:    v_cvt_f32_f16_e32 v1, v1

; GFX8-NEXT:    v_mul_legacy_f32_e32 v2, v2, v3

; GFX8-NEXT:    v_cvt_f16_f32_e32 v2, v2

; GFX8-NEXT:    v_cvt_f32_f16_e32 v2, v2

; GFX8-NEXT:    v_mul_legacy_f32_e32 v0, v0, v1

; GFX8-NEXT:    v_cvt_f16_f32_e32 v0, v0

; GFX8-NEXT:    v_exp_f16_e32 v1, v2

; GFX8-NEXT:    v_mul_legacy_f32_e32 v2, v2, v3

; GFX8-NEXT:    v_cvt_f16_f32_e32 v1, v2

; GFX8-NEXT:    v_mov_b32_e32 v2, 16

; GFX8-NEXT:    v_exp_f16_e32 v0, v0

; GFX8-NEXT:    v_lshlrev_b32_sdwa v1, v2, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_0

; GFX8-NEXT:    v_or_b32_sdwa v0, v0, v1 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_0 src1_sel:DWORD

; GFX8-NEXT:    v_exp_f16_e32 v1, v1

; GFX8-NEXT:    v_lshlrev_b32_sdwa v0, v2, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:DWORD src1_sel:WORD_0

; GFX8-NEXT:    v_or_b32_sdwa v0, v1, v0 dst_sel:DWORD dst_unused:UNUSED_PAD src0_sel:WORD_0 src1_sel:DWORD

; GFX8-NEXT:    s_setpc_b64 s[30:31]

;

; GFX9-LABEL: v_pow_v2f16_fneg_lhs_rhs:

llvm/test/CodeGen/AMDGPU/GlobalISel/insertelement.ll

+41 −28
Original line number Diff line number Diff line
@@ -233,34 +233,41 @@ define amdgpu_ps <8 x float> @dyn_insertelement_v8f32_s_s_v(<8 x float> inreg %v 
; MOVREL-NEXT:    s_mov_b32 s4, s6

; MOVREL-NEXT:    s_mov_b32 s6, s8

; MOVREL-NEXT:    v_mov_b32_e32 v16, s7

; MOVREL-NEXT:    v_mov_b32_e32 v8, v0

; MOVREL-NEXT:    v_mov_b32_e32 v14, s5

; MOVREL-NEXT:    v_mov_b32_e32 v12, s3

; MOVREL-NEXT:    v_mov_b32_e32 v13, s4

; MOVREL-NEXT:    v_mov_b32_e32 v15, s6

; MOVREL-NEXT:    v_mov_b32_e32 v12, s3

; MOVREL-NEXT:    v_mov_b32_e32 v11, s2

; MOVREL-NEXT:    v_mov_b32_e32 v10, s1

; MOVREL-NEXT:    v_mov_b32_e32 v9, s0

; MOVREL-NEXT:    s_mov_b32 s0, exec_lo

; MOVREL-NEXT:    ; implicit-def: $vcc_hi

; MOVREL-NEXT:  BB3_1: ; =>This Inner Loop Header: Depth=1

; MOVREL-NEXT:    v_readfirstlane_b32 s1, v8

; MOVREL-NEXT:    v_mov_b32_e32 v0, v9

; MOVREL-NEXT:    v_mov_b32_e32 v1, v10

; MOVREL-NEXT:    v_mov_b32_e32 v2, v11

; MOVREL-NEXT:    v_mov_b32_e32 v3, v12

; MOVREL-NEXT:    v_cmp_eq_u32_e32 vcc_lo, s1, v8

; MOVREL-NEXT:    v_readfirstlane_b32 s1, v0

; MOVREL-NEXT:    v_mov_b32_e32 v1, v9

; MOVREL-NEXT:    v_mov_b32_e32 v2, v10

; MOVREL-NEXT:    v_mov_b32_e32 v3, v11

; MOVREL-NEXT:    v_mov_b32_e32 v4, v12

; MOVREL-NEXT:    v_cmp_eq_u32_e32 vcc_lo, s1, v0

; MOVREL-NEXT:    s_mov_b32 m0, s1

; MOVREL-NEXT:    v_mov_b32_e32 v4, v13

; MOVREL-NEXT:    v_mov_b32_e32 v5, v14

; MOVREL-NEXT:    v_mov_b32_e32 v6, v15

; MOVREL-NEXT:    v_mov_b32_e32 v7, v16

; MOVREL-NEXT:    v_movreld_b32_e32 v0, s10

; MOVREL-NEXT:    v_mov_b32_e32 v5, v13

; MOVREL-NEXT:    v_mov_b32_e32 v6, v14

; MOVREL-NEXT:    v_mov_b32_e32 v7, v15

; MOVREL-NEXT:    v_mov_b32_e32 v8, v16

; MOVREL-NEXT:    v_movreld_b32_e32 v1, s10

; MOVREL-NEXT:    s_and_saveexec_b32 vcc_lo, vcc_lo

; MOVREL-NEXT:    s_xor_b32 exec_lo, exec_lo, vcc_lo

; MOVREL-NEXT:    s_cbranch_execnz BB3_1

; MOVREL-NEXT:  ; %bb.2:

; MOVREL-NEXT:    s_mov_b32 exec_lo, s0

; MOVREL-NEXT:    v_mov_b32_e32 v0, v1

; MOVREL-NEXT:    v_mov_b32_e32 v1, v2

; MOVREL-NEXT:    v_mov_b32_e32 v2, v3

; MOVREL-NEXT:    v_mov_b32_e32 v3, v4

; MOVREL-NEXT:    v_mov_b32_e32 v4, v5

; MOVREL-NEXT:    v_mov_b32_e32 v5, v6

; MOVREL-NEXT:    v_mov_b32_e32 v6, v7

; MOVREL-NEXT:    v_mov_b32_e32 v7, v8

; MOVREL-NEXT:    ; return to shader part epilog

entry:

  %insert = insertelement <8 x float> %vec, float %val, i32 %idx
@@ -393,35 +400,41 @@ define amdgpu_ps <8 x float> @dyn_insertelement_v8f32_s_v_v(<8 x float> inreg %v 
; MOVREL-NEXT:    s_mov_b32 s4, s6

; MOVREL-NEXT:    s_mov_b32 s6, s8

; MOVREL-NEXT:    v_mov_b32_e32 v17, s7

; MOVREL-NEXT:    v_mov_b32_e32 v8, v0

; MOVREL-NEXT:    v_mov_b32_e32 v9, v1

; MOVREL-NEXT:    v_mov_b32_e32 v15, s5

; MOVREL-NEXT:    v_mov_b32_e32 v16, s6

; MOVREL-NEXT:    v_mov_b32_e32 v14, s4

; MOVREL-NEXT:    v_mov_b32_e32 v13, s3

; MOVREL-NEXT:    v_mov_b32_e32 v14, s4

; MOVREL-NEXT:    v_mov_b32_e32 v16, s6

; MOVREL-NEXT:    v_mov_b32_e32 v12, s2

; MOVREL-NEXT:    v_mov_b32_e32 v11, s1

; MOVREL-NEXT:    v_mov_b32_e32 v10, s0

; MOVREL-NEXT:    s_mov_b32 s0, exec_lo

; MOVREL-NEXT:    ; implicit-def: $vcc_hi

; MOVREL-NEXT:  BB6_1: ; =>This Inner Loop Header: Depth=1

; MOVREL-NEXT:    v_readfirstlane_b32 s1, v9

; MOVREL-NEXT:    v_mov_b32_e32 v0, v10

; MOVREL-NEXT:    v_mov_b32_e32 v1, v11

; MOVREL-NEXT:    v_mov_b32_e32 v2, v12

; MOVREL-NEXT:    v_mov_b32_e32 v3, v13

; MOVREL-NEXT:    v_cmp_eq_u32_e32 vcc_lo, s1, v9

; MOVREL-NEXT:    v_readfirstlane_b32 s1, v1

; MOVREL-NEXT:    v_mov_b32_e32 v2, v10

; MOVREL-NEXT:    v_mov_b32_e32 v3, v11

; MOVREL-NEXT:    v_mov_b32_e32 v4, v12

; MOVREL-NEXT:    v_mov_b32_e32 v5, v13

; MOVREL-NEXT:    v_cmp_eq_u32_e32 vcc_lo, s1, v1

; MOVREL-NEXT:    s_mov_b32 m0, s1

; MOVREL-NEXT:    v_mov_b32_e32 v4, v14

; MOVREL-NEXT:    v_mov_b32_e32 v5, v15

; MOVREL-NEXT:    v_mov_b32_e32 v6, v16

; MOVREL-NEXT:    v_mov_b32_e32 v7, v17

; MOVREL-NEXT:    v_movreld_b32_e32 v0, v8

; MOVREL-NEXT:    v_mov_b32_e32 v6, v14

; MOVREL-NEXT:    v_mov_b32_e32 v7, v15

; MOVREL-NEXT:    v_mov_b32_e32 v8, v16

; MOVREL-NEXT:    v_mov_b32_e32 v9, v17

; MOVREL-NEXT:    v_movreld_b32_e32 v2, v0

; MOVREL-NEXT:    s_and_saveexec_b32 vcc_lo, vcc_lo

; MOVREL-NEXT:    s_xor_b32 exec_lo, exec_lo, vcc_lo

; MOVREL-NEXT:    s_cbranch_execnz BB6_1

; MOVREL-NEXT:  ; %bb.2:

; MOVREL-NEXT:    s_mov_b32 exec_lo, s0

; MOVREL-NEXT:    v_mov_b32_e32 v0, v2

; MOVREL-NEXT:    v_mov_b32_e32 v1, v3

; MOVREL-NEXT:    v_mov_b32_e32 v2, v4

; MOVREL-NEXT:    v_mov_b32_e32 v3, v5

; MOVREL-NEXT:    v_mov_b32_e32 v4, v6

; MOVREL-NEXT:    v_mov_b32_e32 v5, v7

; MOVREL-NEXT:    v_mov_b32_e32 v6, v8

; MOVREL-NEXT:    v_mov_b32_e32 v7, v9

; MOVREL-NEXT:    ; return to shader part epilog

entry:

  %insert = insertelement <8 x float> %vec, float %val, i32 %idx

llvm/test/CodeGen/AMDGPU/GlobalISel/lds-global-value.ll

+2 −2
Original line number Diff line number Diff line
@@ -10,9 +10,9 @@ define amdgpu_kernel void @use_lds_globals(i32 addrspace(1)* %out, i32 addrspace 
; CHECK:       ; %bb.0: ; %entry

; CHECK-NEXT:    s_load_dwordx2 s[0:1], s[4:5], 0x0

; CHECK-NEXT:    s_add_u32 s2, 4, 4

; CHECK-NEXT:    v_mov_b32_e32 v2, s2

; CHECK-NEXT:    v_mov_b32_e32 v0, s2

; CHECK-NEXT:    s_mov_b32 m0, -1

; CHECK-NEXT:    ds_read_b32 v2, v2

; CHECK-NEXT:    ds_read_b32 v2, v0

; CHECK-NEXT:    s_waitcnt lgkmcnt(0)

; CHECK-NEXT:    s_add_u32 s0, s0, 4

; CHECK-NEXT:    s_addc_u32 s1, s1, 0