Commit 4050b01b authored by Greg Clayton's avatar Greg Clayton
Browse files

Fix GSYM tests to run the yaml files and fix test failures on some machines. 

YAML files were not being run during lit testing as there was no lit.local.cfg file. Once this was fixed, some buildbots would fail due to a StringRef that pointed to a std::string inside of a temporary llvm::Triple object. These issues are fixed here by making a local triple object that stays around long enough so the StringRef points to valid data. Fixed memory sanitizer bot bugs as well.

Differential Revision: https://reviews.llvm.org/D75390
parent 3fda1fde

llvm/lib/DebugInfo/GSYM/GsymCreator.cpp

+1 −1
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ llvm::Error GsymCreator::encode(FileWriter &O) const { 
  Hdr.BaseAddress = MinAddr;

  Hdr.NumAddresses = static_cast<uint32_t>(Funcs.size());

  Hdr.StrtabOffset = 0; // We will fix this up later.

  Hdr.StrtabOffset = 0; // We will fix this up later.

  Hdr.StrtabSize = 0; // We will fix this up later.

  memset(Hdr.UUID, 0, sizeof(Hdr.UUID));

  if (UUID.size() > sizeof(Hdr.UUID))

    return createStringError(std::errc::invalid_argument,

llvm/test/tools/llvm-gsymutil/ARM_AArch64/lit.local.cfg

0 → 100644
+4 −0
Original line number Diff line number Diff line 
if not ('ARM' in config.root.targets and 'AArch64' in config.root.targets):

    config.unsupported = True



config.suffixes = ['.test', '.yaml']

llvm/test/tools/llvm-gsymutil/X86/lit.local.cfg

0 → 100644
+4 −0
Original line number Diff line number Diff line 
if not 'X86' in config.root.targets:

    config.unsupported = True



config.suffixes = ['.test', '.yaml']