Commit 3b2c4e71 authored by Raphael Isemann's avatar Raphael Isemann
Browse files

[lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts 

Summary:
Otherwise this code won't run on the Release+Asserts builds we have on the CI.

Fixes rdar://problem/59867885 (partly)

Reviewers: aprantl

Reviewed By: aprantl

Subscribers: JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D75493
parent ec31255c

lldb/source/Core/Section.cpp

+1 −4
Original line number Diff line number Diff line
@@ -267,11 +267,8 @@ bool Section::ResolveContainedAddress(addr_t offset, Address &so_addr, 
  so_addr.SetOffset(offset);

  so_addr.SetSection(const_cast<Section *>(this)->shared_from_this());



#ifdef LLDB_CONFIGURATION_DEBUG

  // For debug builds, ensure that there are no orphaned (i.e., moduleless)

  // sections.

  // Ensure that there are no orphaned (i.e., moduleless) sections.

  assert(GetModule().get());

#endif

  return true;

}

lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp

+0 −2
Original line number Diff line number Diff line
@@ -77,11 +77,9 @@ bool CommunicationKDP::SendRequestAndGetReply( 
  }



  std::lock_guard<std::recursive_mutex> guard(m_sequence_mutex);

#ifdef LLDB_CONFIGURATION_DEBUG

  // NOTE: this only works for packets that are in native endian byte order

  assert(request_packet.GetSize() ==

         *((const uint16_t *)(request_packet.GetData() + 2)));

#endif

  lldb::offset_t offset = 1;

  const uint32_t num_retries = 3;

  for (uint32_t i = 0; i < num_retries; ++i) {

lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h

+0 −4
Original line number Diff line number Diff line
@@ -88,9 +88,7 @@ protected: 
  void SetAllRegisterValid(bool b);



  bool GetRegisterIsValid(uint32_t reg) const {

#if defined(LLDB_CONFIGURATION_DEBUG)

    assert(reg < m_reg_valid.size());

#endif

    if (reg < m_reg_valid.size())

      return m_reg_valid[reg];

    return false;
@@ -103,9 +101,7 @@ protected: 
  }



  void SetRegisterIsValid(uint32_t reg, bool valid) {

#if defined(LLDB_CONFIGURATION_DEBUG)

    assert(reg < m_reg_valid.size());

#endif

    if (reg < m_reg_valid.size())

      m_reg_valid[reg] = valid;

  }