Commit 39eade73 authored by Simon Pilgrim's avatar Simon Pilgrim
Browse files

Revert rGe82e17d4d4cac8b2df00094e80d5e1cb22795664 - [X86] Add lowerShuffleAsBitRotate (PR44379) 

As noted on PR44379, we didn't attempt to lower vector shuffles using bit rotations on XOP/AVX512F targets.

This patch lowers to uniform ISD:ROTL nodes - ROTR isn't supported by XOP and they are interchangeable for constant values anyway.

There might be cases where targets without ISD:ROTL support would benefit from this (expanding to SRL+SHL+OR), which I'll investigate in a future patch.

Also, non-AVX512BW targets fail to concatenate 256-bit rotations back to 512-bits (split during shuffle lowering as they don't have v32i16/v64i8 types).
---
Internal shuffle tests indicate theres a bug somewhere that I haven't been able to track down yet.
parent 2a3ef377

llvm/lib/Target/X86/X86ISelLowering.cpp

+0 −92
Original line number Diff line number Diff line
@@ -11665,66 +11665,6 @@ static SDValue lowerShuffleAsDecomposedShuffleBlend( 
  return DAG.getVectorShuffle(VT, DL, V1, V2, BlendMask);

}













/// Try to lower a vector shuffle as a bit rotation.













///













/// Look for a repeated rotation pattern in each sub group.













/// Returns a ISD::ROTL element rotation amount or -1 if failed.













static int matchShuffleAsBitRotate(ArrayRef<int> Mask, int NumSubElts) {













  int NumElts = Mask.size();













  assert((NumElts % NumSubElts) == 0 && "Illegal shuffle mask");

























  int RotateAmt = -1;













  for (int i = 0; i != NumElts; i += NumSubElts) {













    for (int j = 0; j != NumSubElts; ++j) {













      int M = Mask[i + j];













      if (M < 0)













        continue;













      if (!isInRange(M, i, i + NumSubElts))













        return -1;













      int Offset = ((M - i) + (NumSubElts - j)) % NumSubElts;













      if (0 <= RotateAmt && Offset != RotateAmt)













        return -1;













      RotateAmt = Offset;













    }













  }













  return RotateAmt;













}

























/// Lower shuffle using ISD::ROTL rotations.













static SDValue lowerShuffleAsBitRotate(const SDLoc &DL, MVT VT, SDValue V1,













                                       ArrayRef<int> Mask,













                                       const X86Subtarget &Subtarget,













                                       SelectionDAG &DAG) {













  assert(!isNoopShuffleMask(Mask) && "We shouldn't lower no-op shuffles!");

























  MVT SVT = VT.getScalarType();













  int EltSizeInBits = SVT.getScalarSizeInBits();













  assert(EltSizeInBits < 64 && "Can't rotate 64-bit integers");

























  // Only XOP + AVX512 targets have bit rotation instructions.













  if (!((VT.is128BitVector() && Subtarget.hasXOP()) || Subtarget.hasAVX512()))













    return SDValue();

























  // AVX512 only has vXi32/vXi64 rotates, so limit the rotation sub group size.













  int MinSubElts = Subtarget.hasXOP() ? 2 : std::max(32 / EltSizeInBits, 2);













  int MaxSubElts = 64 / EltSizeInBits;













  for (int NumSubElts = MinSubElts; NumSubElts <= MaxSubElts; NumSubElts *= 2) {













    int RotateAmt = matchShuffleAsBitRotate(Mask, NumSubElts);













    if (RotateAmt < 0)













      continue;













    int NumElts = VT.getVectorNumElements();













    MVT RotateSVT = MVT::getIntegerVT(EltSizeInBits * NumSubElts);













    MVT RotateVT = MVT::getVectorVT(RotateSVT, NumElts / NumSubElts);













    int RotateAmtInBits = RotateAmt * EltSizeInBits;













    SDValue Rot =













        DAG.getNode(ISD::ROTL, DL, RotateVT, DAG.getBitcast(RotateVT, V1),













                    DAG.getConstant(RotateAmtInBits, DL, RotateVT));













    return DAG.getBitcast(VT, Rot);













  }

























  return SDValue();













}



























/// Try to lower a vector shuffle as a byte rotation.















///















/// This is used for support PALIGNR for SSSE3 or VALIGND/Q for AVX512.










@@ -14280,11 +14220,6 @@ static SDValue lowerV8I16Shuffle(const SDLoc &DL, ArrayRef<int> Mask,













                                                    Mask, Subtarget, DAG))















      return Broadcast;



























    // Try to use bit rotation instructions.













    if (SDValue Rotate = lowerShuffleAsBitRotate(DL, MVT::v8i16, V1, Mask,













                                                 Subtarget, DAG))













      return Rotate;



























    // Use dedicated unpack instructions for masks that match their pattern.















    if (SDValue V = lowerShuffleWithUNPCK(DL, MVT::v8i16, Mask, V1, V2, DAG))















      return V;










@@ -14509,11 +14444,6 @@ static SDValue lowerV16I8Shuffle(const SDLoc &DL, ArrayRef<int> Mask,













                                                    Mask, Subtarget, DAG))















      return Broadcast;



























    // Try to use bit rotation instructions.













    if (SDValue Rotate = lowerShuffleAsBitRotate(DL, MVT::v16i8, V1, Mask,













                                                 Subtarget, DAG))













      return Rotate;



























    if (SDValue V = lowerShuffleWithUNPCK(DL, MVT::v16i8, Mask, V1, V2, DAG))















      return V;
























@@ -16404,11 +16334,6 @@ static SDValue lowerV16I16Shuffle(const SDLoc &DL, ArrayRef<int> Mask,













    return V;





























  if (V2.isUndef()) {













    // Try to use bit rotation instructions.













    if (SDValue Rotate =













            lowerShuffleAsBitRotate(DL, MVT::v16i16, V1, Mask, Subtarget, DAG))













      return Rotate;



























    // Try to produce a fixed cross-128-bit lane permute followed by unpack















    // because that should be faster than the variable permute alternatives.















    if (SDValue V = lowerShuffleWithUNPCK256(DL, MVT::v16i16, Mask, V1, V2, DAG))










@@ -16507,12 +16432,6 @@ static SDValue lowerV32I8Shuffle(const SDLoc &DL, ArrayRef<int> Mask,













                                                Subtarget, DAG))















    return Rotate;



























  // Try to use bit rotation instructions.













  if (V2.isUndef())













    if (SDValue Rotate =













            lowerShuffleAsBitRotate(DL, MVT::v32i8, V1, Mask, Subtarget, DAG))













      return Rotate;



























  // Try to create an in-lane repeating shuffle mask and then shuffle the















  // results into the target lanes.















  if (SDValue V = lowerShuffleAsRepeatedMaskAndLanePermute(










@@ -17007,11 +16926,6 @@ static SDValue lowerV32I16Shuffle(const SDLoc &DL, ArrayRef<int> Mask,













    return Rotate;





























  if (V2.isUndef()) {













    // Try to use bit rotation instructions.













    if (SDValue Rotate =













            lowerShuffleAsBitRotate(DL, MVT::v32i16, V1, Mask, Subtarget, DAG))













      return Rotate;



























    SmallVector<int, 8> RepeatedMask;















    if (is128BitLaneRepeatedShuffleMask(MVT::v32i16, Mask, RepeatedMask)) {















      // As this is a single-input shuffle, the repeated mask should be










@@ -17069,12 +16983,6 @@ static SDValue lowerV64I8Shuffle(const SDLoc &DL, ArrayRef<int> Mask,













                                                Subtarget, DAG))















    return Rotate;



























  // Try to use bit rotation instructions.













  if (V2.isUndef())













    if (SDValue Rotate =













            lowerShuffleAsBitRotate(DL, MVT::v64i8, V1, Mask, Subtarget, DAG))













      return Rotate;



























  if (SDValue PSHUFB = lowerShuffleWithPSHUFB(DL, MVT::v64i8, Mask, V1, V2,















                                              Zeroable, Subtarget, DAG))















    return PSHUFB;

























llvm/test/CodeGen/X86/vector-shuffle-128-v16.ll



+11
−35






























Original line number
Diff line number
Diff line








@@ -479,20 +479,10 @@ define <16 x i8> @shuffle_v16i8_01_00_03_02_05_04_07_06_09_08_11_10_13_12_15_14(













; SSE41-NEXT:    pshufb {{.*#+}} xmm0 = xmm0[1,0,3,2,5,4,7,6,9,8,11,10,13,12,15,14]















; SSE41-NEXT:    retq















;













; AVX1-LABEL: shuffle_v16i8_01_00_03_02_05_04_07_06_09_08_11_10_13_12_15_14:













; AVX1:       # %bb.0:













; AVX1-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[1,0,3,2,5,4,7,6,9,8,11,10,13,12,15,14]













; AVX1-NEXT:    retq













;













; AVX2OR512VL-LABEL: shuffle_v16i8_01_00_03_02_05_04_07_06_09_08_11_10_13_12_15_14:













; AVX2OR512VL:       # %bb.0:













; AVX2OR512VL-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[1,0,3,2,5,4,7,6,9,8,11,10,13,12,15,14]













; AVX2OR512VL-NEXT:    retq













;













; XOP-LABEL: shuffle_v16i8_01_00_03_02_05_04_07_06_09_08_11_10_13_12_15_14:













; XOP:       # %bb.0:













; XOP-NEXT:    vprotw $8, %xmm0, %xmm0













; XOP-NEXT:    retq













; AVX-LABEL: shuffle_v16i8_01_00_03_02_05_04_07_06_09_08_11_10_13_12_15_14:













; AVX:       # %bb.0:













; AVX-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[1,0,3,2,5,4,7,6,9,8,11,10,13,12,15,14]













; AVX-NEXT:    retq















  %shuffle = shufflevector <16 x i8> %a, <16 x i8> %b, <16 x i32> <i32 1, i32 0, i32 3, i32 2, i32 5, i32 4, i32 7, i32 6, i32 9, i32 8, i32 11, i32 10, i32 13, i32 12, i32 15, i32 14>















  ret <16 x i8> %shuffle















}










@@ -1912,25 +1902,10 @@ define <16 x i8> @shuffle_v16i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14(













; SSE41-NEXT:    pshufb {{.*#+}} xmm0 = xmm0[3,0,1,2,7,4,5,6,11,8,9,10,15,12,13,14]















; SSE41-NEXT:    retq















;













; AVX1-LABEL: shuffle_v16i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14:













; AVX1:       # %bb.0:













; AVX1-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[3,0,1,2,7,4,5,6,11,8,9,10,15,12,13,14]













; AVX1-NEXT:    retq













;













; AVX2-LABEL: shuffle_v16i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14:













; AVX2:       # %bb.0:













; AVX2-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[3,0,1,2,7,4,5,6,11,8,9,10,15,12,13,14]













; AVX2-NEXT:    retq













;













; AVX512VL-LABEL: shuffle_v16i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14:













; AVX512VL:       # %bb.0:













; AVX512VL-NEXT:    vprold $24, %xmm0, %xmm0













; AVX512VL-NEXT:    retq













;













; XOP-LABEL: shuffle_v16i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14:













; XOP:       # %bb.0:













; XOP-NEXT:    vprotd $24, %xmm0, %xmm0













; XOP-NEXT:    retq













; AVX-LABEL: shuffle_v16i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14:













; AVX:       # %bb.0:













; AVX-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[3,0,1,2,7,4,5,6,11,8,9,10,15,12,13,14]













; AVX-NEXT:    retq















  %shuffle = shufflevector <16 x i8> %a, <16 x i8> undef, <16 x i32> <i32 3, i32 0, i32 1, i32 2, i32 7, i32 4, i32 5, i32 6, i32 11, i32 8, i32 9, i32 10, i32 15, i32 12, i32 13, i32 14>















  ret <16 x i8> %shuffle















}










@@ -1962,12 +1937,13 @@ define <16 x i8> @shuffle_v16i8_02_03_04_05_06_07_00_01_10_11_12_13_14_15_08_09(













;















; AVX512VL-LABEL: shuffle_v16i8_02_03_04_05_06_07_00_01_10_11_12_13_14_15_08_09:















; AVX512VL:       # %bb.0:













; AVX512VL-NEXT:    vprolq $16, %xmm0, %xmm0













; AVX512VL-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[2,3,4,5,6,7,0,1,10,11,12,13,14,15,8,9]















; AVX512VL-NEXT:    retq















;















; XOP-LABEL: shuffle_v16i8_02_03_04_05_06_07_00_01_10_11_12_13_14_15_08_09:















; XOP:       # %bb.0:













; XOP-NEXT:    vprotq $16, %xmm0, %xmm0













; XOP-NEXT:    vpshuflw {{.*#+}} xmm0 = xmm0[1,2,3,0,4,5,6,7]













; XOP-NEXT:    vpshufhw {{.*#+}} xmm0 = xmm0[0,1,2,3,5,6,7,4]















; XOP-NEXT:    retq















  %shuffle = shufflevector <16 x i8> %a, <16 x i8> undef, <16 x i32> <i32 2, i32 3, i32 4, i32 5, i32 6, i32 7, i32 0, i32 1, i32 10, i32 11, i32 12, i32 13, i32 14, i32 15, i32 8, i32 9>















  ret <16 x i8> %shuffle

































llvm/test/CodeGen/X86/vector-shuffle-128-v8.ll



+24
−10






























Original line number
Diff line number
Diff line








@@ -2462,14 +2462,21 @@ define <8 x i16> @shuffle_v8i16_10325476(<8 x i16> %a) {













; AVX2-FAST-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[2,3,0,1,6,7,4,5,10,11,8,9,14,15,12,13]















; AVX2-FAST-NEXT:    retq















;













; AVX512VL-LABEL: shuffle_v8i16_10325476:













; AVX512VL:       # %bb.0:













; AVX512VL-NEXT:    vprold $16, %xmm0, %xmm0













; AVX512VL-NEXT:    retq













; AVX512VL-SLOW-LABEL: shuffle_v8i16_10325476:













; AVX512VL-SLOW:       # %bb.0:













; AVX512VL-SLOW-NEXT:    vpshuflw {{.*#+}} xmm0 = xmm0[1,0,3,2,4,5,6,7]













; AVX512VL-SLOW-NEXT:    vpshufhw {{.*#+}} xmm0 = xmm0[0,1,2,3,5,4,7,6]













; AVX512VL-SLOW-NEXT:    retq













;













; AVX512VL-FAST-LABEL: shuffle_v8i16_10325476:













; AVX512VL-FAST:       # %bb.0:













; AVX512VL-FAST-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[2,3,0,1,6,7,4,5,10,11,8,9,14,15,12,13]













; AVX512VL-FAST-NEXT:    retq















;















; XOP-LABEL: shuffle_v8i16_10325476:















; XOP:       # %bb.0:













; XOP-NEXT:    vprotd $16, %xmm0, %xmm0













; XOP-NEXT:    vpshuflw {{.*#+}} xmm0 = xmm0[1,0,3,2,4,5,6,7]













; XOP-NEXT:    vpshufhw {{.*#+}} xmm0 = xmm0[0,1,2,3,5,4,7,6]















; XOP-NEXT:    retq















  %shuffle = shufflevector <8 x i16> %a, <8 x i16> zeroinitializer, <8 x i32> <i32 1, i32 0, i32 3, i32 2, i32 5, i32 4, i32 7, i32 6>















  ret <8 x i16> %shuffle










@@ -2499,14 +2506,21 @@ define <8 x i16> @shuffle_v8i16_12305674(<8 x i16> %a) {













; AVX2-FAST-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[2,3,4,5,6,7,0,1,10,11,12,13,14,15,8,9]















; AVX2-FAST-NEXT:    retq















;













; AVX512VL-LABEL: shuffle_v8i16_12305674:













; AVX512VL:       # %bb.0:













; AVX512VL-NEXT:    vprolq $16, %xmm0, %xmm0













; AVX512VL-NEXT:    retq













; AVX512VL-SLOW-LABEL: shuffle_v8i16_12305674:













; AVX512VL-SLOW:       # %bb.0:













; AVX512VL-SLOW-NEXT:    vpshuflw {{.*#+}} xmm0 = xmm0[1,2,3,0,4,5,6,7]













; AVX512VL-SLOW-NEXT:    vpshufhw {{.*#+}} xmm0 = xmm0[0,1,2,3,5,6,7,4]













; AVX512VL-SLOW-NEXT:    retq













;













; AVX512VL-FAST-LABEL: shuffle_v8i16_12305674:













; AVX512VL-FAST:       # %bb.0:













; AVX512VL-FAST-NEXT:    vpshufb {{.*#+}} xmm0 = xmm0[2,3,4,5,6,7,0,1,10,11,12,13,14,15,8,9]













; AVX512VL-FAST-NEXT:    retq















;















; XOP-LABEL: shuffle_v8i16_12305674:















; XOP:       # %bb.0:













; XOP-NEXT:    vprotq $16, %xmm0, %xmm0













; XOP-NEXT:    vpshuflw {{.*#+}} xmm0 = xmm0[1,2,3,0,4,5,6,7]













; XOP-NEXT:    vpshufhw {{.*#+}} xmm0 = xmm0[0,1,2,3,5,6,7,4]















; XOP-NEXT:    retq















  %shuffle = shufflevector <8 x i16> %a, <8 x i16> zeroinitializer, <8 x i32> <i32 1, i32 2, i32 3, i32 0, i32 5, i32 6, i32 7, i32 4>















  ret <8 x i16> %shuffle

































llvm/test/CodeGen/X86/vector-shuffle-256-v16.ll



+29
−13






























Original line number
Diff line number
Diff line








@@ -5385,7 +5385,7 @@ define <16 x i16> @shuffle_v16i16_01_00_17_16_03_02_19_26_09_08_25_24_11_10_27_2













; XOPAVX1-NEXT:    vextractf128 $1, %ymm0, %xmm3















; XOPAVX1-NEXT:    vpperm {{.*#+}} xmm3 = xmm3[2,3,0,1],xmm2[2,3,0,1],xmm3[6,7,4,5],xmm2[6,7,4,5]















; XOPAVX1-NEXT:    vpperm {{.*#+}} xmm1 = xmm1[2,3,0,1,6,7],xmm2[4,5],xmm1[4,5],xmm2[4,5],xmm1[6,7],xmm2[4,5]













; XOPAVX1-NEXT:    vprotd $16, %xmm0, %xmm0













; XOPAVX1-NEXT:    vpshuflw {{.*#+}} xmm0 = xmm0[1,0,3,2,4,5,6,7]















; XOPAVX1-NEXT:    vpunpckldq {{.*#+}} xmm0 = xmm0[0],xmm1[0],xmm0[1],xmm1[1]















; XOPAVX1-NEXT:    vinsertf128 $1, %xmm3, %ymm0, %ymm0















; XOPAVX1-NEXT:    retq










@@ -7054,16 +7054,24 @@ define <16 x i16> @shuffle_v16i16_01_00_03_02_05_04_07_06_09_08_11_10_13_12_15_1













; AVX2-FAST-NEXT:    vpshufb {{.*#+}} ymm0 = ymm0[2,3,0,1,6,7,4,5,10,11,8,9,14,15,12,13,18,19,16,17,22,23,20,21,26,27,24,25,30,31,28,29]















; AVX2-FAST-NEXT:    retq















;













; AVX512VL-LABEL: shuffle_v16i16_01_00_03_02_05_04_07_06_09_08_11_10_13_12_15_14:













; AVX512VL:       # %bb.0:













; AVX512VL-NEXT:    vprold $16, %ymm0, %ymm0













; AVX512VL-NEXT:    retq













; AVX512VL-SLOW-LABEL: shuffle_v16i16_01_00_03_02_05_04_07_06_09_08_11_10_13_12_15_14:













; AVX512VL-SLOW:       # %bb.0:













; AVX512VL-SLOW-NEXT:    vpshuflw {{.*#+}} ymm0 = ymm0[1,0,3,2,4,5,6,7,9,8,11,10,12,13,14,15]













; AVX512VL-SLOW-NEXT:    vpshufhw {{.*#+}} ymm0 = ymm0[0,1,2,3,5,4,7,6,8,9,10,11,13,12,15,14]













; AVX512VL-SLOW-NEXT:    retq













;













; AVX512VL-FAST-LABEL: shuffle_v16i16_01_00_03_02_05_04_07_06_09_08_11_10_13_12_15_14:













; AVX512VL-FAST:       # %bb.0:













; AVX512VL-FAST-NEXT:    vpshufb {{.*#+}} ymm0 = ymm0[2,3,0,1,6,7,4,5,10,11,8,9,14,15,12,13,18,19,16,17,22,23,20,21,26,27,24,25,30,31,28,29]













; AVX512VL-FAST-NEXT:    retq















;















; XOPAVX1-LABEL: shuffle_v16i16_01_00_03_02_05_04_07_06_09_08_11_10_13_12_15_14:















; XOPAVX1:       # %bb.0:













; XOPAVX1-NEXT:    vprotd $16, %xmm0, %xmm1













; XOPAVX1-NEXT:    vpshuflw {{.*#+}} xmm1 = xmm0[1,0,3,2,4,5,6,7]













; XOPAVX1-NEXT:    vpshufhw {{.*#+}} xmm1 = xmm1[0,1,2,3,5,4,7,6]















; XOPAVX1-NEXT:    vextractf128 $1, %ymm0, %xmm0













; XOPAVX1-NEXT:    vprotd $16, %xmm0, %xmm0













; XOPAVX1-NEXT:    vpshuflw {{.*#+}} xmm0 = xmm0[1,0,3,2,4,5,6,7]













; XOPAVX1-NEXT:    vpshufhw {{.*#+}} xmm0 = xmm0[0,1,2,3,5,4,7,6]















; XOPAVX1-NEXT:    vinsertf128 $1, %xmm0, %ymm1, %ymm0















; XOPAVX1-NEXT:    retq















;










@@ -7098,16 +7106,24 @@ define <16 x i16> @shuffle_v16i16_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_1













; AVX2-FAST-NEXT:    vpshufb {{.*#+}} ymm0 = ymm0[6,7,0,1,2,3,4,5,14,15,8,9,10,11,12,13,22,23,16,17,18,19,20,21,30,31,24,25,26,27,28,29]















; AVX2-FAST-NEXT:    retq















;













; AVX512VL-LABEL: shuffle_v16i16_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14:













; AVX512VL:       # %bb.0:













; AVX512VL-NEXT:    vprolq $48, %ymm0, %ymm0













; AVX512VL-NEXT:    retq













; AVX512VL-SLOW-LABEL: shuffle_v16i16_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14:













; AVX512VL-SLOW:       # %bb.0:













; AVX512VL-SLOW-NEXT:    vpshuflw {{.*#+}} ymm0 = ymm0[3,0,1,2,4,5,6,7,11,8,9,10,12,13,14,15]













; AVX512VL-SLOW-NEXT:    vpshufhw {{.*#+}} ymm0 = ymm0[0,1,2,3,7,4,5,6,8,9,10,11,15,12,13,14]













; AVX512VL-SLOW-NEXT:    retq













;













; AVX512VL-FAST-LABEL: shuffle_v16i16_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14:













; AVX512VL-FAST:       # %bb.0:













; AVX512VL-FAST-NEXT:    vpshufb {{.*#+}} ymm0 = ymm0[6,7,0,1,2,3,4,5,14,15,8,9,10,11,12,13,22,23,16,17,18,19,20,21,30,31,24,25,26,27,28,29]













; AVX512VL-FAST-NEXT:    retq















;















; XOPAVX1-LABEL: shuffle_v16i16_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14:















; XOPAVX1:       # %bb.0:













; XOPAVX1-NEXT:    vprotq $48, %xmm0, %xmm1













; XOPAVX1-NEXT:    vpshuflw {{.*#+}} xmm1 = xmm0[3,0,1,2,4,5,6,7]













; XOPAVX1-NEXT:    vpshufhw {{.*#+}} xmm1 = xmm1[0,1,2,3,7,4,5,6]















; XOPAVX1-NEXT:    vextractf128 $1, %ymm0, %xmm0













; XOPAVX1-NEXT:    vprotq $48, %xmm0, %xmm0













; XOPAVX1-NEXT:    vpshuflw {{.*#+}} xmm0 = xmm0[3,0,1,2,4,5,6,7]













; XOPAVX1-NEXT:    vpshufhw {{.*#+}} xmm0 = xmm0[0,1,2,3,7,4,5,6]















; XOPAVX1-NEXT:    vinsertf128 $1, %xmm0, %ymm1, %ymm0















; XOPAVX1-NEXT:    retq















;

































llvm/test/CodeGen/X86/vector-shuffle-256-v32.ll



+34
−19






























Original line number
Diff line number
Diff line








@@ -4678,22 +4678,18 @@ define <32 x i8> @shuffle_v32i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14_













; AVX1-NEXT:    vinsertf128 $1, %xmm1, %ymm0, %ymm0















; AVX1-NEXT:    retq















;













; AVX2-LABEL: shuffle_v32i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14_19_16_17_18_23_20_21_22_27_24_25_26_31_28_29_30:













; AVX2:       # %bb.0:













; AVX2-NEXT:    vpshufb {{.*#+}} ymm0 = ymm0[3,0,1,2,7,4,5,6,11,8,9,10,15,12,13,14,19,16,17,18,23,20,21,22,27,24,25,26,31,28,29,30]













; AVX2-NEXT:    retq













;













; AVX512VL-LABEL: shuffle_v32i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14_19_16_17_18_23_20_21_22_27_24_25_26_31_28_29_30:













; AVX512VL:       # %bb.0:













; AVX512VL-NEXT:    vprold $24, %ymm0, %ymm0













; AVX512VL-NEXT:    retq













; AVX2OR512VL-LABEL: shuffle_v32i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14_19_16_17_18_23_20_21_22_27_24_25_26_31_28_29_30:













; AVX2OR512VL:       # %bb.0:













; AVX2OR512VL-NEXT:    vpshufb {{.*#+}} ymm0 = ymm0[3,0,1,2,7,4,5,6,11,8,9,10,15,12,13,14,19,16,17,18,23,20,21,22,27,24,25,26,31,28,29,30]













; AVX2OR512VL-NEXT:    retq















;















; XOPAVX1-LABEL: shuffle_v32i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14_19_16_17_18_23_20_21_22_27_24_25_26_31_28_29_30:















; XOPAVX1:       # %bb.0:













; XOPAVX1-NEXT:    vprotd $24, %xmm0, %xmm1













; XOPAVX1-NEXT:    vextractf128 $1, %ymm0, %xmm0













; XOPAVX1-NEXT:    vprotd $24, %xmm0, %xmm0













; XOPAVX1-NEXT:    vinsertf128 $1, %xmm0, %ymm1, %ymm0













; XOPAVX1-NEXT:    vextractf128 $1, %ymm0, %xmm1













; XOPAVX1-NEXT:    vmovdqa {{.*#+}} xmm2 = [3,0,1,2,7,4,5,6,11,8,9,10,15,12,13,14]













; XOPAVX1-NEXT:    vpshufb %xmm2, %xmm1, %xmm1













; XOPAVX1-NEXT:    vpshufb %xmm2, %xmm0, %xmm0













; XOPAVX1-NEXT:    vinsertf128 $1, %xmm1, %ymm0, %ymm0















; XOPAVX1-NEXT:    retq















;















; XOPAVX2-LABEL: shuffle_v32i8_03_00_01_02_07_04_05_06_11_08_09_10_15_12_13_14_19_16_17_18_23_20_21_22_27_24_25_26_31_28_29_30:










@@ -4727,16 +4723,35 @@ define <32 x i8> @shuffle_v32i8_02_03_04_05_06_07_00_01_10_11_12_13_14_15_08_09_













; AVX2-FAST-NEXT:    vpshufb {{.*#+}} ymm0 = ymm0[2,3,4,5,6,7,0,1,10,11,12,13,14,15,8,9,18,19,20,21,22,23,16,17,26,27,28,29,30,31,24,25]















; AVX2-FAST-NEXT:    retq















;













; AVX512VL-LABEL: shuffle_v32i8_02_03_04_05_06_07_00_01_10_11_12_13_14_15_08_09_18_19_20_21_22_23_16_17_26_27_28_29_30_31_24_25:













; AVX512VL:       # %bb.0:













; AVX512VL-NEXT:    vprolq $16, %ymm0, %ymm0













; AVX512VL-NEXT:    retq













; AVX512VLBW-SLOW-LABEL: shuffle_v32i8_02_03_04_05_06_07_00_01_10_11_12_13_14_15_08_09_18_19_20_21_22_23_16_17_26_27_28_29_30_31_24_25:













; AVX512VLBW-SLOW:       # %bb.0:













; AVX512VLBW-SLOW-NEXT:    vpshuflw {{.*#+}} ymm0 = ymm0[1,2,3,0,4,5,6,7,9,10,11,8,12,13,14,15]













; AVX512VLBW-SLOW-NEXT:    vpshufhw {{.*#+}} ymm0 = ymm0[0,1,2,3,5,6,7,4,8,9,10,11,13,14,15,12]













; AVX512VLBW-SLOW-NEXT:    retq













;













; AVX512VLBW-FAST-LABEL: shuffle_v32i8_02_03_04_05_06_07_00_01_10_11_12_13_14_15_08_09_18_19_20_21_22_23_16_17_26_27_28_29_30_31_24_25:













; AVX512VLBW-FAST:       # %bb.0:













; AVX512VLBW-FAST-NEXT:    vpshufb {{.*#+}} ymm0 = ymm0[2,3,4,5,6,7,0,1,10,11,12,13,14,15,8,9,18,19,20,21,22,23,16,17,26,27,28,29,30,31,24,25]













; AVX512VLBW-FAST-NEXT:    retq













;













; AVX512VLVBMI-SLOW-LABEL: shuffle_v32i8_02_03_04_05_06_07_00_01_10_11_12_13_14_15_08_09_18_19_20_21_22_23_16_17_26_27_28_29_30_31_24_25:













; AVX512VLVBMI-SLOW:       # %bb.0:













; AVX512VLVBMI-SLOW-NEXT:    vpshuflw {{.*#+}} ymm0 = ymm0[1,2,3,0,4,5,6,7,9,10,11,8,12,13,14,15]













; AVX512VLVBMI-SLOW-NEXT:    vpshufhw {{.*#+}} ymm0 = ymm0[0,1,2,3,5,6,7,4,8,9,10,11,13,14,15,12]













; AVX512VLVBMI-SLOW-NEXT:    retq













;













; AVX512VLVBMI-FAST-LABEL: shuffle_v32i8_02_03_04_05_06_07_00_01_10_11_12_13_14_15_08_09_18_19_20_21_22_23_16_17_26_27_28_29_30_31_24_25:













; AVX512VLVBMI-FAST:       # %bb.0:













; AVX512VLVBMI-FAST-NEXT:    vpshufb {{.*#+}} ymm0 = ymm0[2,3,4,5,6,7,0,1,10,11,12,13,14,15,8,9,18,19,20,21,22,23,16,17,26,27,28,29,30,31,24,25]













; AVX512VLVBMI-FAST-NEXT:    retq















;















; XOPAVX1-LABEL: shuffle_v32i8_02_03_04_05_06_07_00_01_10_11_12_13_14_15_08_09_18_19_20_21_22_23_16_17_26_27_28_29_30_31_24_25:















; XOPAVX1:       # %bb.0:













; XOPAVX1-NEXT:    vprotq $16, %xmm0, %xmm1













; XOPAVX1-NEXT:    vpshuflw {{.*#+}} xmm1 = xmm0[1,2,3,0,4,5,6,7]













; XOPAVX1-NEXT:    vpshufhw {{.*#+}} xmm1 = xmm1[0,1,2,3,5,6,7,4]















; XOPAVX1-NEXT:    vextractf128 $1, %ymm0, %xmm0













; XOPAVX1-NEXT:    vprotq $16, %xmm0, %xmm0













; XOPAVX1-NEXT:    vpshuflw {{.*#+}} xmm0 = xmm0[1,2,3,0,4,5,6,7]













; XOPAVX1-NEXT:    vpshufhw {{.*#+}} xmm0 = xmm0[0,1,2,3,5,6,7,4]















; XOPAVX1-NEXT:    vinsertf128 $1, %xmm0, %ymm1, %ymm0















; XOPAVX1-NEXT:    retq















;