Commit 2697e8bc authored by Jacques Pienaar's avatar Jacques Pienaar
Browse files

[mlir] Update generic op ebnf to include region 

Summary: Optional regions are supported in the generic op print/parse form, update the docs to match.

Differential Revision: https://reviews.llvm.org/D74061
parent 6c4a8bc0

mlir/docs/LangRef.md

+2 −2
Original line number Diff line number Diff line
@@ -241,8 +241,8 @@ Syntax: 
```

operation         ::= op-result-list? (generic-operation | custom-operation)

                      trailing-location?

generic-operation ::= string-literal '(' ssa-use-list? ')' attribute-dict?

                      `:` function-type

generic-operation ::= string-literal `(` ssa-use-list? `)`  successor-list?

                      (`(` region-list `)`)? attribute-dict? `:` function-type

custom-operation  ::= bare-id custom-operation-format

op-result-list    ::= op-result (`,` op-result)* `=`

op-result         ::= ssa-id (`:` integer-literal)

mlir/lib/Parser/Parser.cpp

+3 −2
Original line number Diff line number Diff line
@@ -3573,8 +3573,9 @@ Value OperationParser::createForwardRefPlaceholder(SMLoc loc, Type type) { 
///  operation         ::= op-result-list?

///                        (generic-operation | custom-operation)

///                        trailing-location?

///  generic-operation ::= string-literal '(' ssa-use-list? ')' attribute-dict?

///                        `:` function-type

///  generic-operation ::= string-literal `(` ssa-use-list? `)`

///                        successor-list? (`(` region-list `)`)?

///                        attribute-dict? `:` function-type

///  custom-operation  ::= bare-id custom-operation-format

///  op-result-list    ::= op-result (`,` op-result)* `=`

///  op-result         ::= ssa-id (`:` integer-literal)