Commit 2488016b authored by Stephen Neuendorffer's avatar Stephen Neuendorffer
Browse files

[MLIR] Remove redundant library dependencies 

In cmake, it is redundant to have a target list under target_link_libraries()
and add_dependency().  This patch removes the redundant dependency from
add_dependency().

Differential Revision: https://reviews.llvm.org/D74929
parent 3ed02340

mlir/lib/Analysis/CMakeLists.txt

+0 −4
Original line number Diff line number Diff line
@@ -26,11 +26,9 @@ add_llvm_library(MLIRAnalysis 
  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis

  )

add_dependencies(MLIRAnalysis

  MLIRAffineOps

  MLIRCallOpInterfacesIncGen

  MLIRControlFlowInterfacesIncGen

  MLIRTypeInferOpInterfaceIncGen

  MLIRLoopOps

  )



target_link_libraries(MLIRAnalysis
@@ -50,11 +48,9 @@ add_llvm_library(MLIRLoopAnalysis 
  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis

  )

add_dependencies(MLIRLoopAnalysis

  MLIRAffineOps

  MLIRCallOpInterfacesIncGen

  MLIRControlFlowInterfacesIncGen

  MLIRTypeInferOpInterfaceIncGen

  MLIRLoopOps

  )



target_link_libraries(MLIRLoopAnalysis

mlir/lib/Conversion/AffineToStandard/CMakeLists.txt

+1 −10
Original line number Diff line number Diff line
@@ -4,15 +4,6 @@ add_mlir_conversion_library(MLIRAffineToStandard 
  ADDITIONAL_HEADER_DIRS

  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/AffineToStandard

)

add_dependencies(

  MLIRAffineToStandard



  MLIRAffineOps

  MLIRStandardOps

  MLIRIR

  LLVMCore

  LLVMSupport

)

target_link_libraries(

  MLIRAffineToStandard

  PUBLIC

mlir/lib/Conversion/LoopToStandard/CMakeLists.txt

+1 −9
Original line number Diff line number Diff line
@@ -4,14 +4,6 @@ add_mlir_conversion_library(MLIRLoopToStandard 
  ADDITIONAL_HEADER_DIRS

  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LoopToStandard

)

add_dependencies(

  MLIRLoopToStandard



  MLIRLoopOps

  MLIRTransforms

  LLVMCore

  LLVMSupport

)

target_link_libraries(

  MLIRLoopToStandard

  PUBLIC

mlir/lib/Conversion/LoopsToGPU/CMakeLists.txt

+10 −14
Original line number Diff line number Diff line 
set(LIBS

add_mlir_conversion_library(MLIRLoopsToGPU

  LoopsToGPU.cpp

  LoopsToGPUPass.cpp



  ADDITIONAL_HEADER_DIRS

  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LoopsToGPU

)

target_link_libraries(MLIRLoopsToGPU

  PUBLIC

  MLIRAffineOps

  MLIRAffineToStandard

  MLIRGPU
@@ -10,15 +18,3 @@ set(LIBS 
  MLIRTransforms

  LLVMSupport

  )
 


add_mlir_conversion_library(MLIRLoopsToGPU

  LoopsToGPU.cpp

  LoopsToGPUPass.cpp



  ADDITIONAL_HEADER_DIRS

  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LoopsToGPU

)

add_dependencies(MLIRLoopsToGPU ${LIBS})

target_link_libraries(MLIRLoopsToGPU

  PUBLIC

  ${LIBS})

mlir/lib/Conversion/StandardToLLVM/CMakeLists.txt

+1 −9
Original line number Diff line number Diff line
@@ -4,14 +4,6 @@ add_mlir_conversion_library(MLIRStandardToLLVM 
  ADDITIONAL_HEADER_DIRS

  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/StandardToLLVM

)

add_dependencies(

  MLIRStandardToLLVM



  MLIRLLVMIR

  MLIRTransforms

  LLVMCore

  LLVMSupport

)

target_link_libraries(

  MLIRStandardToLLVM

  PUBLIC