Commit 209e30b7 authored by Sam McCall's avatar Sam McCall
Browse files

[clangd] Don't repeat class template args when printing constructor definitions 

This fixes part of https://github.com/clangd/clangd/issues/76
parent 575e09d9

clang-tools-extra/clangd/XRefs.cpp

+1 −0
Original line number Diff line number Diff line
@@ -456,6 +456,7 @@ static std::string printDefinition(const Decl *D) { 
  PrintingPolicy Policy =

      printingPolicyForDecls(D->getASTContext().getPrintingPolicy());

  Policy.IncludeTagDefinition = false;

  Policy.SuppressTemplateArgsInCXXConstructors = true;

  D->print(OS, Policy);

  OS.flush();

  return Definition;

clang-tools-extra/clangd/unittests/XRefsTests.cpp

+1 −1
Original line number Diff line number Diff line
@@ -920,7 +920,7 @@ void foo())cpp"; 
         HI.Kind = SymbolKind::Constructor;

         HI.Type = "void ()";          // FIXME: Should be None

         HI.ReturnType = "void";       // FIXME: Should be None or X<T*>

         HI.Definition = "X<type - parameter - 0 - 0 *>()"; // FIXME: --> X()

         HI.Definition = "X()";

         HI.Parameters.emplace();

       }},