Commit 1c82dd39 authored by Stephen Neuendorffer's avatar Stephen Neuendorffer
Browse files

[MLIR] Ensure that target_link_libraries() always has a keyword. 

CMake allows calling target_link_libraries() without a keyword,
but this usage is not preferred when also called with a keyword,
and has surprising behavior.  This patch explicitly specifies a
keyword when using target_link_libraries().

Differential Revision: https://reviews.llvm.org/D75725
parent fc6fda90

mlir/lib/Analysis/CMakeLists.txt

+9 −2
Original line number Diff line number Diff line
@@ -33,7 +33,11 @@ add_dependencies(MLIRAnalysis 
  MLIRLoopOps

  )



target_link_libraries(MLIRAnalysis MLIRAffineOps MLIRLoopOps)

target_link_libraries(MLIRAnalysis

  PUBLIC

  MLIRAffineOps

  MLIRLoopOps

  )



add_llvm_library(MLIRLoopAnalysis

  AffineAnalysis.cpp
@@ -53,4 +57,7 @@ add_dependencies(MLIRLoopAnalysis 
  MLIRLoopOps

  )



target_link_libraries(MLIRLoopAnalysis MLIRAffineOps MLIRLoopOps)
 
target_link_libraries(MLIRLoopAnalysis

  PUBLIC

  MLIRAffineOps

  MLIRLoopOps)

mlir/lib/Conversion/AffineToStandard/CMakeLists.txt

+1 −1
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ add_dependencies( 
)

target_link_libraries(

  MLIRAffineToStandard



  PUBLIC

  MLIRAffineOps

  MLIRLoopOps

  MLIRPass

mlir/lib/Conversion/GPUToCUDA/CMakeLists.txt

+1 −0
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ endif() 


add_mlir_conversion_library(MLIRGPUtoCUDATransforms ${SOURCES})

target_link_libraries(MLIRGPUtoCUDATransforms

  PUBLIC

  MLIRGPU

  MLIRLLVMIR

  MLIRNVVMIR

mlir/lib/Conversion/GPUToNVVM/CMakeLists.txt

+1 −0
Original line number Diff line number Diff line
@@ -10,6 +10,7 @@ add_dependencies(MLIRGPUtoNVVMTransforms 
  MLIRGPUToNVVMIncGen)



target_link_libraries(MLIRGPUtoNVVMTransforms

  PUBLIC

  LLVMSupport

  MLIRGPU

  MLIRLLVMIR

mlir/lib/Conversion/GPUToROCDL/CMakeLists.txt

+1 −0
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ add_mlir_conversion_library(MLIRGPUtoROCDLTransforms 
  LowerGpuOpsToROCDLOps.cpp

  )

target_link_libraries(MLIRGPUtoROCDLTransforms

  PUBLIC

  LLVMSupport

  MLIRGPU

  MLIRLLVMIR