Commit 15a172be authored by Davide Italiano's avatar Davide Italiano
Browse files

[TypeCategory] Nothing passes down a list of languages. 

Summary: This should allow further simplifications, but it's a first step.

Reviewers: teemperor, jingham, friss

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D70983
parent b3fdf33b

lldb/include/lldb/DataFormatters/TypeCategory.h

+1 −2
Original line number Diff line number Diff line
@@ -214,8 +214,7 @@ public: 
    ValidatorContainer::RegexMatchForEachCallback m_validator_regex;

  };



  TypeCategoryImpl(IFormatChangeListener *clist, ConstString name,

                   std::initializer_list<lldb::LanguageType> langs = {});

  TypeCategoryImpl(IFormatChangeListener *clist, ConstString name);



  template <typename T> void ForEach(const ForEachCallbacks<T> &foreach) {

    GetTypeFormatsContainer()->ForEach(foreach.GetFormatExactCallback());

lldb/source/DataFormatters/TypeCategory.cpp

+3 −7
Original line number Diff line number Diff line
@@ -13,18 +13,14 @@ 
using namespace lldb;

using namespace lldb_private;



TypeCategoryImpl::TypeCategoryImpl(

    IFormatChangeListener *clist, ConstString name,

    std::initializer_list<lldb::LanguageType> langs)

TypeCategoryImpl::TypeCategoryImpl(IFormatChangeListener *clist,

                                   ConstString name)

    : m_format_cont("format", "regex-format", clist),

      m_summary_cont("summary", "regex-summary", clist),

      m_filter_cont("filter", "regex-filter", clist),

      m_synth_cont("synth", "regex-synth", clist),

      m_validator_cont("validator", "regex-validator", clist), m_enabled(false),

      m_change_listener(clist), m_mutex(), m_name(name), m_languages() {

  for (const lldb::LanguageType lang : langs)

    AddLanguage(lang);

}

      m_change_listener(clist), m_mutex(), m_name(name), m_languages() {}



static bool IsApplicable(lldb::LanguageType category_lang,

                         lldb::LanguageType valobj_lang) {