Commit 14a16fae authored by Mircea Trofin's avatar Mircea Trofin
Browse files

[llvm][NFC] Rename CallAnalyzer::onCommonInstructionSimplification 

Summary:
It is called when instructions aren't simplified, and the implementation
is expected to account for a penalty. Renamed to
onCommonInstructionMissedSimplification.

Reviewers: davidxl, eraman

Reviewed By: davidxl

Subscribers: hiraditya, baloghadamsoftware, haicheng, a.sidorin, Szelethus, donat.nagy, dkrupp, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73662
parent fa14522c

llvm/lib/Analysis/InlineCost.cpp

+3 −3
Original line number Diff line number Diff line
@@ -185,7 +185,7 @@ protected: 


  /// Called to account for any other instruction not specifically accounted

  /// for.

  virtual void onCommonInstructionSimplification() {}

  virtual void onMissedSimplification() {}



  /// Start accounting potential benefits due to SROA for the given alloca.

  virtual void onInitializeSROAArg(AllocaInst *Arg) {}
@@ -502,7 +502,7 @@ class InlineCostCallAnalyzer final : public CallAnalyzer { 


    addCost(SwitchCost, (int64_t)CostUpperBound);

  }

  void onCommonInstructionSimplification() override {

  void onMissedSimplification() override {

    addCost(InlineConstants::InstrCost);

  }
@@ -1761,7 +1761,7 @@ CallAnalyzer::analyzeBlock(BasicBlock *BB, 
    if (Base::visit(&*I))

      ++NumInstructionsSimplified;

    else

      onCommonInstructionSimplification();

      onMissedSimplification();



    using namespace ore;

    // If the visit this instruction detected an uninlinable pattern, abort.