Commit 0db94812 authored by Arthur Eubanks's avatar Arthur Eubanks
Browse files

[NFC] Remove FIXMEs about calling LLVMContext::yield() 

Nobody has complained about this, and the documentation for
LLVMContext::yield() states that LLVM is allowed to never call it.

Reviewed By: asbirlea

Differential Revision: https://reviews.llvm.org/D110008
parent 843390c5

llvm/include/llvm/IR/PassManager.h

+0 −6
Original line number Diff line number Diff line
@@ -536,12 +536,6 @@ public: 
      // Finally, intersect the preserved analyses to compute the aggregate

      // preserved set for this pass manager.

      PA.intersect(std::move(PassPA));



      // FIXME: Historically, the pass managers all called the LLVM context's

      // yield function here. We don't have a generic way to acquire the

      // context and it isn't yet clear what the right pattern is for yielding

      // in the new pass manager so it is currently omitted.

      //IR.getContext().yield();

    }



    // Invalidation was handled after each pass in the above loop for the

llvm/lib/Analysis/CGSCCPassManager.cpp

+0 −6
Original line number Diff line number Diff line
@@ -119,12 +119,6 @@ PassManager<LazyCallGraph::SCC, CGSCCAnalysisManager, LazyCallGraph &, 
    // Finally, we intersect the final preserved analyses to compute the

    // aggregate preserved set for this pass manager.

    PA.intersect(std::move(PassPA));



    // FIXME: Historically, the pass managers all called the LLVM context's

    // yield function here. We don't have a generic way to acquire the

    // context and it isn't yet clear what the right pattern is for yielding

    // in the new pass manager so it is currently omitted.

    // ...getContext().yield();

  }



  // Before we mark all of *this* SCC's analyses as preserved below, intersect

llvm/lib/Transforms/Scalar/LoopPassManager.cpp

+0 −12
Original line number Diff line number Diff line
@@ -124,12 +124,6 @@ LoopPassManager::runWithLoopNestPasses(Loop &L, LoopAnalysisManager &AM, 
    // notify the updater, otherwise U.ParentL might gets outdated and triggers

    // assertion failures in addSiblingLoops and addChildLoops.

    U.setParentLoop(L.getParentLoop());



    // FIXME: Historically, the pass managers all called the LLVM context's

    // yield function here. We don't have a generic way to acquire the

    // context and it isn't yet clear what the right pattern is for yielding

    // in the new pass manager so it is currently omitted.

    // ...getContext().yield();

  }

  return PA;

}
@@ -173,12 +167,6 @@ LoopPassManager::runWithoutLoopNestPasses(Loop &L, LoopAnalysisManager &AM, 
    // notify the updater, otherwise U.ParentL might gets outdated and triggers

    // assertion failures in addSiblingLoops and addChildLoops.

    U.setParentLoop(L.getParentLoop());



    // FIXME: Historically, the pass managers all called the LLVM context's

    // yield function here. We don't have a generic way to acquire the

    // context and it isn't yet clear what the right pattern is for yielding

    // in the new pass manager so it is currently omitted.

    // ...getContext().yield();

  }

  return PA;

}