Graham, Aaron authored Jan 15, 2020 and Stimpson, Shane G committed Jan 15, 2020

* Address code that does not adhere to the code standard

Fixes 3 things:
1. Removes author, data, revision, and dependencies from module headers
2. Removes unneeded indentation inside MODULE statments
3. Removes unneeded indentation inside module CONTAINS statements

* Fix coinuation line indentations

* Fix SELECTTYPE and SELECTCASE indentations

* Fix indentation for PROGRAM and MODULE blocks in unit tests

* Fix continuation lines and SELECT TYPE/CASE in unit tests

HendersonSC authored Jan 13, 2020 and Stimpson, Shane G committed Jan 13, 2020

* Implements string replace method and testing

* Clean up StringType doxygen, add check for clear method

* Add testing. Fix doxygen comments

* Remove ALL/ANY overload for string types

* Remove unused variable

HendersonSC authored Jan 13, 2020 and Stimpson, Shane G committed Jan 13, 2020

* Removes unused parameter definitions

* Re-add parameter inside preproc

* Add test for unused_parameters to CI

* Last few unused_parameters

* Rearrange preproc to remove unused variable

Gentry, Cole authored Jan 10, 2020 and Stimpson, Shane G committed Jan 10, 2020

* Initial implementation of SchemaParser

* Addressed reviewer comments, add ability to handle inline comments, add ability to client code to define its own EntryType for parsing

* Fixed some compile bugs revealed during Futility CI build

* Fixed some another compile bug when building the Schema unit test

* Addressed a number of reviewer comments

* Addressed some additional reviewer comments

* Incorporated new str function from IO_Strings

* Fixed some errors in REQUIRE statements

* Addressed an additional bug a REQUIRE statement and removed the Type suffix from all other types in SchemaParser

* Removed an unnecessary REQUIRED check on a bool to ensure it's either true or false

* Fixed some issues in SchemaParser where legacy string manipulation functions were being used

apfitzge authored Jan 10, 2020 and Stimpson, Shane G committed Jan 10, 2020

In routines adding or removing timers, changed
TYPE(TimerType) to CLASS(TimerType) in order to match the TimerPtrArray
specification.

* Adding routine to convert a PL of PLs to a 2-D string array.

* Adding unit test for convertTo2DStringArray.

* Whitespace.

* Removing unused variables.

* Deleting commented out code.  Adding all paramtypes to unit test.

Description:

CASL Ticket # - PHI 6088

* Removing unneeded variables.

Description:
Two parameter list pointers and a string variable were not needed.

CASL Ticket # - PHI 6088

HendersonSC authored Jan 08, 2020 and Stimpson, Shane G committed Jan 08, 2020

* Implements string replace method and testing

* Clean up StringType doxygen, add check for clear method

* Add testing. Fix doxygen comments

Jones, Jesse authored Dec 31, 2019 and Stimpson, Shane G committed Dec 31, 2019

* Refactor of Debug Build Flags #6196

* Changing gcc debug flags for Fortran to give better performance

* Revert changes related to release build

* Updating the %getString function.

Description:
Originally, the function would only return a string for scalar values,
and the developer was responsible for selecting the correct %getString*
subroutine depending on the parameter type being converted, whether a
scalar, 1-D, 2-D, or 3-D array.

This change allows the developer to use the scalar %getString function
for any dimension of parameter.

* Adding unit tests for the updated %getString routine.

* Prune the ending ',' when writing the arrays.

* Replacing integer writes with calls to function str(integer).

* Changing the default delimiter to be ;.  Updating tests.

* Addressing Yuxuan's comments.

Description:
Removing commented out code.
Adding subroutine descriptions.
Removing optional delim argument.
Updating comments and replacing getSubstring with %substr()

CASL Ticket # - N/A

* Fixing SELECTTYPE indentation

Description:

CASL Ticket # - N/A

* Addressing review comments. Updating error messages, unit test assertions.

Description:

CASL Ticket # - N/A

* Other review comments. Fixing comment descriptions, updated assertions.

Description:

CASL Ticket # - N/A

* Changing the delimeter from ";" to surrounding '"'s

Description:
This change is primarily for better interoperability with the getField()
subroutine.  In this manner, each entry from a multi-dimensional array
is added to the scalar string as a separate field.

CASL Ticket # - PHI 6173

* Deleting unused variable.

Description:

CASL Ticket # - PHI 6173

* Adding writeTable routine as a type-bound procedure.

Description:
Since all writing will be done to files, the logical place to put the
writing of the 2-D array of strings is on the base Fortran type since
this class is used for the output file.

CASL Ticket # - PHI 6089

* Adding routine to get the table bounds from a 2-D string array.

Description:
This routine gets the maximum width of each column and the maximum
height of every row in the input table.

CASL Ticket # - PHI 6089

* Adding function to output table row separator string.

Description:

CASL Ticket # - PHI 6089

* Simplifying some logical assignments.

Description:
Get rid of IF checks, just assign based on the logical result.

CASL Ticket # - PHI 6089

* Change interface to use fortran file type.

Description:

CASL Ticket # - PHI 6089

* Adding tests for the writeTable routine.

Description:

CASL Ticket # - PHI 6089

* Delete unused variable.

Description:

CASL Ticket # - PHI 6089

* Splitting writeTable routine into two routines.

Description:
The first routine will convert a 2-D string array table into a 1-D array
of strings, or lines, and will exist in IO_Strings. The 1-D string array
can then be passed to the second routine on the fortran file type,
%fwrite, to be written.  Currently only 1-D strings are supported for
the %fwrite interface.

CASL Ticket # - PHI 6089

* Updating comment to reflect correct input variable name

Description:

CASL Ticket # - PHI 6089

* Addressing comments, deleting comments, adding description, and DBC.

Description:

CASL Ticket # - PHI 6089

* Changing the parsing not use the ";".  Expecting quotes instead.

Description:
Removing index checks for ';', and enforcing the use of getField for all
entries, scalar and array.  The %getString function will enclose array
entries in quotes now, making it easy to use the getField() call.  The
maxrowsize is determined by the nfields() call instead of nmatchstr.

CASL Ticket # - PHI 6089

Description:
Adding %wtfactor attribute used to scale the %wts in the input.  The
default is 1.0.
Adding optional argument to %metrics() routine for the max number of
source regions ratio for the given decomposition.

Graham, Aaron authored Nov 14, 2019 and Stimpson, Shane G committed Nov 14, 2019

* Revert "Making the maxnsr output argument optional."

This reverts commit 7e5dc278.

* Revert "Adding DBC modules.  Fixing typo."

This reverts commit c2107127.

* Revert "Adding DBC checks on the output of %metrics.  Fixing input arg description."

This reverts commit 38eff0c9.

* Revert "Updating initial wtfactor value.  Adding it to %clear() routine."

This reverts commit 236432f0.

* Revert "Updating and adding tests for the weighting factor."

This reverts commit d1e5e98c.

* Revert "Updating PartitionGraph and metrics routine to account for weighting factor."

This reverts commit fbd20fde.

Description:
This ensures the change to the interface won't break MPACT.

CASL Ticket # - N/A

Description:
Updating the init, clear, and metrics subtests.

Description:
When calling the calcDecompMetrics routine, the %wts associated with
each vertex were already assumed to be normalized. This prevented the
ratio of process source regions to total source regions from being
calculated since they were normalized to 1.

A weighting factor was added to the type, the initialization parameter
list, and is used in the updated calcDecompMetrics routine to now return
the maximum ratio of process source regions to total regions.

Applies a fix for the cchar to fchar interface

HendersonSC authored Nov 06, 2019 and COLLINSBS email committed Nov 06, 2019

* Implement string library like functionality

* Adds a check to ensure strings are allocated correctly

* Remove double colon from module procedure

Description:
The TPLs in the docker image were updated for HDF5 and
PETSc, but the corresponding versions in the build_on_docker.sh
build script were not updated. This commit updates them to the current.

Github Issue - #132

Description:
Changing rest of ; to && so errors from any intermediate command
seem to cause travis-ci to register a failure.

Github Issue - #132

Description:
In bash when chaining commands, the && will only execute the next
command if the previous command had a return value of 0. When using
; it will execute the next command regardless of the return code.

Not sure how TravisCI treats the error code in reporting errors,
so I'm hoping this reveals the issue.

Github Issue - #132

Fix for very long warning messages

Improve vtk efficiency

In some cases this will help with debugging when the system returns
a useful error message.

This can be used to improve the efficiency of VTKMeshType setup
when many summations will occur.  It is more efficient to do them
all together than repeatedly performing individual additions

Revert "Implements commons string functionality on StringType"

Revert "assign_cchar_to_string"